• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Aliii

Java - How to stop or pause a thread?

5 posts in this topic

Ive read that stop() is deprecated, but its not reacting to interrupt or suspend either.

So I extended an AsyncTask class and overrode some methods.
Ive read that this while( running) magic is like "killing the thread manually".
Is there any better solution? I think that a while looping continuously in the background is not too efficient.

(Plus: could somebody tell me what exactly thread.join() does?
"[color=#000000]Blocks the calling thread until a thread terminates, while continuing to perform standard COM and SendMessage pumping.[/color]"
...yes, sure:))

Thanks!
..................................................
public void stop(){
running= false;
}

public void pause(){
paused= true;
}

public void resume(){
paused= false;
}


@Override
protected String doInBackground(Integer... params) {

running= true;
paused= false;

while(running){

if( paused){
...do nothing
}
else{

....do stuff

}
}

return null;
}
0

Share this post


Link to post
Share on other sites
You should not use boolean variables to signal to a thread; that is subject to race conditions and can easily produce undesirable nondeterministic behavior.

Instead, use a [i]thread synchronization primitive[/i] such as a condition variable or semaphore to signal when you want your thread to run. This allows the OS to control the thread properly, and will have the added bonus of making your thread consume no CPU resources when it is not active.
0

Share this post


Link to post
Share on other sites
[quote]"[color=#000000]Blocks the calling thread until a thread terminates, while continuing to perform standard COM and SendMessage pumping.[/color]"[/quote]

That is .Net.

[quote]AsyncTask[/quote]

That is Android.

[quote]stop() is deprecated,[/quote]

And that is JDK/JEE's Thread class.

So the original question mixes some 3 different platforms.


For which of those is the question intended?

[quote]Is there any better solution?[/quote]

For what exactly? Threads are created, they run and then terminate. Stopping or otherwise interferring with them has long been abandoned due to problems it causes.

What are you really trying to accomplish?
1

Share this post


Link to post
Share on other sites
Threads on every platform already have built-in suspend/resume mechanisms, you should those instead of rolling your own.

[quote]For what exactly? Threads are created, they run and then terminate. Stopping or otherwise interferring with them has long been abandoned due to problems it causes.[/quote]
For very long-running tasks it's important for the user to be able to suspend the process at any given time, and suspend/resume is much better in that respect than destroying and recreating every thread used. If you use the mechanisms provided by your OS (and transparently interfaced by Java) it will work perfectly too.
0

Share this post


Link to post
Share on other sites
[quote name='Bacterius' timestamp='1335311029' post='4934578']
Threads on every platform already have built-in suspend/resume mechanisms, you should those instead of rolling your own.
[/quote]
This isn't a good idea (depending on exactly what you mean by built-in suspend resume mechanisms). It you suspend a thread while it has a lock held, that's a great way to bring the rest of your application to a stand-still.


[quote]
For very long-running tasks it's important for the user to be able to suspend the process at any given time.
[/quote]
As ApochPiQ said, primitives such as condition variables and semaphores are the things to use.

I agree with what you say about not having to (re)create threads on a regular basis, but the correct way to feed them work is to use queues of tasks or data. Many environments will provide suitable queues out the box, which will use the aforementioned primitives internally. I'm sure this is true of Java, in particular
1

Share this post


Link to post
Share on other sites
Thanks for the answers!

[quote name='ApochPiQ' timestamp='1335308905' post='4934570']
You should not use boolean variables to signal to a thread; that is subject to race conditions and can easily produce undesirable nondeterministic behavior.

Instead, use a [i]thread synchronization primitive[/i] such as a condition variable or semaphore to signal when you want your thread to run. This allows the OS to control the thread properly, and will have the added bonus of making your thread consume no CPU resources when it is not active.
[/quote]

Ive found a piece of code that does something like that, but I dont think I can do this with AsyncTask. I dont know what that constructor does([font=Consolas, Menlo, Monaco,]runner [/font][font=Consolas, Menlo, Monaco,]=[/font][font=Consolas, Menlo, Monaco,] [/font][font=Consolas, Menlo, Monaco,]new[/font][font=Consolas, Menlo, Monaco,] [/font][font=Consolas, Menlo, Monaco,]Thread[/font][font=Consolas, Menlo, Monaco,]([/font][font=Consolas, Menlo, Monaco,]this[/font][font=Consolas, Menlo, Monaco,]);[/font]). However Ive found an AsyncTask.cancel() method that stops the thread just fine(if I handle the interrupt-exception in the run method), but there is no pause/resume method. Is it OK if I declare that pause boolean volatile and do it that way? I guess that will consume CPU too. Or should I save the threads state when I stop it and reload from that when is start it again(resume)? Thanks!


[color=#00008B][background=transparent]private[/background][/color][background=transparent] [/background][color=#00008B][background=transparent]volatile[/background][/color][background=transparent] [/background][color=#2B91AF][background=transparent]Thread[/background][/color][background=transparent] runner[/background][background=transparent];[/background]

[color=#00008B][background=transparent]public[/background][/color][background=transparent] [/background][color=#00008B][background=transparent]synchronized[/background][/color][background=transparent] [/background][color=#00008B][background=transparent]void[/background][/color][background=transparent] startThread[/background][background=transparent](){[/background]
[background=transparent] [/background][color=#00008B][background=transparent]if[/background][/color][background=transparent]([/background][background=transparent]runner [/background][background=transparent]==[/background][background=transparent] [/background][color=#00008B][background=transparent]null[/background][/color][background=transparent]){[/background]
[background=transparent] runner [/background][background=transparent]=[/background][background=transparent] [/background][color=#00008B][background=transparent]new[/background][/color][background=transparent] [/background][color=#2B91AF][background=transparent]Thread[/background][/color][background=transparent]([/background][color=#00008B][background=transparent]this[/background][/color][background=transparent]);[/background]
[background=transparent] runner[/background][background=transparent].[/background][background=transparent]start[/background][background=transparent]();[/background]
[background=transparent] [/background][background=transparent]}[/background]
[background=transparent]}[/background]

[color=#00008B][background=transparent]public[/background][/color][background=transparent] [/background][color=#00008B][background=transparent]synchronized[/background][/color][background=transparent] [/background][color=#00008B][background=transparent]void[/background][/color][background=transparent] stopThread[/background][background=transparent](){[/background]
[background=transparent] [/background][color=#00008B][background=transparent]if[/background][/color][background=transparent]([/background][background=transparent]runner [/background][background=transparent]!=[/background][background=transparent] [/background][color=#00008B][background=transparent]null[/background][/color][background=transparent]){[/background]
[background=transparent] [/background][color=#2B91AF][background=transparent]Thread[/background][/color][background=transparent] moribund [/background][background=transparent]=[/background][background=transparent] runner[/background][background=transparent];[/background]
[background=transparent] runner [/background][background=transparent]=[/background][background=transparent] [/background][color=#00008B][background=transparent]null[/background][/color][background=transparent];[/background]
[background=transparent] moribund[/background][background=transparent].[/background][background=transparent]interrupt[/background][background=transparent]();[/background]
[background=transparent] [/background][background=transparent]}[/background]
[background=transparent]}[/background]

[color=#00008B][background=transparent]public[/background][/color][background=transparent] [/background][color=#00008B][background=transparent]void[/background][/color][background=transparent] run[/background][background=transparent](){[/background]
[background=transparent] [/background][color=#00008B][background=transparent]while[/background][/color][background=transparent]([/background][color=#2B91AF][background=transparent]Thread[/background][/color][background=transparent].[/background][background=transparent]currentThread[/background][background=transparent]()[/background][background=transparent] [/background][background=transparent]==[/background][background=transparent] runner[/background][background=transparent]){[/background]
[background=transparent] [/background][color=gray][background=transparent]//do stuff which can be interrupted if necessary[/background][/color]
[background=transparent] [/background][background=transparent]}[/background]
[background=transparent]}[/background]
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0