• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
medevilenemy

OpenGL
FBO woes

21 posts in this topic

I've been trying to come up with a way to draw an opaque quad over my scene through which holes would be punched to allow one to see the scene below. Through some research and with some help I've determined that the best way to do this is probably by rendering to a texture through a framebuffer object, alphablending the holes into the quad and then drawing the texture over the scene. I'm having trouble getting it to work, though, and I can't find examples of what I'm trying to do.

So far I've succeeded in creating my framebuffer object and target texture based on the example block at the bottom of [url="http://www.songho.ca/opengl/gl_fbo.html."]http://www.songho.ca...gl/gl_fbo.html[/url]. After that, I've attempted various configurations of drawing what I want to the texture, but all I can seem to manage is to draw an opaque quad to it. I can't seem to get depth, alpha blending, or even texture mapping to work properly (no matter how I map the texture coords, the result is the same). glClear(GL_COLOR_BUFFER_BIT) on the texture causes my whole scene to get messed up, as well. The following code demonstrates how I'm trying to set up rendering to the texture:

[code]
glPushMatrix();
// set rendering destination to FBO
glBindFramebuffer(GL_FRAMEBUFFER, 92);

glViewport(0,0,screen_width, screen_height);
glMatrixMode(GL_PROJECTION);
glLoadIdentity();

// Clearing buffers
glClearDepth(1.0f);
glClearColor(0.0f, 0.0f, 0.0f, 1.0f);
glClear(GL_DEPTH_BUFFER_BIT); // Clearing the GL_COLOR_BUFFER_BIT causes things to break

// Set up internal rendering projection
glOrtho(-0.5 * width, 0.5*width, -1, 1, 1, 0);

glEnable(GL_BLEND);
glEnable(GL_DEPTH_TEST);

// Set blend func
//glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA);

// Draw stuff here! At the moment just trying to draw a couple overlapping quads as a proof of concept

// Unbind fbo
glBindFramebuffer(GL_FRAMEBUFFER, 0);
glPopMatrix();

// Set scene-relative blending function.
glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); // function for blending

// Draw the rendered texture on top of the underlying scene
glEnable(GL_TEXTURE_2D);
glBindTexture(GL_TEXTURE_2D, 90);
glBegin(GL_QUADS);
glTexCoord2f(0.0, 0.0f); glVertex3f(-0.1,-0.1,0.01); // Bottom-Left Vertex
glTexCoord2f(1.0f, 0.0f); glVertex3f(0.1,-0.1,0.01); // Bottom-Right Vertex
glTexCoord2f(1.0f, 1.0f); glVertex3f(0.1,0.1,0.01); // Top-Right Vertex
glTexCoord2f(0.0f, 1.0f); glVertex3f(-0.1,0.1,0.01); // Top-Left Vertex
glEnd();
glDisable(GL_TEXTURE_2D);
[/code]

Any help is greatly appreciated!
0

Share this post


Link to post
Share on other sites
I've been doing some more tweaking, and have managed to be able to glClear(GL_COLOR_BUFFER_BIT) on the texture without messing other things up, but that's about as far as I've been able to get. I still can't seem to get something to take up only part of the texture, and can't seem to get multiple quads drawn to it (as a test) to actually blend together... I just see whichever was drawn later.

My best guess is that the texture itself isn't functioning properly (its as if it isn't mapping at all)... but that doesn't make any sense... I've done everything the couple examples I've seen does. Edited by medevilenemy
0

Share this post


Link to post
Share on other sites
The link seems to be down so I can't check your FBO setup. Can you post that code too? Did you actually bind at least one color buffer and a depth buffer to the FBO?

In the rendering code, after binding your FBO, you can check it with
[CODE]
GLenum status = glCheckFramebufferStatusEXT(GL_FRAMEBUFFER_EXT);
if (status != GL_FRAMEBUFFER_COMPLETE_EXT)
cry_out_in_pain();
[/CODE]
Just to see if s.th. broke it on the way.

Also (for debugging purposes) throw in this define somewhere
[CODE]
#define CHECKGLERROR(f, l) \
{ \
GLuint error = glGetError(); \
if (error) \
std::cout << "GL Error in " << f << " " << l << ": " << gluErrorString(error) << " (" << error << "). " << std::endl; \
}
[/CODE]
and do a CHECKGLERROR(__FILE__, __LINE__) after each OpenGL call.


Edit: fixed the preprocessor macro Edited by Ohforf sake
1

Share this post


Link to post
Share on other sites
somehow the period got added to the link... the page itself is still there: [url="http://www.songho.ca...gl/gl_fbo.html"]http://www.songho.ca...gl/gl_fbo.html[/url].

I tested for FBO completeness, and it seems to be ok. I'll give the macro you suggest a try, and get back to you. Based on my most recent tests, the best I can guess is that for whatever reason, the texture isn't functional (either not rendering or not complete or something) which results in the textured quad that's supposed to be drawing it just drawing as a straight-up colored quad.
0

Share this post


Link to post
Share on other sites
Uppon closer inspection this might also be a problem:
glOrtho(-0.5 * width, 0.5*width, -1, 1, 1, 0);

I think you switched the zNear and zFar plane at the end and that it should be:
glOrtho(-0.5 * width, 0.5*width, -1, 1, [b]0[/b], [b]1[/b]);
0

Share this post


Link to post
Share on other sites
That is the ortho setup I use in my main scene as well... it works just fine (I like to have bigger z = farther, I find it easier to remember). It seems like the problem has something to do with the rbo/texture setup or something, but I haven't a clue what. The fbo tests as complete.
0

Share this post


Link to post
Share on other sites
But don't you have to clear the depth to 0.0f then?
glClearDepth(0.0f);
Edit: Also glDepthFunc(GL_GEQUAL); but maybe thats hiding somewhere outside of that snippet. Edited by Ohforf sake
1

Share this post


Link to post
Share on other sites
No effect. All I see is a box of the size of the textured quad I'm drawing as a test in whatever the active color is. It does not seem to succesfully map a texture (which suggests the texture is somehow invalid).

I've done some testing for gl errors and I get the following when I try to bind the framebuffer object as I prepare to draw to it:
GL ERROR: invalid operation (1282)

This doesn't make any sense as the framebuffer object itself tests as complete.

[edit] by the way, thanks for your help so far. Edited by medevilenemy
0

Share this post


Link to post
Share on other sites
Could you post your updated source?

And, quick question, you use '92' and '90' as the GLuint reference, why not use a GLuint variable?
0

Share this post


Link to post
Share on other sites
After doing some sanity checking with a friend of mine, I determined that I was using glgenframebuffers wrong, so I have fixed that... so now instead of getting a quad with whatever the active color is, I now see... nothing at all. The updated version of the RTT code is as follows:

[CODE]
float bleh = 2 * ((double)screen_width/(double)screen_height);

// set rendering destination to FBO
glBindFramebuffer(GL_FRAMEBUFFER, fbonum);

glPushAttrib(GL_VIEWPORT_BIT | GL_ENABLE_BIT);

// clear buffers
//glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);

//glDepthFunc(GL_EQUAL);
glClearDepth(0.0f);
glClearColor(0.0f, 0.0f, 0.0f, 1.0f);
glClear(GL_DEPTH_BUFFER_BIT | GL_COLOR_BUFFER_BIT);
//glLoadIdentity();
glOrtho(-0.5 * bleh, 0.5*bleh, -1, 1, 1, 0);
//gluLookAt(Position.x,Position.y,Position.z,ViewPoint.x,ViewPoint.y,ViewPoint.z,UpVector.x,UpVector.y,UpVector.z);
glViewport(0,0,screen_width, screen_height);
glEnable(GL_BLEND);
glEnable(GL_DEPTH_TEST);

//glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); // function for blending
glBlendFunc(GL_ONE, GL_ONE); // function for blending
glColor4d(0.0, 1.0, 1.0, 0.0);
glBegin(GL_QUADS);
glVertex3d(0.0, 0.5, 0.0);
glVertex3d(0.5, 0.5, 0.0);
glVertex3d(0.5, -0.5, 0.5);
glVertex3d(0.0, -0.5, 0.5);
glEnd();

glColor4d(1.0, 0.0, 1.0, 1.0);
glBegin(GL_QUADS);
glVertex3d(0.1, 0.5, 0.0);
glVertex3d(0.6, 0.5, 0.0);
glVertex3d(0.6, -0.5, 0.0);
glVertex3d(0.1, -0.5, 0.0);
glEnd();

glPopAttrib();
glBindFramebuffer(GL_FRAMEBUFFER, 0);



glColor4d(1.0, 1.0, 0.0, 1.0);
//glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA);
glBlendFunc(GL_ONE, GL_ONE);
glEnable(GL_TEXTURE_2D);
glBindTexture(GL_TEXTURE_2D, rttnum);

glBegin(GL_QUADS);
glTexCoord2f(0.0f, 0.0f); glVertex3f(-0.3,-0.3,0.0); // Bottom-Left Vertex
glTexCoord2f(1.0f, 0.0f); glVertex3f(0.3,-0.3,0.0); // Bottom-Right Vertex
glTexCoord2f(1.0f, 1.0f); glVertex3f(0.3,0.3,0.01); // Top-Right Vertex
glTexCoord2f(0.0f, 1.0f); glVertex3f(-0.3,0.3,0.01); // Top-Left Vertex
glEnd();
glDisable(GL_TEXTURE_2D);
[/CODE]

Apologies for the silly names and stuff... its just a proof of concept so I wasn't trying to use serious names in all places.
0

Share this post


Link to post
Share on other sites
Some random ideas:

I believe there is a restriction, that a rendertarget texture can not be bound while the FBO is bound and the FBO in turn can not be bound while the texture is bound. I could be wrong though ^^.
Anyways, try doing a

glBindTexture(GL_TEXTURE_2D, 0);

after you used the texture and before you loop back to binding the FBO.


Also, glClear(...) only affects the current viewport so you should set the viewport before doing glClear(...).


Did you use glDrawBuffers to specifiy, which RT to clear/render to?



It would really help to see the full code, including FBO setup and all the states you set for rendering!
0

Share this post


Link to post
Share on other sites
No effect. Moved glClear stuff around and unbound whatever texture might be active right before the FBO bind, but I still see nothing. I'm currently using glBlendFunc(GL_ONE,GL_ZERO) for both stages of blending (onto tex and tex onto scene) just for testing purposes, FYI. Not familiar with glDrawBuffers.

Here's the test code I'm using:

My init stuff...
[CODE]
GLenum err = glewInit();
if (GLEW_OK != err)
{
exit(0);
}
else
{
if (GLEW_ARB_framebuffer_object)
{
}
}

glEnable(GL_TEXTURE_2D);
glEnable(GL_COLOR_MATERIAL);
glGenTextures(1, &rttnum);

glBindTexture(GL_TEXTURE_2D, rttnum);
glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR);
glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR_MIPMAP_LINEAR);
glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
glTexParameteri(GL_TEXTURE_2D, GL_GENERATE_MIPMAP, GL_TRUE); // automatic mipmap
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, screen_width, screen_height, 0, GL_RGBA, GL_UNSIGNED_BYTE, 0);

glBindTexture(GL_TEXTURE_2D, 0);

// create a renderbuffer object to store depth info
GLuint rboId = 1;
glGenRenderbuffers(1, &rboId);

glBindRenderbuffer(GL_RENDERBUFFER, rboId);

glRenderbufferStorage(GL_RENDERBUFFER, GL_DEPTH_COMPONENT24, screen_width, screen_height);

// create a framebuffer object
glGenFramebuffers(1, &fbonum);

glBindFramebuffer(GL_FRAMEBUFFER, fbonum);

// attach the texture to FBO color attachment point
glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, rttnum, 0);

// attach the renderbuffer to depth attachment point
glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_RENDERBUFFER, rboId);

// switch back to window-system-provided framebuffer
glBindRenderbuffer(GL_RENDERBUFFER, 0);
glBindFramebuffer(GL_FRAMEBUFFER, 0);
[/CODE]

And the rendering related stuff...
[CODE]
float bleh = 2 * ((double)screen_width/(double)screen_height);

// Unbind any texture that might currently be bound
glBindTexture(GL_TEXTURE_2D, 0);
// set rendering destination to FBO
glBindFramebuffer(GL_FRAMEBUFFER, fbonum);

glPushAttrib(GL_VIEWPORT_BIT | GL_ENABLE_BIT);

// clear buffers
//glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);

//glDepthFunc(GL_EQUAL);
glOrtho(-0.5 * bleh, 0.5*bleh, -1, 1, 1, 0);
glViewport(0,0,screen_width, screen_height);
glClearDepth(0.0f);
glClearColor(0.0f, 0.0f, 0.0f, 1.0f);
glClear(GL_DEPTH_BUFFER_BIT | GL_COLOR_BUFFER_BIT);
//glLoadIdentity();
glEnable(GL_BLEND);
glEnable(GL_DEPTH_TEST);

//glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); // function for blending
//glBlendFunc(GL_ONE, GL_ONE); // function for blending
glBlendFunc(GL_ONE, GL_ZERO);
glColor4d(0.0, 1.0, 1.0, 1.0);
glBegin(GL_QUADS);
glVertex3d(0.0, 0.5, 0.0);
glVertex3d(0.5, 0.5, 0.0);
glVertex3d(0.5, -0.5, 0.5);
glVertex3d(0.0, -0.5, 0.5);
glEnd();

glColor4d(1.0, 0.0, 1.0, 1.0);
glBegin(GL_QUADS);
glVertex3d(0.1, 0.5, 0.0);
glVertex3d(0.6, 0.5, 0.0);
glVertex3d(0.6, -0.5, 0.0);
glVertex3d(0.1, -0.5, 0.0);
glEnd();

glPopAttrib();
glBindFramebuffer(GL_FRAMEBUFFER, 0);



glColor4d(1.0, 1.0, 0.0, 1.0);
//glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA);
glBlendFunc(GL_ONE, GL_ZERO);
glEnable(GL_TEXTURE_2D);
glBindTexture(GL_TEXTURE_2D, rttnum);

glBegin(GL_QUADS);
glTexCoord2f(0.0f, 0.0f); glVertex3f(-0.3,-0.3,0.0); // Bottom-Left Vertex
glTexCoord2f(1.0f, 0.0f); glVertex3f(0.3,-0.3,0.0); // Bottom-Right Vertex
glTexCoord2f(1.0f, 1.0f); glVertex3f(0.3,0.3,0.01); // Top-Right Vertex
glTexCoord2f(0.0f, 1.0f); glVertex3f(-0.3,0.3,0.01); // Top-Left Vertex
glEnd();
glDisable(GL_TEXTURE_2D);


glBindTexture(GL_TEXTURE_2D, 0);
[/CODE]

[edit] Just attempted glDrawBuffer(GL_COLOR_ATTACHMENT0); right after binding the framebuffer and before drawing to it... no effect. Edited by medevilenemy
0

Share this post


Link to post
Share on other sites
ok, so I got it working, but without automatic mipmap generation. There might be a bug in NVidia's driver implementation (see [url="http://www.opengl.org/discussion_boards/showthread.php/175732-GL_GENERATE_MIPMAP-bug-%28nVidia%29"]http://www.opengl.or...AP-bug-(nVidia)[/url]) but I don't have the time to look into that right now. Do you actually need that?

Here is my code. Note, that I switched the depth interval (it confused the hell out of me ^^) and removed some stuff.
I think the two important changes are proper setup of the projection matrix (you were accumulating glOrthos) and removal of automatic mipmap generation.
[CODE]
GLuint rttnum;
glEnable(GL_TEXTURE_2D);
glEnable(GL_COLOR_MATERIAL);
glGenTextures(1, &rttnum);
glBindTexture(GL_TEXTURE_2D, rttnum);
glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR);
glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);//GL_LINEAR_MIPMAP_LINEAR);
glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
//glTexParameteri(GL_TEXTURE_2D, GL_GENERATE_MIPMAP, GL_TRUE); // automatic mipmap
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA8, 800, 600, 0, GL_RGBA, GL_UNSIGNED_BYTE, 0);
CHECKGLERROR(__FILE__, __LINE__)
glBindTexture(GL_TEXTURE_2D, 0);
// create a renderbuffer object to store depth info
GLuint rboId = 1;
glGenRenderbuffers(1, &rboId);
glBindRenderbuffer(GL_RENDERBUFFER, rboId);
glRenderbufferStorage(GL_RENDERBUFFER, GL_DEPTH_COMPONENT24, 800, 600);
GLuint fbonum;
// create a framebuffer object
glGenFramebuffers(1, &fbonum);
glBindFramebuffer(GL_FRAMEBUFFER, fbonum);
// attach the texture to FBO color attachment point
glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, rttnum, 0);
// attach the renderbuffer to depth attachment point
glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_RENDERBUFFER, rboId);
GLenum status = glCheckFramebufferStatusEXT(GL_FRAMEBUFFER_EXT);
if (status != GL_FRAMEBUFFER_COMPLETE_EXT)
std::cout << "incomplete: " << std::hex << status << std::endl;
// switch back to window-system-provided framebuffer
glBindRenderbuffer(GL_RENDERBUFFER, 0);
glBindFramebuffer(GL_FRAMEBUFFER, 0);
CHECKGLERROR(__FILE__, __LINE__)
bool shutdown = false;
while (!shutdown) {
// Unbind any texture that might currently be bound
glBindTexture(GL_TEXTURE_2D, 0);
// set rendering destination to FBO
glBindFramebuffer(GL_FRAMEBUFFER, fbonum);
GLenum status = glCheckFramebufferStatusEXT(GL_FRAMEBUFFER_EXT);
if (status != GL_FRAMEBUFFER_COMPLETE_EXT)
std::cout << "incomplete: " << std::hex << status << std::endl;
glViewport(0,0,800, 600);
glClearColor(0.0f, 0.0f, 0.0f, 1.0f);
glClear(GL_DEPTH_BUFFER_BIT | GL_COLOR_BUFFER_BIT);
glMatrixMode(GL_PROJECTION);
glLoadIdentity();
glOrtho(-1, 1, -1, 1, -1, 1);
glMatrixMode(GL_MODELVIEW);
glLoadIdentity();
glEnable(GL_DEPTH_TEST);

glColor4d(0.0, 1.0, 1.0, 1.0);
glBegin(GL_QUADS);
glVertex3d(0.0, 0.5, 0.5);
glVertex3d(0.5, 0.5, 0.5);
glVertex3d(0.5, -0.5, 0.5);
glVertex3d(0.0, -0.5, 0.5);
glEnd();
glColor4d(1.0, 0.0, 1.0, 1.0);
glBegin(GL_QUADS);
glVertex3d(0.1, 0.5, 0.0);
glVertex3d(0.6, 0.5, 0.0);
glVertex3d(0.6, -0.5, 0.0);
glVertex3d(0.1, -0.5, 0.0);
glEnd();
glBindFramebuffer(GL_FRAMEBUFFER, 0);
CHECKGLERROR(__FILE__, __LINE__)

glViewport(0,0,800, 600);
glClearColor(1.0f, 0.0f, 0.0f, 1.0f);
glClear(GL_DEPTH_BUFFER_BIT | GL_COLOR_BUFFER_BIT);
glMatrixMode(GL_PROJECTION);
glLoadIdentity();
glOrtho(-1, 1, -1, 1, -1, 1);
glMatrixMode(GL_MODELVIEW);
glLoadIdentity();

glColor4d(1.0, 1.0, 1.0, 1.0);
glEnable(GL_TEXTURE_2D);
glBindTexture(GL_TEXTURE_2D, rttnum);
glBegin(GL_QUADS);
glTexCoord2f(0.0f, 0.0f); glVertex3f(-0.3,-0.3,0.0); // Bottom-Left Vertex
glTexCoord2f(1.0f, 0.0f); glVertex3f(0.3,-0.3,0.0); // Bottom-Right Vertex
glTexCoord2f(1.0f, 1.0f); glVertex3f(0.3,0.3,0.01); // Top-Right Vertex
glTexCoord2f(0.0f, 1.0f); glVertex3f(-0.3,0.3,0.01); // Top-Left Vertex
glEnd();
glDisable(GL_TEXTURE_2D);
CHECKGLERROR(__FILE__, __LINE__)
glBindTexture(GL_TEXTURE_2D, 0);
SDL_Event event;
while (SDL_PollEvent(&event)) {
switch( event.type ) {
case SDL_QUIT:
shutdown = true;
break;
}
}
SDL_GL_SwapBuffers();
}
[/CODE]
1

Share this post


Link to post
Share on other sites
Thanks for the suggestion! I've tried adapting your approach to my context, with no effect. I think what is preventing it from working is my drawing of the underlying scene... Here's the code for the gameplay screen as I have it after trying to adapt your approach... This should let you see the context of the scene rendering happening so we can get them to mesh together. The setup stuff actually happens in a different source file outside the main loop. On the upside... the matrix mode changes have prevented bleedover and weirdness back into my menu screen... never really understood what modelview did before.

[CODE]
float bleh = 2 * ((double)screen_width/(double)screen_height);

// Unbind any texture that might currently be bound
glBindTexture(GL_TEXTURE_2D, 0);

// set rendering destination to FBO
glBindFramebuffer(GL_FRAMEBUFFER, fbonum);

// Set stuff up
glViewport(0,0,screen_width, screen_height);
glClearDepth(0.0f);
glClearColor(0.0f, 0.0f, 0.0f, 0.0f);
glClear(GL_DEPTH_BUFFER_BIT | GL_COLOR_BUFFER_BIT);
glMatrixMode(GL_PROJECTION);
glLoadIdentity();
glOrtho(-0.5 * bleh, 0.5*bleh, -1, 1, 1, 0);
glMatrixMode(GL_MODELVIEW);
glLoadIdentity();

//glTranslatef(0.0, 0.0, 0.0);

//glLoadIdentity();
glEnable(GL_ALPHA_TEST);
glEnable(GL_BLEND);
glEnable(GL_DEPTH_TEST);

//glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); // function for blending
//glBlendFunc(GL_ONE, GL_ONE); // function for blending
//glBlendFunc(GL_ONE, GL_ZERO);
glColor4d(0.0, 1.0, 1.0, 1.0);
glBegin(GL_QUADS);
glVertex3d(0.0, 0.5, 0.0);
glVertex3d(0.5, 0.5, 0.0);
glVertex3d(0.5, -0.5, 0.0);
glVertex3d(0.0, -0.5, 0.0);
glEnd();

glColor4d(1.0, 0.0, 1.0, 1.0);
glBegin(GL_QUADS);
glVertex3d(0.1, 0.5, 0.0);
glVertex3d(0.6, 0.5, 0.0);
glVertex3d(0.6, -0.5, 0.0);
glVertex3d(0.1, -0.5, 0.0);
glEnd();

glBindFramebuffer(GL_FRAMEBUFFER, 0);


// DRAW MAIN SCENE STARTING HERE
glViewport(0,0,screen_width,screen_height);
glClearColor(0.0f, 0.0f, 0.0f, 0.0f);
glClearDepth(1.0f);
glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);
glMatrixMode(GL_PROJECTION);
glLoadIdentity();
float width = 2 * ((double)screen_width/(double)screen_height);
glOrtho(-0.5 * width, 0.5*width, -1, 1, 1, 0);
glMatrixMode(GL_MODELVIEW);
glLoadIdentity();

glEnable(GL_DEPTH_TEST);
glEnable(GL_BLEND); // allows blending (transparency)
glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); // function for blending
glEnable(GL_DEPTH_TEST);
glShadeModel(GL_SMOOTH); // allows smooth shading (gradients)
glEnable(GL_ALPHA_TEST);
glAlphaFunc(GL_GREATER, 0.0);

//glLoadIdentity();
Camera.Render();

// FOR REFERENCE: Less Z = Closer to camera, Bigger Z = farther away
glColor4d(0.0, 1.0, 0.0, 1.0);
if(player != NULL)
{
glRasterPos3d(Camera.GetX() - 1.0, Camera.GetY() - 0.9, 0.01);
DrawString(listBase[5], "FPS: %g, PLAYER POSITION: %g, %g MESSAGES: %i", fps, player->Get_X(), player->Get_Y(), msthissec);
}
if(interactable_nearby)
{
glColor4d(0.2, 0.2, 1.0, 0.9);
glRasterPos3d(Camera.GetX()-0.05, Camera.GetY() - 0.85, 0.01);
DrawString(listBase[2], "Press [%c] key to interact", interaction_key);
}

AudioHandler();
SceneryHandler();
SpriteHandler();
PlayerHandler();
triggers.Update();
ScriptHandler();


glColor4d(1.0, 1.0, 0.0, 1.0);
//glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA);
glBlendFunc(GL_ONE, GL_ZERO);
glEnable(GL_TEXTURE_2D);
glBindTexture(GL_TEXTURE_2D, rttnum);

glBegin(GL_QUADS);
glTexCoord2f(0.0f, 0.0f); glVertex3f(-0.3,-0.3,0.01); // Bottom-Left Vertex
glTexCoord2f(1.0f, 0.0f); glVertex3f(0.3,-0.3,0.01); // Bottom-Right Vertex
glTexCoord2f(1.0f, 1.0f); glVertex3f(0.3,0.3,0.01); // Top-Right Vertex
glTexCoord2f(0.0f, 1.0f); glVertex3f(-0.3,0.3,0.01); // Top-Left Vertex
glEnd();
glDisable(GL_TEXTURE_2D);


glBindTexture(GL_TEXTURE_2D, 0);
[/CODE]

Once we get this working, I can take the method and adapt it to practical use for the effect I want, but for now I have it all in one function for ease of fiddling.
0

Share this post


Link to post
Share on other sites
Your z interval goes from 1.0f to 0.0f and you draw your quads at 0.0f. This may lead to them being culled by the far plane. Maybe you can draw them at 0.5f?
You will also need glDepthFunc(GEQUAL); because of the inverted depth interval.

BTW: Your comment
// FOR REFERENCE: Less Z = Closer to camera, Bigger Z = farther away

is not correct. The way you set up your projection matrix a z value of 1.0f is as close to the camera as possible, while a z value of 0.0f is as far away as possible (Ignoring for now, that for orthogonal projections this rather depends on the depth test, then on some actual "positioning").

I already asked this in a previous post, but are you sure that you want an inverted depth interval? This is so uncommon, that I have never seen this before.
1

Share this post


Link to post
Share on other sites
For the Gl ortho call for the fbo, I swapped the Z planes around and then set the depth func to LEQUAL. it now seems to draw to the texture such that I can see it. However, anything drawn at a z position greater than 0 is invisible, and when I draw the boxes such that they overlap even in the slightest, only the box drawn later is visible (with the one being drawn first becoming completely invisible). We're making progress! Though we're not quite there yet.

[edit] For now, I'm going to leave the main scene ortho the way it is, as it has always worked before. I wonder if the reason it works the way I expect is because of the camera view angle. Anyway, that's unimportant at the moment. Edited by medevilenemy
0

Share this post


Link to post
Share on other sites
That sounds good! With the normal z buffer setup you need to set glClearDepth(1.0f); before glClear-ing the depth buffer. Then it should work.

So for glOrtho(..., 0.0f, 1.0f): (I prefer this ^^)
glClearDepth(1.0f); // before glClear(... | GL_DEPTH_BUFFER_BIT)
glDepthFunc(GL_LEQUAL);

and for glOrtho(... 1.0f, 0.0f);
glClearDepth(0.0f); // before glClear(... | GL_DEPTH_BUFFER_BIT)
glDepthFunc(GL_GEQUAL);


[quote]I wonder if the reason it works the way I expect is because of the camera view angle.[/quote]

Yes, that is what I meant to hint in the previous post. If you look at a picture with perspective projection, you automatically assume the camera to be located at the focal point and if the depth test is the wrong way around, the image just feels wrong. For orthogonal projections however, where you don't have a view angle and thus no focal point, the camera could be located at either end of the view frustrum and the only thing that decides it for the human eye is the depth test.

You can of course stick with the inverted depth interval, but keep in mind that some aspects of the fixed function pipeline (for example fog) might not work as intended.
0

Share this post


Link to post
Share on other sites
Switching the depth clear had no effect, I still only see the box drawn second. FYI I have blend func within the context set to GL_ONE, GL_ZERO, but changing that has no apparant effect. I'll probably stick with the inverted depth interval for now, because I'd rather not have to flip around everything I'm rendering, but I'll consider doing so if it ever causes a problem.
0

Share this post


Link to post
Share on other sites
I've done some more tweaking, and I've managed to draw an opaque quad with a transparent window in its center. The reason one of the quads was clipping before seems to have been depth (I was drawing a couple of its vertices with 0.5 depth and for some reason it wasn't playing nice). The "window" is created by drawing a 0.0 alpha quad in the appropriate location with alpha func set to GL_ONE, GL_ZERO. The next thing I need is to be able to achieve the desired effect by subtracting the alpha of the "window" from the opaque quad (this way I could do overlapping lights and gradients). alpha func GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA doesn't seem to work for this. Any suggestions?
0

Share this post


Link to post
Share on other sites
After lots more tweaking and digging around, the blending proof of concept is now functional (after some fiddling and experimentation with the blend subract and minmax extensions). Thanks for your help @Ohforf sake[size=3][b].[/b][/size]
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0

  • Similar Content

    • By DaniDesu
      #include "MyEngine.h" int main() { MyEngine myEngine; myEngine.run(); return 0; } MyEngine.h
      #pragma once #include "MyWindow.h" #include "MyShaders.h" #include "MyShapes.h" class MyEngine { private: GLFWwindow * myWindowHandle; MyWindow * myWindow; public: MyEngine(); ~MyEngine(); void run(); }; MyEngine.cpp
      #include "MyEngine.h" MyEngine::MyEngine() { MyWindow myWindow(800, 600, "My Game Engine"); this->myWindow = &myWindow; myWindow.createWindow(); this->myWindowHandle = myWindow.getWindowHandle(); // Load all OpenGL function pointers for use gladLoadGLLoader((GLADloadproc)glfwGetProcAddress); } MyEngine::~MyEngine() { this->myWindow->destroyWindow(); } void MyEngine::run() { MyShaders myShaders("VertexShader.glsl", "FragmentShader.glsl"); MyShapes myShapes; GLuint vertexArrayObjectHandle; float coordinates[] = { 0.5f, 0.5f, 0.0f, 0.5f, -0.5f, 0.0f, -0.5f, 0.5f, 0.0f }; vertexArrayObjectHandle = myShapes.drawTriangle(coordinates); while (!glfwWindowShouldClose(this->myWindowHandle)) { glClearColor(0.5f, 0.5f, 0.5f, 1.0f); glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT); // Draw something glUseProgram(myShaders.getShaderProgram()); glBindVertexArray(vertexArrayObjectHandle); glDrawArrays(GL_TRIANGLES, 0, 3); glfwSwapBuffers(this->myWindowHandle); glfwPollEvents(); } } MyShaders.h
      #pragma once #include <glad\glad.h> #include <GLFW\glfw3.h> #include "MyFileHandler.h" class MyShaders { private: const char * vertexShaderFileName; const char * fragmentShaderFileName; const char * vertexShaderCode; const char * fragmentShaderCode; GLuint vertexShaderHandle; GLuint fragmentShaderHandle; GLuint shaderProgram; void compileShaders(); public: MyShaders(const char * vertexShaderFileName, const char * fragmentShaderFileName); ~MyShaders(); GLuint getShaderProgram(); const char * getVertexShaderCode(); const char * getFragmentShaderCode(); }; MyShaders.cpp
      #include "MyShaders.h" MyShaders::MyShaders(const char * vertexShaderFileName, const char * fragmentShaderFileName) { this->vertexShaderFileName = vertexShaderFileName; this->fragmentShaderFileName = fragmentShaderFileName; // Load shaders from files MyFileHandler myVertexShaderFileHandler(this->vertexShaderFileName); this->vertexShaderCode = myVertexShaderFileHandler.readFile(); MyFileHandler myFragmentShaderFileHandler(this->fragmentShaderFileName); this->fragmentShaderCode = myFragmentShaderFileHandler.readFile(); // Compile shaders this->compileShaders(); } MyShaders::~MyShaders() { } void MyShaders::compileShaders() { this->vertexShaderHandle = glCreateShader(GL_VERTEX_SHADER); this->fragmentShaderHandle = glCreateShader(GL_FRAGMENT_SHADER); glShaderSource(this->vertexShaderHandle, 1, &(this->vertexShaderCode), NULL); glShaderSource(this->fragmentShaderHandle, 1, &(this->fragmentShaderCode), NULL); glCompileShader(this->vertexShaderHandle); glCompileShader(this->fragmentShaderHandle); this->shaderProgram = glCreateProgram(); glAttachShader(this->shaderProgram, this->vertexShaderHandle); glAttachShader(this->shaderProgram, this->fragmentShaderHandle); glLinkProgram(this->shaderProgram); return; } GLuint MyShaders::getShaderProgram() { return this->shaderProgram; } const char * MyShaders::getVertexShaderCode() { return this->vertexShaderCode; } const char * MyShaders::getFragmentShaderCode() { return this->fragmentShaderCode; } MyWindow.h
      #pragma once #include <glad\glad.h> #include <GLFW\glfw3.h> class MyWindow { private: GLFWwindow * windowHandle; int windowWidth; int windowHeight; const char * windowTitle; public: MyWindow(int windowWidth, int windowHeight, const char * windowTitle); ~MyWindow(); GLFWwindow * getWindowHandle(); void createWindow(); void MyWindow::destroyWindow(); }; MyWindow.cpp
      #include "MyWindow.h" MyWindow::MyWindow(int windowWidth, int windowHeight, const char * windowTitle) { this->windowHandle = NULL; this->windowWidth = windowWidth; this->windowWidth = windowWidth; this->windowHeight = windowHeight; this->windowTitle = windowTitle; glfwInit(); } MyWindow::~MyWindow() { } GLFWwindow * MyWindow::getWindowHandle() { return this->windowHandle; } void MyWindow::createWindow() { // Use OpenGL 3.3 and GLSL 3.3 glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 3); glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 3); // Limit backwards compatibility glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_CORE_PROFILE); glfwWindowHint(GLFW_OPENGL_FORWARD_COMPAT, GL_TRUE); // Prevent resizing window glfwWindowHint(GLFW_RESIZABLE, GL_FALSE); // Create window this->windowHandle = glfwCreateWindow(this->windowWidth, this->windowHeight, this->windowTitle, NULL, NULL); glfwMakeContextCurrent(this->windowHandle); } void MyWindow::destroyWindow() { glfwTerminate(); } MyShapes.h
      #pragma once #include <glad\glad.h> #include <GLFW\glfw3.h> class MyShapes { public: MyShapes(); ~MyShapes(); GLuint & drawTriangle(float coordinates[]); }; MyShapes.cpp
      #include "MyShapes.h" MyShapes::MyShapes() { } MyShapes::~MyShapes() { } GLuint & MyShapes::drawTriangle(float coordinates[]) { GLuint vertexBufferObject{}; GLuint vertexArrayObject{}; // Create a VAO glGenVertexArrays(1, &vertexArrayObject); glBindVertexArray(vertexArrayObject); // Send vertices to the GPU glGenBuffers(1, &vertexBufferObject); glBindBuffer(GL_ARRAY_BUFFER, vertexBufferObject); glBufferData(GL_ARRAY_BUFFER, sizeof(coordinates), coordinates, GL_STATIC_DRAW); // Dertermine the interpretation of the array buffer glVertexAttribPointer(0, 3, GL_FLOAT, GL_FALSE, 3*sizeof(float), (void *)0); glEnableVertexAttribArray(0); // Unbind the buffers glBindBuffer(GL_ARRAY_BUFFER, 0); glBindVertexArray(0); return vertexArrayObject; } MyFileHandler.h
      #pragma once #include <cstdio> #include <cstdlib> class MyFileHandler { private: const char * fileName; unsigned long fileSize; void setFileSize(); public: MyFileHandler(const char * fileName); ~MyFileHandler(); unsigned long getFileSize(); const char * readFile(); }; MyFileHandler.cpp
      #include "MyFileHandler.h" MyFileHandler::MyFileHandler(const char * fileName) { this->fileName = fileName; this->setFileSize(); } MyFileHandler::~MyFileHandler() { } void MyFileHandler::setFileSize() { FILE * fileHandle = NULL; fopen_s(&fileHandle, this->fileName, "rb"); fseek(fileHandle, 0L, SEEK_END); this->fileSize = ftell(fileHandle); rewind(fileHandle); fclose(fileHandle); return; } unsigned long MyFileHandler::getFileSize() { return (this->fileSize); } const char * MyFileHandler::readFile() { char * buffer = (char *)malloc((this->fileSize)+1); FILE * fileHandle = NULL; fopen_s(&fileHandle, this->fileName, "rb"); fread(buffer, this->fileSize, sizeof(char), fileHandle); fclose(fileHandle); buffer[this->fileSize] = '\0'; return buffer; } VertexShader.glsl
      #version 330 core layout (location = 0) vec3 VertexPositions; void main() { gl_Position = vec4(VertexPositions, 1.0f); } FragmentShader.glsl
      #version 330 core out vec4 FragmentColor; void main() { FragmentColor = vec4(1.0f, 0.0f, 0.0f, 1.0f); } I am attempting to create a simple engine/graphics utility using some object-oriented paradigms. My first goal is to get some output from my engine, namely, a simple red triangle.
      For this goal, the MyShapes class will be responsible for defining shapes such as triangles, polygons etc. Currently, there is only a drawTriangle() method implemented, because I first wanted to see whether it works or not before attempting to code other shape drawing methods.
      The constructor of the MyEngine class creates a GLFW window (GLAD is also initialized here to load all OpenGL functionality), and the myEngine.run() method in Main.cpp is responsible for firing up the engine. In this run() method, the shaders get loaded from files via the help of my FileHandler class. The vertices for the triangle are processed by the myShapes.drawTriangle() method where a vertex array object, a vertex buffer object and vertrex attributes are set for this purpose.
      The while loop in the run() method should be outputting me the desired red triangle, but all I get is a grey window area. Why?
      Note: The shaders are compiling and linking without any errors.
      (Note: I am aware that this code is not using any good software engineering practices (e.g. exceptions, error handling). I am planning to implement them later, once I get the hang of OpenGL.)

       
    • By KarimIO
      EDIT: I thought this was restricted to Attribute-Created GL contexts, but it isn't, so I rewrote the post.
      Hey guys, whenever I call SwapBuffers(hDC), I get a crash, and I get a "Too many posts were made to a semaphore." from Windows as I call SwapBuffers. What could be the cause of this?
      Update: No crash occurs if I don't draw, just clear and swap.
      static PIXELFORMATDESCRIPTOR pfd = // pfd Tells Windows How We Want Things To Be { sizeof(PIXELFORMATDESCRIPTOR), // Size Of This Pixel Format Descriptor 1, // Version Number PFD_DRAW_TO_WINDOW | // Format Must Support Window PFD_SUPPORT_OPENGL | // Format Must Support OpenGL PFD_DOUBLEBUFFER, // Must Support Double Buffering PFD_TYPE_RGBA, // Request An RGBA Format 32, // Select Our Color Depth 0, 0, 0, 0, 0, 0, // Color Bits Ignored 0, // No Alpha Buffer 0, // Shift Bit Ignored 0, // No Accumulation Buffer 0, 0, 0, 0, // Accumulation Bits Ignored 24, // 24Bit Z-Buffer (Depth Buffer) 0, // No Stencil Buffer 0, // No Auxiliary Buffer PFD_MAIN_PLANE, // Main Drawing Layer 0, // Reserved 0, 0, 0 // Layer Masks Ignored }; if (!(hDC = GetDC(windowHandle))) return false; unsigned int PixelFormat; if (!(PixelFormat = ChoosePixelFormat(hDC, &pfd))) return false; if (!SetPixelFormat(hDC, PixelFormat, &pfd)) return false; hRC = wglCreateContext(hDC); if (!hRC) { std::cout << "wglCreateContext Failed!\n"; return false; } if (wglMakeCurrent(hDC, hRC) == NULL) { std::cout << "Make Context Current Second Failed!\n"; return false; } ... // OGL Buffer Initialization glClear(GL_DEPTH_BUFFER_BIT | GL_COLOR_BUFFER_BIT); glBindVertexArray(vao); glUseProgram(myprogram); glDrawElements(GL_TRIANGLES, indexCount, GL_UNSIGNED_SHORT, (void *)indexStart); SwapBuffers(GetDC(window_handle));  
    • By Tchom
      Hey devs!
       
      I've been working on a OpenGL ES 2.0 android engine and I have begun implementing some simple (point) lighting. I had something fairly simple working, so I tried to get fancy and added color-tinting light. And it works great... with only one or two lights. Any more than that, the application drops about 15 frames per light added (my ideal is at least 4 or 5). I know implementing lighting is expensive, I just didn't think it was that expensive. I'm fairly new to the world of OpenGL and GLSL, so there is a good chance I've written some crappy shader code. If anyone had any feedback or tips on how I can optimize this code, please let me know.
       
      Vertex Shader
      uniform mat4 u_MVPMatrix; uniform mat4 u_MVMatrix; attribute vec4 a_Position; attribute vec3 a_Normal; attribute vec2 a_TexCoordinate; varying vec3 v_Position; varying vec3 v_Normal; varying vec2 v_TexCoordinate; void main() { v_Position = vec3(u_MVMatrix * a_Position); v_TexCoordinate = a_TexCoordinate; v_Normal = vec3(u_MVMatrix * vec4(a_Normal, 0.0)); gl_Position = u_MVPMatrix * a_Position; } Fragment Shader
      precision mediump float; uniform vec4 u_LightPos["+numLights+"]; uniform vec4 u_LightColours["+numLights+"]; uniform float u_LightPower["+numLights+"]; uniform sampler2D u_Texture; varying vec3 v_Position; varying vec3 v_Normal; varying vec2 v_TexCoordinate; void main() { gl_FragColor = (texture2D(u_Texture, v_TexCoordinate)); float diffuse = 0.0; vec4 colourSum = vec4(1.0); for (int i = 0; i < "+numLights+"; i++) { vec3 toPointLight = vec3(u_LightPos[i]); float distance = length(toPointLight - v_Position); vec3 lightVector = normalize(toPointLight - v_Position); float diffuseDiff = 0.0; // The diffuse difference contributed from current light diffuseDiff = max(dot(v_Normal, lightVector), 0.0); diffuseDiff = diffuseDiff * (1.0 / (1.0 + ((1.0-u_LightPower[i])* distance * distance))); //Determine attenuatio diffuse += diffuseDiff; gl_FragColor.rgb *= vec3(1.0) / ((vec3(1.0) + ((vec3(1.0) - vec3(u_LightColours[i]))*diffuseDiff))); //The expensive part } diffuse += 0.1; //Add ambient light gl_FragColor.rgb *= diffuse; } Am I making any rookie mistakes? Or am I just being unrealistic about what I can do? Thanks in advance
    • By yahiko00
      Hi,
      Not sure to post at the right place, if not, please forgive me...
      For a game project I am working on, I would like to implement a 2D starfield as a background.
      I do not want to deal with static tiles, since I plan to slowly animate the starfield. So, I am trying to figure out how to generate a random starfield for the entire map.
      I feel that using a uniform distribution for the stars will not do the trick. Instead I would like something similar to the screenshot below, taken from the game Star Wars: Empire At War (all credits to Lucasfilm, Disney, and so on...).

      Is there someone who could have an idea of a distribution which could result in such a starfield?
      Any insight would be appreciated
    • By afraidofdark
      I have just noticed that, in quake 3 and half - life, dynamic models are effected from light map. For example in dark areas, gun that player holds seems darker. How did they achieve this effect ? I can use image based lighting techniques however (Like placing an environment probe and using it for reflections and ambient lighting), this tech wasn't used in games back then, so there must be a simpler method to do this.
      Here is a link that shows how modern engines does it. Indirect Lighting Cache It would be nice if you know a paper that explains this technique. Can I apply this to quake 3' s light map generator and bsp format ?
  • Popular Now