• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
EngineCoder

What's wrong with my tangent calculation?

2 posts in this topic

Some of my triangles render as if they're pointing away from the light. I can fix them by rotating their UV map upside down.
[CODE]
void Mesh::generateTangents()
{
for (size_t v = 0; v < m_vertices.size(); ++v)
{
m_vertices[ v ].tangent = Vec4( 0.0f, 0.0f, 0.0f, 0.0f );
}

m_tangents.resize ( m_indices.size() );
m_bitangents.resize( m_indices.size() );
bool degenerateFound = false;
for (size_t f = 0; f < m_indices.size(); ++f)
{
const Vec3& p1 = m_vertices[ m_indices[ f ].a ].position;
const Vec3& p2 = m_vertices[ m_indices[ f ].b ].position;
const Vec3& p3 = m_vertices[ m_indices[ f ].c ].position;

const TexCoord& uv1 = m_vertices[ m_indices[ f ].a ].texCoord;
const TexCoord& uv2 = m_vertices[ m_indices[ f ].b ].texCoord;
const TexCoord& uv3 = m_vertices[ m_indices[ f ].c ].texCoord;

const TexCoord deltaUV1 = uv2 - uv1;
const TexCoord deltaUV2 = uv3 - uv1;

const float area = (deltaUV1.u * deltaUV2.v - deltaUV1.v * deltaUV2.u);
Vec3 tangent;
Vec3 bitangent;
if (std::fabs( area ) > 0.00001f)
{
const Vec3 deltaP1 = p2 - p1;
const Vec3 deltaP2 = p3 - p1;
tangent = (deltaP1 * deltaUV2.v - deltaP2 * deltaUV1.v) / area;
bitangent = (deltaP1 * deltaUV2.u - deltaP2 * deltaUV1.u) / area;
}
else
{
degenerateFound = true;
}
Vec4 tangent4( tangent.x, tangent.y, tangent.z, 0.0f );
m_tangents[ f ] = tangent4;
m_bitangents[ f ] = bitangent;
}

if (degenerateFound)
{
std::cout << std::endl << "Warning: Degenerate UV map in " << name << ". Author needs to separate texture points in mesh's UV map." << std::endl;
}
m_vbitangents.resize( m_vertices.size() );
// For every vertex, check how many faces touches
// it and calculate the average of their tangents.
for (size_t vertInd = 0; vertInd < m_vertices.size(); ++vertInd)
{
Vec4 tangent( 0.0f, 0.0f, 0.0f, 0.0f );
Vec3 bitangent;
for (size_t faceInd = 0; faceInd < m_indices.size(); ++faceInd)
{
if (m_indices[ faceInd ].a == vertInd ||
m_indices[ faceInd ].b == vertInd ||
m_indices[ faceInd ].c == vertInd)
{
tangent += m_tangents [ faceInd ];
bitangent += m_bitangents[ faceInd ];
}
}
m_vertices[ vertInd ].tangent = tangent;
m_vbitangents[ vertInd ] = bitangent;
}

for (size_t v = 0; v < m_vertices.size(); ++v)
{
Vec4& tangent = m_vertices[ v ].tangent;
const Vec3& normal = m_vertices[ v ].normal;
const Vec4 normal4( normal.x, normal.y, normal.z, 0.0 );

// Gram-Schmidt orthonormalization.
tangent -= normal4 * normal4.dot( tangent );
tangent.normalize();
// Handedness. TBN must form a right-handed coordinate system,
// i.e. cross(n,t) must have the same orientation than b.
const Vec3 cp = normal.cross( Vec3( tangent.x, tangent.y, tangent.z ) );
tangent.w = cp.dot( m_vbitangents[v] ) > 0.0f ? 1.0f : -1.0f;
}
}
[/CODE]

I'm calculating my bitangents in the vertex shader and multiplying them with the handedness sign. I'm transforming my camera and point light position from world space to object space by multiplying them with inverse model matrix before transforming them to tangent space. If I visualize my TBN vectors, normals are pointing away from the surface and tangents and bitangents are orthogonal.
[CODE]

void main()
{
gl_Position = u_modelViewProjectionMatrix * vec4( a_position, 1.0 );
v_texCoord = a_texCoord;
vec3 bitangent = normalize( cross( a_normal, a_tangent.xyz ) ) * a_tangent.w; // .w is the handedness.

mat3 toTangentSpace = mat3(
a_tangent.x, bitangent.x, a_normal.x,
a_tangent.y, bitangent.y, a_normal.y,
a_tangent.z, bitangent.z, a_normal.z
);

vec3 mDirToLight = normalize( u_lightPosition.xyz - a_position ); // Light position is in object-space.
vec3 mDirToCamera = normalize( u_cameraPosition.xyz - a_position ); // Camera position is in object-space.

v_dirToLight = toTangentSpace * mDirToLight;
v_viewDir = toTangentSpace * mDirToCamera;
}
[/CODE] Edited by EngineCoder
0

Share this post


Link to post
Share on other sites
[CODE]
tangent = (deltaP1 * deltaUV2.v - deltaP2 * deltaUV1.v) / area;
bitangent = (deltaP1 * deltaUV2.u - deltaP2 * deltaUV1.u) / area;
[/CODE]
I don't think you can trust your UV coordinates to point in the right direction: [b]deltaUV1 [/b]and [b]deltaUV2 [/b]and [b]area[/b] can have "bad" signs and any sign change determines whether your normal (implicit from the choice of [b]tangent [/b]and [b]bitangent[/b]) points towards the front or the back.

Can you explain how do you relate UV coordinates to triangle facing?
0

Share this post


Link to post
Share on other sites
[quote name='LorenzoGatti' timestamp='1337068802' post='4940312']
[CODE]
tangent = (deltaP1 * deltaUV2.v - deltaP2 * deltaUV1.v) / area;
bitangent = (deltaP1 * deltaUV2.u - deltaP2 * deltaUV1.u) / area;
[/CODE]
I don't think you can trust your UV coordinates to point in the right direction: [b]deltaUV1 [/b]and [b]deltaUV2 [/b]and [b]area[/b] can have "bad" signs and any sign change determines whether your normal (implicit from the choice of [b]tangent [/b]and [b]bitangent[/b]) points towards the front or the back.

Can you explain how do you relate UV coordinates to triangle facing?
[/quote]
Most tutorials do it that way, like: [url="http://www.terathon.com/code/tangent.html"]http://www.terathon.com/code/tangent.html[/url]
1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0