Sign in to follow this  

Problem in C with NegaMax / Alpha-Beta (Connect 4)

This topic is 2059 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Well, ASM is not portable, so now it becomes important what platform and compiler you are using. This is probably the main reason why you shouldn't use ASM.

Why on Earth did you write parts of this program in assembly language?

Share this post


Link to post
Share on other sites
[img]http://public.gamedev.net//public/style_emoticons/default/biggrin.png[/img] i totally agree with you [img]http://public.gamedev.net//public/style_emoticons/default/tongue.png[/img]
But it's for a project and some parts need to be in Assembly.

I use __asm { } in my C code and it's compiled with VC 2008 so it should be OK for you.



Anyway i can replace ASM parts by C code if you prefer.

It's portable on Windows. Edited by Giustino

Share this post


Link to post
Share on other sites
[quote name='Giustino' timestamp='1338037887' post='4943462']I use __asm { } in my C code and it's compiled with VC 2008 so it should be OK for you.[/quote]
Except I am not familiar with Visual C, which means more work for me.

[quote]Anyway i can replace ASM parts by C code if you prefer.[/quote]
Yes, that shifts the work to you, which is the right place. It will also make your program portable, which is a good thing.

[quote]It's portable on Windows.[/quote]
That's a really strange notion of portability.

Share this post


Link to post
Share on other sites
[quote name='alvaro' timestamp='1338044057' post='4943492']
That's a really strange notion of portability.
[/quote]

Yep but it's because of the cursor positionning and color system (more simple to test it with windows.h on my windows OS and then make it portable).


I gave you the download link (private msg). Edited by Giustino

Share this post


Link to post
Share on other sites
Found it. When you are checking for 4 in a line at the beginning of IA_NegaMaxAlphaBeta, you are checking for `joueur', but you should be checking for `joueur^1', because you are checking if the opponent just won in the previous move.

Share this post


Link to post
Share on other sites
I first stripped the code of anything Windows related and any input or output. I then added a printf statement to show the move and score when a new best move is found at the root. I changed `main' to set up a position and then call the IA once. Once I did that, it took about 2 minutes to produce a position where it wouldn't do the right thing (it wouldn't find a victory after 32 31 30), then 1 minute to run the debugger and find that the victory detection wasn't working.

You should really learn how to use a debugger effectively.

I have many thoughts on the coding style, but I'll save them, since perhaps it's better for you to try to get things working in your own style for a while.

Share this post


Link to post
Share on other sites
You're right and finally i have to admit i didn't understand at 100% alphabeta, because i haven't been able to debug it myself.
I've had hard times with that, i'm almost ashamed.

But you were a great helper, thanks a lot alvaro, i really appreciate your help and your patience.
Keep going this way [img]http://public.gamedev.net//public/style_emoticons/default/smile.png[/img]


And by the way... Hope you're a Yankee fan like i am [img]http://public.gamedev.net//public/style_emoticons/default/biggrin.png[/img] Come on Yankees !

Share this post


Link to post
Share on other sites
So you have an Italian-sounding name, write your code in French and yet you are a Yankees fan? That's a strange combo. [img]http://public.gamedev.net//public/style_emoticons/default/smile.png[/img]

I never got into baseball and my wife is a Mets fan.

By the way, the other Belgian with an Italian name I know is Gian Carlo Pascutto, and he probably knows a lot more about alphabeta than I do! Edited by alvaro

Share this post


Link to post
Share on other sites
[quote name='alvaro' timestamp='1338127631' post='4943711']
So you have an Italian-sounding name, write your code in French and yet you are a Yankees fan? That's a strange combo. [img]http://public.gamedev.net//public/style_emoticons/default/smile.png[/img]
[/quote]

Yep, it is a strange mix. But a good one [img]http://public.gamedev.net//public/style_emoticons/default/laugh.png[/img]

[quote name='alvaro' timestamp='1338127631' post='4943711']
I never got into baseball and my wife is a Mets fan.
[/quote]

Damn... a Mets fan ! Condolences :D

[quote name='alvaro' timestamp='1338127631' post='4943711']
By the way, the other Belgian with an Italian name I know is Gian Carlo Pascutto, and he probably knows a lot more about alphabeta than I do!
[/quote]

I think so. But you are comfortable with alphabeta too, so don't worry [img]http://public.gamedev.net//public/style_emoticons/default/smile.png[/img]


Thanks again.

Share this post


Link to post
Share on other sites
Hello,

This might be a bit late, but i finally got my version af a Connect Four AI working (in C#). The link to my code is here:

[url="https://sourceforge.net/projects/connectfour85/"]https://sourceforge.net/projects/connectfour85/[/url]

Maybe this can help you out a little bit. My code is currently very simple, without any heuristics or alpha-beta pruning, but it seems to work correctly!

Share this post


Link to post
Share on other sites

This topic is 2059 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this