• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Jaap85

For loop doesn't work as expected

10 posts in this topic

Hello everybody,

I am currently trying to create a recursive function, but i found out that it isn't working and i dont really understand why this happens or how i could fix it.

I use the following function:

[CODE]

public AIMove RecursiveMiniMaxAI(int Depth, int MaxDepth, gamestate StateOfBoard, int Player)
{
//Some general code

if (Player == 2)
{
for (int i = 0; i < MoveList.Count; i++)
//foreach (int i in MoveList)
{
//Some code

//Recursive function
ReturnMove = RecursiveMiniMaxAI(Depth + 1, MaxDepth, AIStates[Depth + 1, j], 1);

//Some code

}
}
else
{
for (int k = 0; k < MoveList.Count; k++)
//foreach (int k in MoveList)
{
//Some code

//Recursive function call
ReturnMove = RecursiveMiniMaxAI(Depth + 1, MaxDepth, AIStates[Depth + 1, j], 2);

//Some code
}
}

//Some code

return ReturnMove;
}
[/CODE]

The problem is that both for loops only loop once. Even if i or k are 3,4 or 5, the loop runs once for i =0 and then doesn't loop again. This happens with both the for statement and the foreach statement.

If i remove the recursive function call, the loop runs just fine, so it must have something to do with that.

I would be really happy if anyone could point me in the right direction.

PS. i already posted this topic in the Artificial Intelligence forum, but since this doesn't really concern AI anymore I als posted it here.

For reference, here is the link to my older post with my complete code in it.

[url="http://www.gamedev.net/topic/622037-connect-four-ai/"]http://www.gamedev.net/topic/622037-connect-four-ai/[/url]
0

Share this post


Link to post
Share on other sites
Do you need to set the count to something BEFORE recursing, maybe it is getting stamped on somewhere else?

eg

public AIMove RecursiveMiniMaxAI(int Depth, int MaxDepth, gamestate StateOfBoard, int Player)
{
//Some general code

int MoveList_Count = MoveList.Count;

if (Player == 2)
{
for (int i = 0; i < MoveList_Count; i++)
//foreach (int i in MoveList)
{
//Some code

//Recursive function
ReturnMove = RecursiveMiniMaxAI(Depth + 1, MaxDepth, AIStates[Depth + 1, j], 1);

//Some code
0

Share this post


Link to post
Share on other sites
You have infinite recursivity.

[CODE]
void recursive(int player)
{
if( player == 2)
recursive(1); // will fall into the else case
else
recursive(2); // will fall into the if player == 2 case
// When are you stopping the recursivity ???
}

// should be something like this
void recursive(int player)
{
if(player == 1 )
recursive(2)
else
if( player == 2 )
recursive( -1); // next call will fall into the return case
else
return; // stop recursivity here !!!
}
[/CODE]
1

Share this post


Link to post
Share on other sites
[quote name='renega_666' timestamp='1337950759' post='4943215']
You have infinite recursivity.

[/quote]
With the code in its current snipped state, yes. I'm guessing the "maxdepth" value is supposed to be the stopping point, as each recursion is one 'level' deeper.

edit: yes, it does check for maxdepth, so no worries about infinite recursion. Edited by BCullis
0

Share this post


Link to post
Share on other sites
You need to show more code. How is recursion terminated? Where is MoveList updated? etc. Edited by jwezorek
0

Share this post


Link to post
Share on other sites
As other have said you have infinite recursion. You should check if Depth == MaxDpeth 1st, then return
[code]
public AIMove RecursiveMiniMaxAI(int Depth, int MaxDepth, gamestate StateOfBoard, int Player)
{
//Some general code
if (MaxDepth == Depth) {
return;
}
// Continue
...
}
[/code]

[quote name='Jaap85' timestamp='1337930826' post='4943172']
Hello everybody,

I am currently trying to create a recursive function, but i found out that it isn't working and i dont really understand why this happens or how i could fix it.

I use the following function:

[/quote] Edited by BeerNutts
0

Share this post


Link to post
Share on other sites
The full code is through the link: http://www.gamedev.net/topic/622037-connect-four-ai/

They do check for maxdepth first. It's not an infinite recursion issue.
0

Share this post


Link to post
Share on other sites
Thanks everyone for the responses. In my opinion, infinite recursion is not the issue, especially because the loop does finish (so it is not infinite). The problem occurs with the for statement. When this statement has run once, it doesn't start over again, although it does run over again when i remove the recursive function call. Still don't know how to solve this though :(
0

Share this post


Link to post
Share on other sites
[quote name='Jaap85' timestamp='1338048738' post='4943507']
Thanks everyone for the responses. In my opinion, infinite recursion is not the issue, especially because the loop does finish (so it is not infinite). The problem occurs with the for statement. When this statement has run once, it doesn't start over again, although it does run over again when i remove the recursive function call. Still don't know how to solve this though [img]http://public.gamedev.net//public/style_emoticons/default/sad.png[/img]
[/quote]
The recursive call must be clearing or removing items from MoveList. Can't tell from what you posted.Where is MoveList defined, anyway? -- Is it a global variable?
1

Share this post


Link to post
Share on other sites
All right, this is the point where i feel relieved but stupid :)

I finally got the code to work and also realised which mistakes i made:

1. When using the "foreach int k in MoveList" statement, i failed to adapt MoveList[k] to k, which makes sure the program goes in an endless loop.

2. I somehow overlooked the fact that the for loop was indeed connecting when debugging, I really don't understand it since i checked it a few dozen times before posting here, but in the end it appeared to work and since i didnt change anything in my code, i really must have overlooked it.

Anyhow, i got the code working and also fixed another mistake which caused the bad results to appear. [b]Thank you very much again for helping me learn![/b]


Now on to the next problem, which should be easier to solve. My girlfriend hates the fact that the stones in my Connect Four game just appear instead of falling down nicely, so i will try to fix that now :)
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0