• Advertisement
Sign in to follow this  

OpenGL [SharpDX] Textures are rendered blurry

This topic is 2038 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

I am sure that this topic has probably been posted a billion times, and I have looked around on Google(for quite a while) trying to find the answer to my problem. I am not the best with DirectX, or even OpenGL for that matter. For some reason, there's so many concepts to 3D programming that it overwhelms and confuses me.
I am using SharpDX(Direct3D9 to be exact) to render textures onto the screen. It's just a simple 2D game, so there's not a lot to it. I will show a few segments of my code and I will also list the things that I have tried and that have failed.

[CODE]
Public Sub InitD3D(ByVal form As Form, ByVal windowed As Boolean)
direct3D = New Direct3D()
Dim deviceSettings As PresentParameters
deviceSettings.BackBufferCount = 1
deviceSettings.BackBufferWidth = form.ClientSize.Width
deviceSettings.BackBufferHeight = form.ClientSize.Height
deviceSettings.DeviceWindowHandle = form.Handle
deviceSettings.Windowed = windowed
deviceSettings.PresentationInterval = PresentInterval.Immediate
deviceSettings.SwapEffect = SwapEffect.Discard
device = New Device(direct3D, 0, DeviceType.Hardware, form.Handle, CreateFlags.HardwareVertexProcessing, deviceSettings)
device.SetTransform(TransformState.Projection, Matrix.OrthoOffCenterLH(0.0!, Convert.ToSingle(form.ClientSize.Width), 0.0!, Convert.ToSingle(form.ClientSize.Height), 0.0!, 1.0!))
device.SetTransform(TransformState.View, Matrix.Identity)
device.SetTransform(TransformState.World, Matrix.Identity)
device.SetTransform(TransformState.Texture1, Matrix.Identity)
device.Viewport = New Viewport(0, 0, form.ClientSize.Width, form.ClientSize.Height)
device.SetRenderState(RenderState.Lighting, False)
additionalSwapChains = New Dictionary(Of String, SwapChain)()
End Sub
[/CODE]

[CODE]
Public Sub LoadTexture(ByVal fileName As String, ByRef texture As Texture)
Try
texture = texture.FromFile(device, fileName, Usage.None, Pool.Managed)
Catch ex As Exception
Throw New Exception("Failed to load texture from " + fileName)
End Try
End Sub
Public Sub Draw(ByVal texture As Texture, ByVal dx As Integer, ByVal dy As Integer, ByVal dw As Integer, ByVal dh As Integer, Optional ByVal sx As Integer = 0, Optional ByVal sy As Integer = 0)
device.VertexFormat = VertexFormat.Position Or VertexFormat.Texture1
device.SetTexture(0, texture)

Dim left As Single = Convert.ToSingle(dx) - 0.5!
Dim right As Single = Convert.ToSingle(dx + dw) - 0.5!
Dim bottom As Single = Convert.ToSingle(dy) - 0.5!
Dim top As Single = Convert.ToSingle(dy + dh) - 0.5!
Dim vertices(4) As CustomTextureVertex
vertices(0).position = New Vector3(left, top, 0.0!)
vertices(0).texPosition = New Vector2(0.0!, 0.0!)
vertices(1).position = New Vector3(right, top, 0.0!)
vertices(1).texPosition = New Vector2(1.0!, 0.0!)
vertices(2).position = New Vector3(left, bottom, 0.0!)
vertices(2).texPosition = New Vector2(0.0!, 1.0!)
vertices(3).position = New Vector3(right, bottom, 0.0!)
vertices(3).texPosition = New Vector2(1.0!, 1.0!)
device.DrawUserPrimitives(PrimitiveType.TriangleStrip, 2, vertices)
End Sub
[/CODE]

Things I have tried:
Adjusting offset by 0.5f, didn't work
The dw & dh is the actual height, not the Powers of Two width/height
The position & texPosition are perfectly fine
Setting minFilter,magFilter,mipFilter,addressU,addressV to different values and nothing(I also placed it in InitD3D and Draw functions in case it mattered)

The last thing I tried could also be my problem because I did not go through and try every possibility, I have just used settings from other help topics.

Thanks for any help, it's greatly appreciated.

Share this post


Link to post
Share on other sites
Advertisement
It's almost definitely half-pixel offset but your previous attempt at offsetting by 0.5f was somehow incorrect. If you still have it, could you post the code you tried?

Share this post


Link to post
Share on other sites
I left the half pixel offset peice of code in there. In the draw function it is where I define the left,top,bottom,right. I subtract 0.5! from them. I think I have found my main cause, the texture I am using is 128x192, and when I load it, it does load it on a 128x256 texture. Well, I made sure that it rendered 128x192, but I did not pay attention to the texture. It stretches the texture to fit the 128x256 which is causing the problem. I saved the texture to a file and I saw that it was stretched.
What could I do to turn off the stretching when loading the texture?
Also, what's a way to get the true width and height of the texture(non power of two dimensions)

I have got it figured out with a little bit of messing around. Now I just need to find a way to get the true width/height of the texture, but I'll google around for that. For future reference, the solution I made was this for loading my texture:
[CODE]
texture = texture.FromFile(device, fileName, 0, 0, 0, Usage.None, Format.Unknown, Pool.Managed, Filter.Point, Filter.Box, 0)
[/CODE]
I just changed the filter method basically. Edited by addy914

Share this post


Link to post
Share on other sites
Standard texture sizes are usually going to be power of two in size (because of hacks to speed up the math if I recall), so it will always end up 128x256. The only real exception to that is render targets, which can be any size (but I believe there's a lot of internal things going on to do that). When you're loading a regular texture, it will get the size and then find the next power of two size greater than that, and then scale accordingly using whatever settings you're specified, there isn't a way to actually disable this. If you want full control over the result, you'll need to either manually stretch the image (to handle scaling artifacts yourself), or make the image 128x256 and fill in the extra area with whatever. If you just fill in the rest, then when rendering you'll need to offset the texture coordinates to account for the difference, so instead of 0-1, it's 0-(192/256). Edited by xycsoscyx

Share this post


Link to post
Share on other sites
Well, not really. Most hardware these days is actually very capable of supporting non-power-of-two textures, so those old restrictions are largely dead. However, you need texture loading code that recognises this and loads the texture appropriately - not entirely certain how texture.FromFile is implemented but it should be doing so.

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Now

  • Advertisement
  • Similar Content

    • By Balma Alparisi
      i got error 1282 in my code.
      sf::ContextSettings settings; settings.majorVersion = 4; settings.minorVersion = 5; settings.attributeFlags = settings.Core; sf::Window window; window.create(sf::VideoMode(1600, 900), "Texture Unit Rectangle", sf::Style::Close, settings); window.setActive(true); window.setVerticalSyncEnabled(true); glewInit(); GLuint shaderProgram = createShaderProgram("FX/Rectangle.vss", "FX/Rectangle.fss"); float vertex[] = { -0.5f,0.5f,0.0f, 0.0f,0.0f, -0.5f,-0.5f,0.0f, 0.0f,1.0f, 0.5f,0.5f,0.0f, 1.0f,0.0f, 0.5,-0.5f,0.0f, 1.0f,1.0f, }; GLuint indices[] = { 0,1,2, 1,2,3, }; GLuint vao; glGenVertexArrays(1, &vao); glBindVertexArray(vao); GLuint vbo; glGenBuffers(1, &vbo); glBindBuffer(GL_ARRAY_BUFFER, vbo); glBufferData(GL_ARRAY_BUFFER, sizeof(vertex), vertex, GL_STATIC_DRAW); GLuint ebo; glGenBuffers(1, &ebo); glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, ebo); glBufferData(GL_ELEMENT_ARRAY_BUFFER, sizeof(indices), indices,GL_STATIC_DRAW); glVertexAttribPointer(0, 3, GL_FLOAT, false, sizeof(float) * 5, (void*)0); glEnableVertexAttribArray(0); glVertexAttribPointer(1, 2, GL_FLOAT, false, sizeof(float) * 5, (void*)(sizeof(float) * 3)); glEnableVertexAttribArray(1); GLuint texture[2]; glGenTextures(2, texture); glActiveTexture(GL_TEXTURE0); glBindTexture(GL_TEXTURE_2D, texture[0]); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); sf::Image* imageOne = new sf::Image; bool isImageOneLoaded = imageOne->loadFromFile("Texture/container.jpg"); if (isImageOneLoaded) { glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, imageOne->getSize().x, imageOne->getSize().y, 0, GL_RGBA, GL_UNSIGNED_BYTE, imageOne->getPixelsPtr()); glGenerateMipmap(GL_TEXTURE_2D); } delete imageOne; glActiveTexture(GL_TEXTURE1); glBindTexture(GL_TEXTURE_2D, texture[1]); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); sf::Image* imageTwo = new sf::Image; bool isImageTwoLoaded = imageTwo->loadFromFile("Texture/awesomeface.png"); if (isImageTwoLoaded) { glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, imageTwo->getSize().x, imageTwo->getSize().y, 0, GL_RGBA, GL_UNSIGNED_BYTE, imageTwo->getPixelsPtr()); glGenerateMipmap(GL_TEXTURE_2D); } delete imageTwo; glUniform1i(glGetUniformLocation(shaderProgram, "inTextureOne"), 0); glUniform1i(glGetUniformLocation(shaderProgram, "inTextureTwo"), 1); GLenum error = glGetError(); std::cout << error << std::endl; sf::Event event; bool isRunning = true; while (isRunning) { while (window.pollEvent(event)) { if (event.type == event.Closed) { isRunning = false; } } glClear(GL_COLOR_BUFFER_BIT); if (isImageOneLoaded && isImageTwoLoaded) { glActiveTexture(GL_TEXTURE0); glBindTexture(GL_TEXTURE_2D, texture[0]); glActiveTexture(GL_TEXTURE1); glBindTexture(GL_TEXTURE_2D, texture[1]); glUseProgram(shaderProgram); } glBindVertexArray(vao); glDrawElements(GL_TRIANGLES, 6, GL_UNSIGNED_INT, nullptr); glBindVertexArray(0); window.display(); } glDeleteVertexArrays(1, &vao); glDeleteBuffers(1, &vbo); glDeleteBuffers(1, &ebo); glDeleteProgram(shaderProgram); glDeleteTextures(2,texture); return 0; } and this is the vertex shader
      #version 450 core layout(location=0) in vec3 inPos; layout(location=1) in vec2 inTexCoord; out vec2 TexCoord; void main() { gl_Position=vec4(inPos,1.0); TexCoord=inTexCoord; } and the fragment shader
      #version 450 core in vec2 TexCoord; uniform sampler2D inTextureOne; uniform sampler2D inTextureTwo; out vec4 FragmentColor; void main() { FragmentColor=mix(texture(inTextureOne,TexCoord),texture(inTextureTwo,TexCoord),0.2); } I was expecting awesomeface.png on top of container.jpg

    • By khawk
      We've just released all of the source code for the NeHe OpenGL lessons on our Github page at https://github.com/gamedev-net/nehe-opengl. code - 43 total platforms, configurations, and languages are included.
      Now operated by GameDev.net, NeHe is located at http://nehe.gamedev.net where it has been a valuable resource for developers wanting to learn OpenGL and graphics programming.

      View full story
    • By TheChubu
      The Khronos™ Group, an open consortium of leading hardware and software companies, announces from the SIGGRAPH 2017 Conference the immediate public availability of the OpenGL® 4.6 specification. OpenGL 4.6 integrates the functionality of numerous ARB and EXT extensions created by Khronos members AMD, Intel, and NVIDIA into core, including the capability to ingest SPIR-V™ shaders.
      SPIR-V is a Khronos-defined standard intermediate language for parallel compute and graphics, which enables content creators to simplify their shader authoring and management pipelines while providing significant source shading language flexibility. OpenGL 4.6 adds support for ingesting SPIR-V shaders to the core specification, guaranteeing that SPIR-V shaders will be widely supported by OpenGL implementations.
      OpenGL 4.6 adds the functionality of these ARB extensions to OpenGL’s core specification:
      GL_ARB_gl_spirv and GL_ARB_spirv_extensions to standardize SPIR-V support for OpenGL GL_ARB_indirect_parameters and GL_ARB_shader_draw_parameters for reducing the CPU overhead associated with rendering batches of geometry GL_ARB_pipeline_statistics_query and GL_ARB_transform_feedback_overflow_querystandardize OpenGL support for features available in Direct3D GL_ARB_texture_filter_anisotropic (based on GL_EXT_texture_filter_anisotropic) brings previously IP encumbered functionality into OpenGL to improve the visual quality of textured scenes GL_ARB_polygon_offset_clamp (based on GL_EXT_polygon_offset_clamp) suppresses a common visual artifact known as a “light leak” associated with rendering shadows GL_ARB_shader_atomic_counter_ops and GL_ARB_shader_group_vote add shader intrinsics supported by all desktop vendors to improve functionality and performance GL_KHR_no_error reduces driver overhead by allowing the application to indicate that it expects error-free operation so errors need not be generated In addition to the above features being added to OpenGL 4.6, the following are being released as extensions:
      GL_KHR_parallel_shader_compile allows applications to launch multiple shader compile threads to improve shader compile throughput WGL_ARB_create_context_no_error and GXL_ARB_create_context_no_error allow no error contexts to be created with WGL or GLX that support the GL_KHR_no_error extension “I’m proud to announce OpenGL 4.6 as the most feature-rich version of OpenGL yet. We've brought together the most popular, widely-supported extensions into a new core specification to give OpenGL developers and end users an improved baseline feature set. This includes resolving previous intellectual property roadblocks to bringing anisotropic texture filtering and polygon offset clamping into the core specification to enable widespread implementation and usage,” said Piers Daniell, chair of the OpenGL Working Group at Khronos. “The OpenGL working group will continue to respond to market needs and work with GPU vendors to ensure OpenGL remains a viable and evolving graphics API for all its customers and users across many vital industries.“
      The OpenGL 4.6 specification can be found at https://khronos.org/registry/OpenGL/index_gl.php. The GLSL to SPIR-V compiler glslang has been updated with GLSL 4.60 support, and can be found at https://github.com/KhronosGroup/glslang.
      Sophisticated graphics applications will also benefit from a set of newly released extensions for both OpenGL and OpenGL ES to enable interoperability with Vulkan and Direct3D. These extensions are named:
      GL_EXT_memory_object GL_EXT_memory_object_fd GL_EXT_memory_object_win32 GL_EXT_semaphore GL_EXT_semaphore_fd GL_EXT_semaphore_win32 GL_EXT_win32_keyed_mutex They can be found at: https://khronos.org/registry/OpenGL/index_gl.php
      Industry Support for OpenGL 4.6
      “With OpenGL 4.6 our customers have an improved set of core features available on our full range of OpenGL 4.x capable GPUs. These features provide improved rendering quality, performance and functionality. As the graphics industry’s most popular API, we fully support OpenGL and will continue to work closely with the Khronos Group on the development of new OpenGL specifications and extensions for our customers. NVIDIA has released beta OpenGL 4.6 drivers today at https://developer.nvidia.com/opengl-driver so developers can use these new features right away,” said Bob Pette, vice president, Professional Graphics at NVIDIA.
      "OpenGL 4.6 will be the first OpenGL release where conformant open source implementations based on the Mesa project will be deliverable in a reasonable timeframe after release. The open sourcing of the OpenGL conformance test suite and ongoing work between Khronos and X.org will also allow for non-vendor led open source implementations to achieve conformance in the near future," said David Airlie, senior principal engineer at Red Hat, and developer on Mesa/X.org projects.

      View full story
    • By _OskaR
      Hi,
      I have an OpenGL application but without possibility to wite own shaders.
      I need to perform small VS modification - is possible to do it in an alternative way? Do we have apps or driver modifictions which will catch the shader sent to GPU and override it?
    • By xhcao
      Does sync be needed to read texture content after access texture image in compute shader?
      My simple code is as below,
      glUseProgram(program.get());
      glBindImageTexture(0, texture[0], 0, GL_FALSE, 3, GL_READ_ONLY, GL_R32UI);
      glBindImageTexture(1, texture[1], 0, GL_FALSE, 4, GL_WRITE_ONLY, GL_R32UI);
      glDispatchCompute(1, 1, 1);
      // Does sync be needed here?
      glUseProgram(0);
      glBindFramebuffer(GL_READ_FRAMEBUFFER, framebuffer);
      glFramebufferTexture2D(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
                                     GL_TEXTURE_CUBE_MAP_POSITIVE_X + face, texture[1], 0);
      glReadPixels(0, 0, kWidth, kHeight, GL_RED_INTEGER, GL_UNSIGNED_INT, outputValues);
       
      Compute shader is very simple, imageLoad content from texture[0], and imageStore content to texture[1]. Does need to sync after dispatchCompute?
  • Advertisement