Sign in to follow this  

OpenGL OpenGL - Lighting not working?

This topic is 2035 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Cutting straight to the chase, here is my Main.cpp:
void drawObjs(std::map<unsigned int, Drawable*> drawList) {
for (std::map<unsigned int, Drawable*>::iterator i = drawList.begin(); i != drawList.end(); ++i) {

void initGL() {
//Sets the clear depth; 0 = Nothing Cleared, 1 = Everything Cleared
//When we clear the screen, clear it to black
glClearColor(0.f, 0.f, 0.f, 0.f);

//Allows for Z-Buffering; z-buffering, in a nutshell, is a method of hiding
//Objects further away from objects closer to the camera: aka: hiding a close
//Object behind a far object

//Edit the Projection Matrix; The projection matrix defines the angle of view
//(more commonly known as field of view), the aspect ratio (SizeOfWindowWidth/
//SizeOfWindowHeight), and the Clipping Ranges (how far can the camera see in
//Any direction?)
//Reset the Projection matrix to a blank slate
gluPerspective(90.f, 1.f, 1.f, 500.f);

//Uncomment for Wireframe mode
//glPolygonMode( GL_FRONT_AND_BACK, GL_LINE );

// Lighting set up

// Set lighting intensity and color
GLfloat qaAmbientLight[] = {0.2, 0.2, 0.2, 1.0};
GLfloat qaDiffuseLight[] = {0.8, 0.8, 0.8, 1.0};
GLfloat qaSpecularLight[] = {1.0, 1.0, 1.0, 1.0};
glLightfv(GL_LIGHT0, GL_AMBIENT, qaAmbientLight);
glLightfv(GL_LIGHT0, GL_DIFFUSE, qaDiffuseLight);
glLightfv(GL_LIGHT0, GL_SPECULAR, qaSpecularLight);

// Set the light position
GLfloat qaLightPosition[] = {0.0, 0.0, 0.0, 1.0};
glLightfv(GL_LIGHT0, GL_POSITION, qaLightPosition);

GLfloat ambientColor[] = {0.2f, 0.2f, 0.2f, 1.0f}; //Color (0.2, 0.2, 0.2)
glLightModelfv(GL_LIGHT_MODEL_AMBIENT, ambientColor);


int main() {
// Create the main window
sf::Window App(sf::VideoMode(800, 600, 32), "Traditio", sf::Style::Close);
//Keyboard input class
sf::Keyboard keyboard;


//Contains all the Drawable classes
std::map<unsigned int, Drawable*> drawList;


//Make a new Cube
drawList[1] = new Cube;
drawList[0] = new Cube;

//Make the camera
Vector3 *camera = new Vector3(0.f, 0.f, -200.f);

//Set the cubes properties; reinterpret_cast<Cube*> makes it a cube rather
//Than a Drawable, so that it can be modified as if it were a Cube
//(Because drawList is declared to have its second parameter be a Drawable,
//not a cube)
Vector3 tmp = Vector3(50,50,50);
reinterpret_cast<Cube*>(drawList[1])->setColor(Color(0.f, 100.f/255.f, 1.f));
tmp = Vector3(3,4,0);
tmp = Vector3(0,45,0);
tmp = Vector3(30,60,50);
tmp = Vector3(2,6,0);

/*Positionable *last = 0;
for (std::map<int, Drawable*>::iterator i = drawList.begin(); i != drawList.end(); ++i) {
if (last != 0) {
Vector3 tmp = (reinterpret_cast<Positionable*>(i->second)->
std::cout << tmp << std::endl;
std::cout <<>getPosition()) << std::endl;
last = reinterpret_cast<Positionable*>(i->second);
last = 0;*/

//Make sure the Window is ready for drawing...

// Start game loop
while (App.isOpen()) {
// Process events
sf::Event event;
while (App.pollEvent(event)) {
switch (event.type) {
case sf::Event::Closed: //Window close request?
App.close(); //Kill the window
default: //Placeholder

//Camera controls (temporary)
if (keyboard.isKeyPressed(sf::Keyboard::W)) {
} else if (keyboard.isKeyPressed(sf::Keyboard::S)) {
} else if (keyboard.isKeyPressed(sf::Keyboard::A)) {
} else if (keyboard.isKeyPressed(sf::Keyboard:[img][/img])) {

//Clear the screen

//Define what matrix we are editing; in this case, the Model View Matrix
//Model View Matrix defines where the camera is and where the object is
//Reset the Model View matrix to a blank slate
//Set the camera matrix (aka the Model View matrix) to the these coordinates
glTranslatef(camera->x, camera->y, camera->z);

//Draw everything

//Vector3 tmp = *(drawList[0]->getRotation()) + 1;


//Place everything on the screen (aka "swap the buffers")

//No memory leaks!
for (std::map<unsigned int, Drawable*>::iterator i = drawList.begin(); i != drawList.end(); ++i) {
delete i->second;
i->second = 0;

delete camera;
camera = 0;

return 0;

I left out my #include's, because I don't think you really need to see them.

The main problem lies in the initGL function, where lighting is initialized. No errors exist, but it acts like the lighting isn't even enabled. And yes, the code is messy, and at places hackish, but I plan to improve on that later when I actually get the basis of stuff working. The camera is temporary too, by the way.

Tell me if you need to see any other classes or files.

Share this post

Link to post
Share on other sites
[quote name='mhagain' timestamp='1340314121' post='4951503']
Have you a glTexEnv of GL_MODULATE anywhere?

Excuse my idiotic questions, but what is that?

Share this post

Link to post
Share on other sites
glTexEnvi (GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE) is needed to blend light with objects. It [i]should[/i] be the default but it's worth putting it in anyway; it can go in your startup.

Share this post

Link to post
Share on other sites
Does the ambient do anything? I would post a picture of your scene. You have a positional light at 0,0,0 so I have to believe it is inside your model if you only have 1 model drawing right now.

Share this post

Link to post
Share on other sites

Share this post

Link to post
Share on other sites
Sign in to follow this  

  • Similar Content

    • By xhcao
      Does sync be needed to read texture content after access texture image in compute shader?
      My simple code is as below,
      glBindImageTexture(0, texture[0], 0, GL_FALSE, 3, GL_READ_ONLY, GL_R32UI);
      glBindImageTexture(1, texture[1], 0, GL_FALSE, 4, GL_WRITE_ONLY, GL_R32UI);
      glDispatchCompute(1, 1, 1);
      // Does sync be needed here?
      glBindFramebuffer(GL_READ_FRAMEBUFFER, framebuffer);
                                     GL_TEXTURE_CUBE_MAP_POSITIVE_X + face, texture[1], 0);
      glReadPixels(0, 0, kWidth, kHeight, GL_RED_INTEGER, GL_UNSIGNED_INT, outputValues);
      Compute shader is very simple, imageLoad content from texture[0], and imageStore content to texture[1]. Does need to sync after dispatchCompute?
    • By Jonathan2006
      My question: is it possible to transform multiple angular velocities so that they can be reinserted as one? My research is below:
      // This works quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); quat quaternion2 = GEMultiplyQuaternions(quaternion1, GEQuaternionFromAngleRadians(angleRadiansVector2)); quat quaternion3 = GEMultiplyQuaternions(quaternion2, GEQuaternionFromAngleRadians(angleRadiansVector3)); glMultMatrixf(GEMat4FromQuaternion(quaternion3).array); // The first two work fine but not the third. Why? quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); vec3 vector1 = GETransformQuaternionAndVector(quaternion1, angularVelocity1); quat quaternion2 = GEQuaternionFromAngleRadians(angleRadiansVector2); vec3 vector2 = GETransformQuaternionAndVector(quaternion2, angularVelocity2); // This doesn't work //quat quaternion3 = GEQuaternionFromAngleRadians(angleRadiansVector3); //vec3 vector3 = GETransformQuaternionAndVector(quaternion3, angularVelocity3); vec3 angleVelocity = GEAddVectors(vector1, vector2); // Does not work: vec3 angleVelocity = GEAddVectors(vector1, GEAddVectors(vector2, vector3)); static vec3 angleRadiansVector; vec3 angularAcceleration = GESetVector(0.0, 0.0, 0.0); // Sending it through one angular velocity later in my motion engine angleVelocity = GEAddVectors(angleVelocity, GEMultiplyVectorAndScalar(angularAcceleration, timeStep)); angleRadiansVector = GEAddVectors(angleRadiansVector, GEMultiplyVectorAndScalar(angleVelocity, timeStep)); glMultMatrixf(GEMat4FromEulerAngle(angleRadiansVector).array); Also how do I combine multiple angularAcceleration variables? Is there an easier way to transform the angular values?
    • By dpadam450
      I have this code below in both my vertex and fragment shader, however when I request glGetUniformLocation("Lights[0].diffuse") or "Lights[0].attenuation", it returns -1. It will only give me a valid uniform location if I actually use the diffuse/attenuation variables in the VERTEX shader. Because I use position in the vertex shader, it always returns a valid uniform location. I've read that I can share uniforms across both vertex and fragment, but I'm confused what this is even compiling to if this is the case.
      #define NUM_LIGHTS 2
      struct Light
          vec3 position;
          vec3 diffuse;
          float attenuation;
      uniform Light Lights[NUM_LIGHTS];
    • By pr033r
      I have a Bachelor project on topic "Implenet 3D Boid's algorithm in OpenGL". All OpenGL issues works fine for me, all rendering etc. But when I started implement the boid's algorithm it was getting worse and worse. I read article ( inspirate from another code (here: but it still doesn't work like in tutorials and videos. For example the main problem: when I apply Cohesion (one of three main laws of boids) it makes some "cycling knot". Second, when some flock touch to another it scary change the coordination or respawn in origin (x: 0, y:0. z:0). Just some streng things. 
      I followed many tutorials, change a try everything but it isn't so smooth, without lags like in another videos. I really need your help. 
      My code (optimalizing branch):
      Exe file (if you want to look) and models folder (for those who will download the sources):
      Thanks for any help...

    • By Andrija
      I am currently trying to implement shadow mapping into my project , but although i can render my depth map to the screen and it looks okay , when i sample it with shadowCoords there is no shadow.
      Here is my light space matrix calculation
      mat4x4 lightViewMatrix; vec3 sun_pos = {SUN_OFFSET * the_sun->direction[0], SUN_OFFSET * the_sun->direction[1], SUN_OFFSET * the_sun->direction[2]}; mat4x4_look_at(lightViewMatrix,sun_pos,player->pos,up); mat4x4_mul(lightSpaceMatrix,lightProjMatrix,lightViewMatrix); I will tweak the values for the size and frustum of the shadow map, but for now i just want to draw shadows around the player position
      the_sun->direction is a normalized vector so i multiply it by a constant to get the position.
      player->pos is the camera position in world space
      the light projection matrix is calculated like this:
      mat4x4_ortho(lightProjMatrix,-SHADOW_FAR,SHADOW_FAR,-SHADOW_FAR,SHADOW_FAR,NEAR,SHADOW_FAR); Shadow vertex shader:
      uniform mat4 light_space_matrix; void main() { gl_Position = light_space_matrix * transfMatrix * vec4(position, 1.0f); } Shadow fragment shader:
      out float fragDepth; void main() { fragDepth = gl_FragCoord.z; } I am using deferred rendering so i have all my world positions in the g_positions buffer
      My shadow calculation in the deferred fragment shader:
      float get_shadow_fac(vec4 light_space_pos) { vec3 shadow_coords = / light_space_pos.w; shadow_coords = shadow_coords * 0.5 + 0.5; float closest_depth = texture(shadow_map, shadow_coords.xy).r; float current_depth = shadow_coords.z; float shadow_fac = 1.0; if(closest_depth < current_depth) shadow_fac = 0.5; return shadow_fac; } I call the function like this:
      get_shadow_fac(light_space_matrix * vec4(position,1.0)); Where position is the value i got from sampling the g_position buffer
      Here is my depth texture (i know it will produce low quality shadows but i just want to get it working for now):
      sorry because of the compression , the black smudges are trees ...
      EDIT: Depth texture attachment:
  • Popular Now