Sign in to follow this  

OpenGL OpenGL - Lighting not working?

Recommended Posts

Jode    109
Cutting straight to the chase, here is my Main.cpp:
void drawObjs(std::map<unsigned int, Drawable*> drawList) {
for (std::map<unsigned int, Drawable*>::iterator i = drawList.begin(); i != drawList.end(); ++i) {

void initGL() {
//Sets the clear depth; 0 = Nothing Cleared, 1 = Everything Cleared
//When we clear the screen, clear it to black
glClearColor(0.f, 0.f, 0.f, 0.f);

//Allows for Z-Buffering; z-buffering, in a nutshell, is a method of hiding
//Objects further away from objects closer to the camera: aka: hiding a close
//Object behind a far object

//Edit the Projection Matrix; The projection matrix defines the angle of view
//(more commonly known as field of view), the aspect ratio (SizeOfWindowWidth/
//SizeOfWindowHeight), and the Clipping Ranges (how far can the camera see in
//Any direction?)
//Reset the Projection matrix to a blank slate
gluPerspective(90.f, 1.f, 1.f, 500.f);

//Uncomment for Wireframe mode
//glPolygonMode( GL_FRONT_AND_BACK, GL_LINE );

// Lighting set up

// Set lighting intensity and color
GLfloat qaAmbientLight[] = {0.2, 0.2, 0.2, 1.0};
GLfloat qaDiffuseLight[] = {0.8, 0.8, 0.8, 1.0};
GLfloat qaSpecularLight[] = {1.0, 1.0, 1.0, 1.0};
glLightfv(GL_LIGHT0, GL_AMBIENT, qaAmbientLight);
glLightfv(GL_LIGHT0, GL_DIFFUSE, qaDiffuseLight);
glLightfv(GL_LIGHT0, GL_SPECULAR, qaSpecularLight);

// Set the light position
GLfloat qaLightPosition[] = {0.0, 0.0, 0.0, 1.0};
glLightfv(GL_LIGHT0, GL_POSITION, qaLightPosition);

GLfloat ambientColor[] = {0.2f, 0.2f, 0.2f, 1.0f}; //Color (0.2, 0.2, 0.2)
glLightModelfv(GL_LIGHT_MODEL_AMBIENT, ambientColor);


int main() {
// Create the main window
sf::Window App(sf::VideoMode(800, 600, 32), "Traditio", sf::Style::Close);
//Keyboard input class
sf::Keyboard keyboard;


//Contains all the Drawable classes
std::map<unsigned int, Drawable*> drawList;


//Make a new Cube
drawList[1] = new Cube;
drawList[0] = new Cube;

//Make the camera
Vector3 *camera = new Vector3(0.f, 0.f, -200.f);

//Set the cubes properties; reinterpret_cast<Cube*> makes it a cube rather
//Than a Drawable, so that it can be modified as if it were a Cube
//(Because drawList is declared to have its second parameter be a Drawable,
//not a cube)
Vector3 tmp = Vector3(50,50,50);
reinterpret_cast<Cube*>(drawList[1])->setColor(Color(0.f, 100.f/255.f, 1.f));
tmp = Vector3(3,4,0);
tmp = Vector3(0,45,0);
tmp = Vector3(30,60,50);
tmp = Vector3(2,6,0);

/*Positionable *last = 0;
for (std::map<int, Drawable*>::iterator i = drawList.begin(); i != drawList.end(); ++i) {
if (last != 0) {
Vector3 tmp = (reinterpret_cast<Positionable*>(i->second)->
std::cout << tmp << std::endl;
std::cout <<>getPosition()) << std::endl;
last = reinterpret_cast<Positionable*>(i->second);
last = 0;*/

//Make sure the Window is ready for drawing...

// Start game loop
while (App.isOpen()) {
// Process events
sf::Event event;
while (App.pollEvent(event)) {
switch (event.type) {
case sf::Event::Closed: //Window close request?
App.close(); //Kill the window
default: //Placeholder

//Camera controls (temporary)
if (keyboard.isKeyPressed(sf::Keyboard::W)) {
} else if (keyboard.isKeyPressed(sf::Keyboard::S)) {
} else if (keyboard.isKeyPressed(sf::Keyboard::A)) {
} else if (keyboard.isKeyPressed(sf::Keyboard:[img][/img])) {

//Clear the screen

//Define what matrix we are editing; in this case, the Model View Matrix
//Model View Matrix defines where the camera is and where the object is
//Reset the Model View matrix to a blank slate
//Set the camera matrix (aka the Model View matrix) to the these coordinates
glTranslatef(camera->x, camera->y, camera->z);

//Draw everything

//Vector3 tmp = *(drawList[0]->getRotation()) + 1;


//Place everything on the screen (aka "swap the buffers")

//No memory leaks!
for (std::map<unsigned int, Drawable*>::iterator i = drawList.begin(); i != drawList.end(); ++i) {
delete i->second;
i->second = 0;

delete camera;
camera = 0;

return 0;

I left out my #include's, because I don't think you really need to see them.

The main problem lies in the initGL function, where lighting is initialized. No errors exist, but it acts like the lighting isn't even enabled. And yes, the code is messy, and at places hackish, but I plan to improve on that later when I actually get the basis of stuff working. The camera is temporary too, by the way.

Tell me if you need to see any other classes or files.

Share this post

Link to post
Share on other sites
Jode    109
[quote name='mhagain' timestamp='1340314121' post='4951503']
Have you a glTexEnv of GL_MODULATE anywhere?

Excuse my idiotic questions, but what is that?

Share this post

Link to post
Share on other sites
mhagain    13430
glTexEnvi (GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE) is needed to blend light with objects. It [i]should[/i] be the default but it's worth putting it in anyway; it can go in your startup.

Share this post

Link to post
Share on other sites
dpadam450    2357
Does the ambient do anything? I would post a picture of your scene. You have a positional light at 0,0,0 so I have to believe it is inside your model if you only have 1 model drawing right now.

Share this post

Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Similar Content

    • By Zaphyk
      I am developing my engine using the OpenGL 3.3 compatibility profile. It runs as expected on my NVIDIA card and on my Intel Card however when I tried it on an AMD setup it ran 3 times worse than on the other setups. Could this be a AMD driver thing or is this probably a problem with my OGL code? Could a different code standard create such bad performance?
    • By Kjell Andersson
      I'm trying to get some legacy OpenGL code to run with a shader pipeline,
      The legacy code uses glVertexPointer(), glColorPointer(), glNormalPointer() and glTexCoordPointer() to supply the vertex information.
      I know that it should be using setVertexAttribPointer() etc to clearly define the layout but that is not an option right now since the legacy code can't be modified to that extent.
      I've got a version 330 vertex shader to somewhat work:
      #version 330 uniform mat4 osg_ModelViewProjectionMatrix; uniform mat4 osg_ModelViewMatrix; layout(location = 0) in vec4 Vertex; layout(location = 2) in vec4 Normal; // Velocity layout(location = 3) in vec3 TexCoord; // TODO: is this the right layout location? out VertexData { vec4 color; vec3 velocity; float size; } VertexOut; void main(void) { vec4 p0 = Vertex; vec4 p1 = Vertex + vec4(Normal.x, Normal.y, Normal.z, 0.0f); vec3 velocity = (osg_ModelViewProjectionMatrix * p1 - osg_ModelViewProjectionMatrix * p0).xyz; VertexOut.velocity = velocity; VertexOut.size = TexCoord.y; gl_Position = osg_ModelViewMatrix * Vertex; } What works is the Vertex and Normal information that the legacy C++ OpenGL code seem to provide in layout location 0 and 2. This is fine.
      What I'm not getting to work is the TexCoord information that is supplied by a glTexCoordPointer() call in C++.
      What layout location is the old standard pipeline using for glTexCoordPointer()? Or is this undefined?
      Side note: I'm trying to get an OpenSceneGraph 3.4.0 particle system to use custom vertex, geometry and fragment shaders for rendering the particles.
    • By markshaw001
      Hi i am new to this forum  i wanted to ask for help from all of you i want to generate real time terrain using a 32 bit heightmap i am good at c++ and have started learning Opengl as i am very interested in making landscapes in opengl i have looked around the internet for help about this topic but i am not getting the hang of the concepts and what they are doing can some here suggests me some good resources for making terrain engine please for example like tutorials,books etc so that i can understand the whole concept of terrain generation.
    • By KarimIO
      Hey guys. I'm trying to get my application to work on my Nvidia GTX 970 desktop. It currently works on my Intel HD 3000 laptop, but on the desktop, every bind textures specifically from framebuffers, I get half a second of lag. This is done 4 times as I have three RGBA textures and one depth 32F buffer. I tried to use debugging software for the first time - RenderDoc only shows SwapBuffers() and no OGL calls, while Nvidia Nsight crashes upon execution, so neither are helpful. Without binding it runs regularly. This does not happen with non-framebuffer binds.
      GLFramebuffer::GLFramebuffer(FramebufferCreateInfo createInfo) { glGenFramebuffers(1, &fbo); glBindFramebuffer(GL_FRAMEBUFFER, fbo); textures = new GLuint[createInfo.numColorTargets]; glGenTextures(createInfo.numColorTargets, textures); GLenum *DrawBuffers = new GLenum[createInfo.numColorTargets]; for (uint32_t i = 0; i < createInfo.numColorTargets; i++) { glBindTexture(GL_TEXTURE_2D, textures[i]); GLint internalFormat; GLenum format; TranslateFormats(createInfo.colorFormats[i], format, internalFormat); // returns GL_RGBA and GL_RGBA glTexImage2D(GL_TEXTURE_2D, 0, internalFormat, createInfo.width, createInfo.height, 0, format, GL_FLOAT, 0); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); DrawBuffers[i] = GL_COLOR_ATTACHMENT0 + i; glBindTexture(GL_TEXTURE_2D, 0); glFramebufferTexture(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0 + i, textures[i], 0); } if (createInfo.depthFormat != FORMAT_DEPTH_NONE) { GLenum depthFormat; switch (createInfo.depthFormat) { case FORMAT_DEPTH_16: depthFormat = GL_DEPTH_COMPONENT16; break; case FORMAT_DEPTH_24: depthFormat = GL_DEPTH_COMPONENT24; break; case FORMAT_DEPTH_32: depthFormat = GL_DEPTH_COMPONENT32; break; case FORMAT_DEPTH_24_STENCIL_8: depthFormat = GL_DEPTH24_STENCIL8; break; case FORMAT_DEPTH_32_STENCIL_8: depthFormat = GL_DEPTH32F_STENCIL8; break; } glGenTextures(1, &depthrenderbuffer); glBindTexture(GL_TEXTURE_2D, depthrenderbuffer); glTexImage2D(GL_TEXTURE_2D, 0, depthFormat, createInfo.width, createInfo.height, 0, GL_DEPTH_COMPONENT, GL_FLOAT, 0); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); glBindTexture(GL_TEXTURE_2D, 0); glFramebufferTexture(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, depthrenderbuffer, 0); } if (createInfo.numColorTargets > 0) glDrawBuffers(createInfo.numColorTargets, DrawBuffers); else glDrawBuffer(GL_NONE); if (glCheckFramebufferStatus(GL_FRAMEBUFFER) != GL_FRAMEBUFFER_COMPLETE) std::cout << "Framebuffer Incomplete\n"; glBindFramebuffer(GL_FRAMEBUFFER, 0); width = createInfo.width; height = createInfo.height; } // ... // FBO Creation FramebufferCreateInfo gbufferCI; gbufferCI.colorFormats =; gbufferCI.depthFormat = FORMAT_DEPTH_32; gbufferCI.numColorTargets = gbufferCFs.size(); gbufferCI.width = engine.settings.resolutionX; gbufferCI.height = engine.settings.resolutionY; gbufferCI.renderPass = nullptr; gbuffer = graphicsWrapper->CreateFramebuffer(gbufferCI); // Bind glBindFramebuffer(GL_DRAW_FRAMEBUFFER, fbo); // Draw here... // Bind to textures glActiveTexture(GL_TEXTURE0); glBindTexture(GL_TEXTURE_2D, textures[0]); glActiveTexture(GL_TEXTURE1); glBindTexture(GL_TEXTURE_2D, textures[1]); glActiveTexture(GL_TEXTURE2); glBindTexture(GL_TEXTURE_2D, textures[2]); glActiveTexture(GL_TEXTURE3); glBindTexture(GL_TEXTURE_2D, depthrenderbuffer); Here is an extract of my code. I can't think of anything else to include. I've really been butting my head into a wall trying to think of a reason but I can think of none and all my research yields nothing. Thanks in advance!
    • By Adrianensis
      Hi everyone, I've shared my 2D Game Engine source code. It's the result of 4 years working on it (and I still continue improving features ) and I want to share with the community. You can see some videos on youtube and some demo gifs on my twitter account.
      This Engine has been developed as End-of-Degree Project and it is coded in Javascript, WebGL and GLSL. The engine is written from scratch.
      This is not a professional engine but it's for learning purposes, so anyone can review the code an learn basis about graphics, physics or game engine architecture. Source code on this GitHub repository.
      I'm available for a good conversation about Game Engine / Graphics Programming
  • Popular Now