Sign in to follow this  

OpenGL 100% dumb questions about opengl lighting

This topic is 2027 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Well, i was setting up an hardcoded cornell box scene with opengl because i want to learn glsl and hopefully write a fragment shader path tracer

so i copied [url="http://www.graphics.cornell.edu/online/box/data.html"]these[/url] data ([url="http://pastebin.com/w3gmZf8x"]here[/url]'s the code), but i had a result i didn't expect, and i don't understand

[img]http://img213.imageshack.us/img213/4859/cb1y.png[/img]

There's no reason for having an enlighted left wall and such a dark right wall.. also that floor shouldnt be so dark if the bottom of the left wall is still enlighted

But if i invert floor and right wall normal direction (right wall normal = (-1, 0, 0) and floor normal = (0, -1, 0)) i get something similiar to what i expected

[img]http://img3.imageshack.us/img3/8167/cb2v.png[/img]

i feel like i'm missing something :/ Edited by tuccio`

Share this post


Link to post
Share on other sites
The light parameters are 4-dimensional vectors, not 3-dimensional vectors as in your code. OpenGL is currently reading the fourth component from outside the corresponding arrays.

Share this post


Link to post
Share on other sites
[quote name='Brother Bob' timestamp='1340976491' post='4953950']
The light parameters are 4-dimensional vectors, not 3-dimensional vectors as in your code. OpenGL is currently reading the fourth component from outside the corresponding arrays.
[/quote]oh, thank you

that helped, and now it works fine if i set position's w component to 1 (so that the light propagates in all directions), as you can see:

[img]http://img88.imageshack.us/img88/783/cb3p.png[/img]

but if i put w to 0 to get a directional light, this is what i get:

[img]http://img151.imageshack.us/img151/431/cb4.png[/img]

the code now looks like [url="http://pastebin.com/i4XxVjxW"]this[/url]

i guess i'm still missing something :/ Edited by tuccio`

Share this post


Link to post
Share on other sites
What do you think is wrong with the directional light? If the light is coming from the upper left in the image, then the bottom and right faces are lit since they face the light, and the right and top faces are not lit since they are not facing the light.

I haven't looked much into the exact details of where the light is pointing, where the view point is facing, and which wall is where though, so I don't know for sure if the light really is supposed to come from the upper left. If the incorrect faces are lit, then make sure that the normals are in fact correct, and that you are viewing from the correct place.

Share this post


Link to post
Share on other sites
[quote name='Brother Bob' timestamp='1340979365' post='4953961']
What do you think is wrong with the directional light? If the light is coming from the upper left in the image, then the bottom and right faces are lit since they face the light, and the right and top faces are not lit since they are not facing the light.

I haven't looked much into the exact details of where the light is pointing, where the view point is facing, and which wall is where though, so I don't know for sure if the light really is supposed to come from the upper left. If the incorrect faces are lit, then make sure that the normals are in fact correct, and that you are viewing from the correct place.
[/quote]the light is in the middle (sort of) of the room, actually closer to the ceiling than the floor, and the direction points towards the floor

also, changing the direction of the light and the spot cutoff doesnt change the result, and this is weird too

Share this post


Link to post
Share on other sites
You have a directional light, not a positional one. Spotlight settings only work for positional lights. Set the w-component of the position to 1 instead.

Also, don't expect very good results. Lighting is calculated per vertex so you need to define a much higher resolution cube to have some sensible results.

Share this post


Link to post
Share on other sites
[quote name='Brother Bob' timestamp='1340990970' post='4954010']
You have a directional light, not a positional one. Spotlight settings only work for positional lights. Set the w-component of the position to 1 instead.

Also, don't expect very good results. Lighting is calculated per vertex so you need to define a much higher resolution cube to have some sensible results.
[/quote]yup i think i understand

and yes, i didn't expect great results, i'm using a low tesselated cube because, as i said, i want to learn glsl and use fragment shaders to compute direct and indirect lighting

thank you again

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Similar Content

    • By xhcao
      Does sync be needed to read texture content after access texture image in compute shader?
      My simple code is as below,
      glUseProgram(program.get());
      glBindImageTexture(0, texture[0], 0, GL_FALSE, 3, GL_READ_ONLY, GL_R32UI);
      glBindImageTexture(1, texture[1], 0, GL_FALSE, 4, GL_WRITE_ONLY, GL_R32UI);
      glDispatchCompute(1, 1, 1);
      // Does sync be needed here?
      glUseProgram(0);
      glBindFramebuffer(GL_READ_FRAMEBUFFER, framebuffer);
      glFramebufferTexture2D(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
                                     GL_TEXTURE_CUBE_MAP_POSITIVE_X + face, texture[1], 0);
      glReadPixels(0, 0, kWidth, kHeight, GL_RED_INTEGER, GL_UNSIGNED_INT, outputValues);
       
      Compute shader is very simple, imageLoad content from texture[0], and imageStore content to texture[1]. Does need to sync after dispatchCompute?
    • By Jonathan2006
      My question: is it possible to transform multiple angular velocities so that they can be reinserted as one? My research is below:
      // This works quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); quat quaternion2 = GEMultiplyQuaternions(quaternion1, GEQuaternionFromAngleRadians(angleRadiansVector2)); quat quaternion3 = GEMultiplyQuaternions(quaternion2, GEQuaternionFromAngleRadians(angleRadiansVector3)); glMultMatrixf(GEMat4FromQuaternion(quaternion3).array); // The first two work fine but not the third. Why? quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); vec3 vector1 = GETransformQuaternionAndVector(quaternion1, angularVelocity1); quat quaternion2 = GEQuaternionFromAngleRadians(angleRadiansVector2); vec3 vector2 = GETransformQuaternionAndVector(quaternion2, angularVelocity2); // This doesn't work //quat quaternion3 = GEQuaternionFromAngleRadians(angleRadiansVector3); //vec3 vector3 = GETransformQuaternionAndVector(quaternion3, angularVelocity3); vec3 angleVelocity = GEAddVectors(vector1, vector2); // Does not work: vec3 angleVelocity = GEAddVectors(vector1, GEAddVectors(vector2, vector3)); static vec3 angleRadiansVector; vec3 angularAcceleration = GESetVector(0.0, 0.0, 0.0); // Sending it through one angular velocity later in my motion engine angleVelocity = GEAddVectors(angleVelocity, GEMultiplyVectorAndScalar(angularAcceleration, timeStep)); angleRadiansVector = GEAddVectors(angleRadiansVector, GEMultiplyVectorAndScalar(angleVelocity, timeStep)); glMultMatrixf(GEMat4FromEulerAngle(angleRadiansVector).array); Also how do I combine multiple angularAcceleration variables? Is there an easier way to transform the angular values?
    • By dpadam450
      I have this code below in both my vertex and fragment shader, however when I request glGetUniformLocation("Lights[0].diffuse") or "Lights[0].attenuation", it returns -1. It will only give me a valid uniform location if I actually use the diffuse/attenuation variables in the VERTEX shader. Because I use position in the vertex shader, it always returns a valid uniform location. I've read that I can share uniforms across both vertex and fragment, but I'm confused what this is even compiling to if this is the case.
       
      #define NUM_LIGHTS 2
      struct Light
      {
          vec3 position;
          vec3 diffuse;
          float attenuation;
      };
      uniform Light Lights[NUM_LIGHTS];
       
       
    • By pr033r
      Hello,
      I have a Bachelor project on topic "Implenet 3D Boid's algorithm in OpenGL". All OpenGL issues works fine for me, all rendering etc. But when I started implement the boid's algorithm it was getting worse and worse. I read article (http://natureofcode.com/book/chapter-6-autonomous-agents/) inspirate from another code (here: https://github.com/jyanar/Boids/tree/master/src) but it still doesn't work like in tutorials and videos. For example the main problem: when I apply Cohesion (one of three main laws of boids) it makes some "cycling knot". Second, when some flock touch to another it scary change the coordination or respawn in origin (x: 0, y:0. z:0). Just some streng things. 
      I followed many tutorials, change a try everything but it isn't so smooth, without lags like in another videos. I really need your help. 
      My code (optimalizing branch): https://github.com/pr033r/BachelorProject/tree/Optimalizing
      Exe file (if you want to look) and models folder (for those who will download the sources):
      http://leteckaposta.cz/367190436
      Thanks for any help...

    • By Andrija
      I am currently trying to implement shadow mapping into my project , but although i can render my depth map to the screen and it looks okay , when i sample it with shadowCoords there is no shadow.
      Here is my light space matrix calculation
      mat4x4 lightViewMatrix; vec3 sun_pos = {SUN_OFFSET * the_sun->direction[0], SUN_OFFSET * the_sun->direction[1], SUN_OFFSET * the_sun->direction[2]}; mat4x4_look_at(lightViewMatrix,sun_pos,player->pos,up); mat4x4_mul(lightSpaceMatrix,lightProjMatrix,lightViewMatrix); I will tweak the values for the size and frustum of the shadow map, but for now i just want to draw shadows around the player position
      the_sun->direction is a normalized vector so i multiply it by a constant to get the position.
      player->pos is the camera position in world space
      the light projection matrix is calculated like this:
      mat4x4_ortho(lightProjMatrix,-SHADOW_FAR,SHADOW_FAR,-SHADOW_FAR,SHADOW_FAR,NEAR,SHADOW_FAR); Shadow vertex shader:
      uniform mat4 light_space_matrix; void main() { gl_Position = light_space_matrix * transfMatrix * vec4(position, 1.0f); } Shadow fragment shader:
      out float fragDepth; void main() { fragDepth = gl_FragCoord.z; } I am using deferred rendering so i have all my world positions in the g_positions buffer
      My shadow calculation in the deferred fragment shader:
      float get_shadow_fac(vec4 light_space_pos) { vec3 shadow_coords = light_space_pos.xyz / light_space_pos.w; shadow_coords = shadow_coords * 0.5 + 0.5; float closest_depth = texture(shadow_map, shadow_coords.xy).r; float current_depth = shadow_coords.z; float shadow_fac = 1.0; if(closest_depth < current_depth) shadow_fac = 0.5; return shadow_fac; } I call the function like this:
      get_shadow_fac(light_space_matrix * vec4(position,1.0)); Where position is the value i got from sampling the g_position buffer
      Here is my depth texture (i know it will produce low quality shadows but i just want to get it working for now):
      sorry because of the compression , the black smudges are trees ... https://i.stack.imgur.com/T43aK.jpg
      EDIT: Depth texture attachment:
      glTexImage2D(GL_TEXTURE_2D, 0,GL_DEPTH_COMPONENT24,fbo->width,fbo->height,0,GL_DEPTH_COMPONENT,GL_FLOAT,NULL); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); glFramebufferTexture2D(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_TEXTURE_2D, fbo->depthTexture, 0);
  • Popular Now