Sign in to follow this  
redneon

OpenGL OpenGL ES 2 Texture Not Rendering

Recommended Posts

redneon    134
I'm porting my game framework from OpenGL 3/4 to OpenGL ES 2 but I'm having an issue where textures aren't being rendered.

In once instance I'm using simple vertex buffer objects to store the vertices and texcoords. In my OpenGL code these are bound in vertex arrays but I understand they aren't used in ES. Basically, I have some initialisation code where I do this:

[source lang="cpp"]
//glGenVertexArrays(1, &m_vao); //Not used in GLES.
glGenBuffers(2, m_vbo);

//glBindVertexArray(m_vao); //Not used in GLES.

glBindBuffer(GL_ARRAY_BUFFER, m_vbo[0]);
glBufferData(GL_ARRAY_BUFFER, 4 * sizeof(Vector2), ms_verts, GL_STATIC_DRAW);

glBindBuffer(GL_ARRAY_BUFFER, m_vbo[1]);
glBufferData(GL_ARRAY_BUFFER, 4 * sizeof(Vector2), ms_texCoords, GL_STATIC_DRAW);
[/source]

And then when it comes time to render I do this:

[source lang="cpp"]

int32_t* pUniformHandle = m_uniforms.Find(textureParamName);

if (pUniformHandle)
{
glActiveTexture(GL_TEXTURE0);
glBindTexture(GL_TEXTURE_2D, m_textureHandle);
glUniform1i(*pUniformHandle, 0);
}

//glBindVertexArray(m_vao); //Not used in GLES.

glBindBuffer(GL_ARRAY_BUFFER, m_vbo[0]);
glVertexAttribPointer(Effect::POSITION_ATTR, 2, GL_FLOAT, GL_FALSE, 0, 0);
glEnableVertexAttribArray(Effect::POSITION_ATTR);

glBindBuffer(GL_ARRAY_BUFFER, m_vbo[1]);
glVertexAttribPointer(Effect::TEXCOORD0_ATTR, 2, GL_FLOAT, GL_FALSE, 0, 0);
glEnableVertexAttribArray(Effect::TEXCOORD0_ATTR);

glDrawArrays(GL_TRIANGLE_STRIP, 0, 4);

glDisableVertexAttribArray(Effect::TEXCOORD0_ATTR);
glDisableVertexAttribArray(Effect::POSITION_ATTR);
[/source]

In OpenGL (with those "Not used in GLES" bits uncommented) this works fine but in GLES the prims are being rendered but the texture isn't being applied. For reference, my shader looks like this:

Vertex shader:

[source lang="plain"]
uniform mat4 worldMatrix;
uniform mat4 projectionMatrix;

attribute vec2 aPosition;
attribute vec2 aTexCoord;

varying vec2 vTexCoord;

void main()
{
vTexCoord = aTexCoord;
mat4 worldProjMatrix = projectionMatrix * worldMatrix;
gl_Position = worldProjMatrix * vec4(aPosition, 0.0, 1.0);
}
[/source]

Fragment shader:

[source lang="plain"]
uniform sampler2D texture;
uniform vec4 colour;

varying vec2 vTexCoord;

void main()
{
gl_FragColor = texture2D(texture, vTexCoord) * colour;
}
[/source]

Can anyone see what I'm doing wrong? I've been scanning through the GLES book but I can't see anything obvious.

Share this post


Link to post
Share on other sites
clb    2147
[quote name='redneon' timestamp='1341001825' post='4954077']
In OpenGL (with those "Not used in GLES" bits uncommented) this works fine but in GLES the prims are being rendered but the texture isn't being applied
[/quote]

To be precise, there is no such thing 'the texture isn't being applied'. What do you mean exactly? The geometry renders properly, but all rasterized fragments come out black (i.e. the texture2D call in the shader comes out black) ?

I have run into such cases several times with GLES2, and searching the codebase, I find I have added these checks:

[code]


/* GLES2 Tegra2(?) bug:
If you specify wrap for texture S coordinate and clamp for texture T coordinate, and the texture width is pow2,
but height is not, the wrap operation will silently fail and be treated as a clamp operation.
*/

/* Sanity check to avoid GLES2 SILENT FAILURES: http://www.khronos.org/opengles/sdk/docs/man/xhtml/glTexParameter.xml
If the texture does not have mipmaps, specifying MIN filter of GL_xxx_MIPMAP_xxx will succeed, but silently
render black. */
const bool hasMipmaps = targetTexture->NumMipmaps() > 1;

if (hasMipmaps)
{
if (!IsPow2(targetTexture->Width()) || !IsPow2(targetTexture->Height()))
{
LOGE("ApplyTextureSampler Error: GLES2 will now silently render black since mipmapping was specified for a non-pow2 texture! Killing mipmaps from texture '%s' as a workaround.",
targetTexture->Name().c_str());
targetTexture->DisableMipmaps();
}
}
[/code]

[code]

/* Sanity check to detect GLES2 SILENT FAILURES: http://www.khronos.org/opengles/sdk/docs/man/xhtml/glTexParameter.xml
" if the width or height of a texture image are not powers of two and either the
GL_TEXTURE_MIN_FILTER is set to one of the functions that requires mipmaps or the GL_TEXTURE_WRAP_S or
GL_TEXTURE_WRAP_T is not set to GL_CLAMP_TO_EDGE, then the texture image unit will return
(R, G, B, A) = (0, 0, 0, 1). " */
if ((textureSampler->addressU != TextureAddressClamp || textureSampler->addressV != TextureAddressClamp) && (!IsPow2(targetTexture->Width()) || !IsPow2(targetTexture->Height())))
LOGE("ApplyTextureSampler Error: GLES2 doesn't support other addressing modes than GL_CLAMP_TO_EDGE when size is not pow2! Size was %dx%d in texture '%s'. (GLES2 will now silently render black)",
targetTexture->Width(), targetTexture->Height(), targetTexture->Name().c_str());
[/code]

The page http://www.khronos.org/opengles/sdk/docs/man/xhtml/glTexParameter.xml documents
[quote]

Suppose that a texture is accessed from a fragment shader or vertex shader and has set GL_TEXTURE_MIN_FILTER to one of the functions that requires mipmaps. If either the dimensions of the texture images currently defined (with previous calls to glTexImage2D, glCompressedTexImage2D, or glCopyTexImage2D) do not follow the proper sequence for mipmaps (described above), or there are fewer texture images defined than are needed, or the set of texture images were defined with different formats or types, then the texture image unit will return (R, G, B, A) = (0, 0, 0, 1).

Similarly, if the width or height of a texture image are not powers of two and either the GL_TEXTURE_MIN_FILTER is set to one of the functions that requires mipmaps or the GL_TEXTURE_WRAP_S or GL_TEXTURE_WRAP_T is not set to GL_CLAMP_TO_EDGE, then the texture image unit will return (R, G, B, A) = (0, 0, 0, 1).
[/quote]

Needless to say, the very existence of documented silent failure cases for an API (combined with the lack of a documented way to set up a debug mode that would properly detect these) is a major picard facepalm.jpg situation.

Share this post


Link to post
Share on other sites
redneon    134
[quote name='clb' timestamp='1341007126' post='4954112']
[color=#282828][font=helvetica, arial, verdana, tahoma, sans-serif][size=3][left][background=rgb(250, 251, 252)]To be precise, there is no such thing 'the texture isn't being applied'. What do you mean exactly? The geometry renders properly, but all rasterized fragments come out black (i.e. the texture2D call in the shader comes out black) ?[/background][/left][/size][/font][/color]
[/quote]

Sorry, yes, I was generalising as I wrote the post quickly but yeah the geometry renders correctly but black. If I change the fragment shader to output a defined colour like, say gl_FragColour = vec4(1.0, 0.0, 0.0, 1.0); then it renders with the colour I supplied instead of black. But when I use the texture2D function I just get black prims.

The particular texture I'm trying to display is 512x512 so that rules out the power of two thing. I've also just tried setting GL_TEXTURE_WRAP_S and GL_TEXTURE_WRAP_T to GL_CLAMP_TO_EDGE and GL_TEXTURE_MIN_FILTER and FL_TEXTURE_MAG_FILTER to GL_LINEAR but it hasn't made a difference.

Also, not sure if it makes a difference but I am using ATI's GLES SDK in Windows. My plan was to get it working in Windows, so I know it's working, before I move it across to my Raspberry Pi, which is my ultimate goal.

I'll have more of a look tomorrow as I'm done for tonight.

Share this post


Link to post
Share on other sites
L. Spiro    25638
The OpenGL ES 2 Windows® SDK’s do not work exactly the same as on real devices, but you should at least be able to display textures.

There can be many reasons for getting black textures.[list=1]
[*][s]If mipmaps are enabled but the image does not have a full mipmap chain supplied (full meaning down to 1×1).[/s]
[*][s]If the texture is not a power of 2 and the wrap modes are not set to GL_CLAMP_TO_EDGE.[/s]
[*][s]If the texture is not being activated in the appropriate slot.[/s]
[*][s]If the sampler has not been assigned to that slot.[/s]
[*]If the texture coordinates are absent or incorrect.
[*]If “colour” has not been assigned.
[/list]

I give you the benefit of a doubt on #4, since I see code that is attempting to set the sampler to 0, but I have no way of knowing if the handle is actually valid or not. But samplers default to 0 anyway so that won’t be your problem.

Which means you have 2 more things to test.
Test #5 by printing the texture coordinates.

[CODE]gl_FragColor = vec4( vTexCoord.x, vTexCoord.y, 0.0, 1.0 );[/CODE]

Test #6 by removing “colour” from the equation. I don’t see anywhere where you are setting that value.


L. Spiro

Share this post


Link to post
Share on other sites
redneon    134
I like #5, it's a clever way of seeing the texture coordinates are valid. Alas, mine were, black top-left, red top-right, green bottom-left, yellow bottom-right.

I am setting the colour value (though I know in my code I only showed me setting the texture uniform) but just to double check I removed colour from the gl_FragColor calculation and I'm still getting a black square.

I did think perhaps something isn't working in the GLES Windows SDK and that I should just port my code to Pi and fix the issue on there, if it's still an issue. That being said, if I run the Simple_Texture2D sample from the GLES book then the texture displays correctly. The only difference I can see between my code and theirs, however, is that they use glVertexAttribPointer to send the data to the GPU each render instead of storing the data off in a VBO. Should this make a difference? Edited by redneon

Share this post


Link to post
Share on other sites
redneon    134
I just quickly tried sacking off the VBOs and using glVertexAttribPointer to send the data to the GPU each render, as in the Simple_Texture2D sample like this:

[source lang="cpp"]
glVertexAttribPointer(Effect::POSITION_ATTR, 2, GL_FLOAT, GL_FALSE, 0, ms_verts);
glVertexAttribPointer(Effect::TEXCOORD0_ATTR, 2, GL_FLOAT, GL_FALSE, 0, ms_texCoords);

glEnableVertexAttribArray(Effect::POSITION_ATTR);
glEnableVertexAttribArray(Effect::TEXCOORD0_ATTR);

glDrawArrays(GL_TRIANGLE_STRIP, 0, 4);

glDisableVertexAttribArray(Effect::TEXCOORD0_ATTR);
glDisableVertexAttribArray(Effect::POSITION_ATTR);
[/source]

But now even the geometry isn't being rendered. I've probably done something stupid but I only had a quick five minutes before I go to work so I thought I'd give it a try. I'll have more of a look when I get back from work.

Share this post


Link to post
Share on other sites
redneon    134
I've fixed why the geometry wasn't being rendered when I don't use VBOs (I was being an idiot and hadn't unbound a buffer I was using elsewhere). So, I've got the geometry rending both with and without VBOs but in both instances I'm just getting black prims without the texture.

I'm now trying to match my code as closely as possible to the Simple_Texture2D sample. The first step was removing the VBOs, I've also tried using their texture code too but it hasn't made a difference. There must be something obviously different between my code and theirs though, for theirs to be working and mine not. I'm sure I'll get to the bottom of it if I keep chugging away :)

Share this post


Link to post
Share on other sites
redneon    134
Just thinking, is there any chance that I could have set my window up incorrectly? Maybe something wrong in the EGL stuff? I don't think that this could cause this issue but I'm just clutching at straws really, as I can't see any difference between my code and the Simple_Texture2D code.

Share this post


Link to post
Share on other sites
clb    2147
Try assuming that it is an asset difference rather than a code difference. Try with a known working texture asset. Or try starting from the working sample and try to evolve it towards your breaking testcase one by one to see where it breaks.

I don't think there's anything in the EGL spec that would affect how texture2D sampling is done in the shader code.

Share this post


Link to post
Share on other sites
redneon    134
Bloody hell. I've fixed it and, as per usual with these things, it was user error. I was passing an incorrect value into glTexImage2D for the internal format. If you look at my texture load code below you can see I'm incorrectly passing bitDepth into glTexImage2D instead of textureFormat. Doh! I've no idea how this works correctly in normal OpenGL, though. I would expect it to fail like it does in GLES. Ah well, nevermind.
[source lang="cpp"]int32_t width, height, bitDepth = 0;
//Load the image.
uint8_t* pData = ::stbi_load_from_memory(rTextureFile.GetData(), rTextureFile.GetSize(), &width, &height, &bitDepth, 0);

if (pData)
{
m_width = width;
m_height = height;
m_bitDepth = bitDepth;

uint32_t textureFormat = bitDepth == 4 ? GL_RGBA : GL_RGB;
glGenTextures(1, &m_handle);
glBindTexture(GL_TEXTURE_2D, m_handle);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR);

glTexImage2D(GL_TEXTURE_2D,
0,
bitDepth,
width,
height,
0,
textureFormat,
GL_UNSIGNED_BYTE,
pData);

//No longer need the image.
stbi_image_free(pData);

return true;
}

return false;
[/source]
Thanks for your help, everyone.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Partner Spotlight

  • Similar Content

    • By pseudomarvin
      I assumed that if a shader is computationally expensive then the execution is just slower. But running the following GLSL FS instead just crashes
      void main() { float x = 0; float y = 0; int sum = 0; for (float x = 0; x < 10; x += 0.00005) { for (float y = 0; y < 10; y += 0.00005) { sum++; } } fragColor = vec4(1, 1, 1 , 1.0); } with unhandled exception in nvoglv32.dll. Are there any hard limits on the number of steps/time that a shader can take before it is shut down? I was thinking about implementing some time intensive computation in shaders where it would take on the order of seconds to compute a frame, is that possible? Thanks.
    • By Arulbabu Donbosco
      There are studios selling applications which is just copying any 3Dgraphic content and regenerating into another new window. especially for CAVE Virtual reality experience. so that the user opens REvite or CAD or any other 3D applications and opens a model. then when the user selects the rendered window the VR application copies the 3D model information from the OpenGL window. 
      I got the clue that the VR application replaces the windows opengl32.dll file. how this is possible ... how can we copy the 3d content from the current OpenGL window.
      anyone, please help me .. how to go further... to create an application like VR CAVE. 
       
      Thanks
    • By cebugdev
      hi all,

      i am trying to build an OpenGL 2D GUI system, (yeah yeah, i know i should not be re inventing the wheel, but this is for educational and some other purpose only),
      i have built GUI system before using 2D systems such as that of HTML/JS canvas, but in 2D system, i can directly match a mouse coordinates to the actual graphic coordinates with additional computation for screen size/ratio/scale ofcourse.
      now i want to port it to OpenGL, i know that to render a 2D object in OpenGL we specify coordiantes in Clip space or use the orthographic projection, now heres what i need help about.
      1. what is the right way of rendering the GUI? is it thru drawing in clip space or switching to ortho projection?
      2. from screen coordinates (top left is 0,0 nd bottom right is width height), how can i map the mouse coordinates to OpenGL 2D so that mouse events such as button click works? In consideration ofcourse to the current screen/size dimension.
      3. when let say if the screen size/dimension is different, how to handle this? in my previous javascript 2D engine using canvas, i just have my working coordinates and then just perform the bitblk or copying my working canvas to screen canvas and scale the mouse coordinates from there, in OpenGL how to work on a multiple screen sizes (more like an OpenGL ES question).
      lastly, if you guys know any books, resources, links or tutorials that handle or discuss this, i found one with marekknows opengl game engine website but its not free,
      Just let me know. Did not have any luck finding resource in google for writing our own OpenGL GUI framework.
      IF there are no any available online, just let me know, what things do i need to look into for OpenGL and i will study them one by one to make it work.
      thank you, and looking forward to positive replies.
    • By fllwr0491
      I have a few beginner questions about tesselation that I really have no clue.
      The opengl wiki doesn't seem to talk anything about the details.
       
      What is the relationship between TCS layout out and TES layout in?
      How does the tesselator know how control points are organized?
          e.g. If TES input requests triangles, but TCS can output N vertices.
             What happens in this case?
      In this article,
      http://www.informit.com/articles/article.aspx?p=2120983
      the isoline example TCS out=4, but TES in=isoline.
      And gl_TessCoord is only a single one.
      So which ones are the control points?
      How are tesselator building primitives?
    • By Orella
      I've been developing a 2D Engine using SFML + ImGui.
      Here you can see an image
      The editor is rendered using ImGui and the scene window is a sf::RenderTexture where I draw the GameObjects and then is converted to ImGui::Image to render it in the editor.
      Now I need to create a 3D Engine during this year in my Bachelor Degree but using SDL2 + ImGui and I want to recreate what I did with the 2D Engine. 
      I've managed to render the editor like I did in the 2D Engine using this example that comes with ImGui. 
      3D Editor preview
      But I don't know how to create an equivalent of sf::RenderTexture in SDL2, so I can draw the 3D scene there and convert it to ImGui::Image to show it in the editor.
      If you can provide code will be better. And if you want me to provide any specific code tell me.
      Thanks!
  • Popular Now