Jump to content
  • Advertisement
Sign in to follow this  
JDGamedev

Trouble Smoothly Moving Player Sprite

This topic is 2295 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

I'm having trouble smoothing out the movement of a player in the game I'm working on. I've just started screwing around with Java2D stuff so it's all very basic fyi.

The problem is that my player stops moving when changing to the opposite direction. Here's an example to explain it further:

When I hold 'D' to move the player right, then push and hold 'A' to change direction, everything works fine. However, when I release 'A' while still holding 'D', my player stops instead of going back to the right. This is clearly because I haven't pressed 'D' again, but I want him to move as long as I'm holding the key, not just when I press it.

I hope that makes sense, and here is the relevant code (hopefully I get it all in here). Any help would be greatly appreciated. Thanks

Here is the key even stuff.
[source lang="java"] // key event stuff
addKeyListener(new KeyAdapter(){
public void keyPressed(KeyEvent ke){
if(ke.getKeyCode() == KeyEvent.VK_W){
p1.playerDirections(Player.MOVE_UP);
}
if(ke.getKeyCode() == KeyEvent.VK_S){
p1.playerDirections(Player.MOVE_DOWN);
}
if(ke.getKeyCode() == KeyEvent.VK_A){
p1.playerDirections(Player.MOVE_LEFT);
}
if(ke.getKeyCode() == KeyEvent.VK_D){
p1.playerDirections(Player.MOVE_RIGHT);
}
}
public void keyReleased(KeyEvent ke){
if(ke.getKeyCode() == KeyEvent.VK_W){
p1.stopY();
}
if(ke.getKeyCode() == KeyEvent.VK_S){
p1.stopY();
}
if(ke.getKeyCode() == KeyEvent.VK_A){
p1.stopX();
}
if(ke.getKeyCode() == KeyEvent.VK_D){
p1.stopX();
}
}
public void keyTyped(KeyEvent ke){

}

});
}[/source]
Here is the player class stuff:

[source lang="java"] public Player(World w){
world = w;
playerImg = new ImageIcon("res/player.png").getImage();
playerRect = new Rectangle(50, 50, playerWidth, playerHeight);
}

private void setXDir(int dir){
xDir = dir;
}
private void setYDir(int dir){
yDir = dir;
}

public void update(){
}

public void draw(Graphics g){
g.drawImage(playerImg, playerRect.x, playerRect.y, playerWidth, playerHeight, null);
}

// setting directions for player movement
public void playerDirections(int nav){
switch(nav){
default: System.out.println("That is not a valid entry for changing maps.");
case MOVE_UP:
setYDir(-1);
break;
case MOVE_DOWN:
setYDir(1);
break;
case MOVE_LEFT:
setXDir(-1);
break;
case MOVE_RIGHT:
setXDir(1);
break;
}
}

// move player based on directions
// methods for controlling movement
public void move(){
playerRect.x += xDir;
playerRect.y += yDir;
}

public void stopX(){
setXDir(0);
}
public void stopY(){
setYDir(0);
}[/source]

Share this post


Link to post
Share on other sites
Advertisement
One suggestion I have is to use physics to make the movement instead of moving the sprites statically unless your trying to get that look. Then you can just apply impulses to move your sprite around. You will get much smoother movement, by updating your sprite this way, and it will look more realistic. Check out this link. Edited by DevLiquidKnight

Share this post


Link to post
Share on other sites
It's because the way you are handling moving your player around the screen with the KeyEvent class.....is the simple answer.

You havent mentioned in your post in any way - why you think this unexpected result is happening (as in the player just stops). Read the code back to yourself and then tell us why.

We would need to see your complete code to give more suggestions. You are probably using an AL for example.

Hint: There will be several changes to make to the different class files.

Share this post


Link to post
Share on other sites
You could try separating the movement from the key listener:

[source lang="cpp"]
// key event stuff
addKeyListener(new KeyAdapter(){
public void keyPressed(KeyEvent ke){
if(ke.getKeyCode() == KeyEvent.VK_W){
bMoveUp = true;
}
if(ke.getKeyCode() == KeyEvent.VK_S){
bMoveDown = true;
}
if(ke.getKeyCode() == KeyEvent.VK_A){
bMoveLeft = true;
}
if(ke.getKeyCode() == KeyEvent.VK_D){
bMoveRight = true;
}
}
public void keyReleased(KeyEvent ke){
if(ke.getKeyCode() == KeyEvent.VK_W){
bMoveUp = false;
}
if(ke.getKeyCode() == KeyEvent.VK_S){
bMoveDown = false;
}
if(ke.getKeyCode() == KeyEvent.VK_A){
bMoveLeft = false;
}
if(ke.getKeyCode() == KeyEvent.VK_D){
bMoveRight = false;
}
}
public void keyTyped(KeyEvent ke){

}

});[/source]

[source lang="cpp"]
// check if player is moving and set direction

if (bMoveUp) setYDir(-1);
[color=#000000] else if (bMoveDown) setYDir(1);
[color=#000000] else setYDir(0);

[color=#000000][font=Consolas,] if (bMoveLeft) setXDir(-1);[/font]
[color=#000000][font=Consolas,] else if (bMoveRight) setXDir(1);[/font]
[color=#000000] else setXDir(0);
[/source]

Share this post


Link to post
Share on other sites

You could try separating the movement from the key listener:


Thanks for that. I actually mimicked the movement from a Ludum Dare submission which helped a ton. I pretty much did what you just mentioned. Now if I could just figure out this damn collision detection...

Share this post


Link to post
Share on other sites
A small modification's of eFoDay's snippet:


// check if player is moving and set direction

int dx = 0;
int dy = 0;

if ( bMoveUp ) dy--;
if ( bMoveDown ) dy++;
if ( bMoveLeft ) dx--;
if ( bMoveRight ) dx++;

setXDir( dx );
setYDir( dy );

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
×

Important Information

By using GameDev.net, you agree to our community Guidelines, Terms of Use, and Privacy Policy.

We are the game development community.

Whether you are an indie, hobbyist, AAA developer, or just trying to learn, GameDev.net is the place for you to learn, share, and connect with the games industry. Learn more About Us or sign up!

Sign me up!