Using this to not store the permutations is not saving space.
Actually, it saves a quarter of a meg ;-)
Which is eight times as much memory as my first computer had!
(C++ Beginner) I hate to post here, but... why won't my "if" statement evaluate a string?
Actually, it saves a quarter of a meg ;-)
Which is eight times as much memory as my first computer had!
[size=2][Edit:] Double-posted for some reason. Can't seem to find the 'delete post' button.
I seriously hope you're jocking.
Using this to not store the permutations is not saving space.
Rather, doing the permutation thing is brain damaged. And don't even get me started on checking the match. I'm sure I've seen it on the daily WTF.
Thus, not storing them is not about saving space but rather doing things right.
I'm confused about what you are disagreeing with.
Are you saying that this...
if(name == "person mcperson" || name == "Person Mcperson" || name == "Person McPerson"
|| name == "PERSON MCPERSON" || name == "person MCPERSON" || name == "PERSON mcperson" || ...etc... )
{
//...
}...is better than this:
std::string name = "Person McPerson";
std::transform(name.begin(), name.end(), name.begin(), ::tolower);
if(name == "person mcperson")
{
//...
}Or are you just saying to cache the lowercase name when possible, so you don't have to convert it every function call?
As for 'saving space', I fully agree that any 'space' you save is absurdly small and unimportant if developing for a modern PC. For me, the benefit of the second one is about writing cleaner and easier-to-maintain code, and also ensuring you catch all the valid possibilities and not just some of them.
Actually, it saves a quarter of a meg ;-)
Which is eight times as much memory as my first computer had!
How does it save a quarter of a megabyte? Worst case scenario, with the example I gave ("Person McPerson"), it'd save 32 kilabytes I think - and only if someone bothered to type out every possible lowercase vs uppercase version of "Person McPerson", starting with "person mcperson", "Person mcperson", "PErson mcperson", "PERson mcperson", and so on, which is unlikely.
if (username == "Tiffany" || "tiffany" || "Tiffany McClure" || "tiffany McClure" || "Tiffany Mcclure" || "tiffany mcclue")
Am I the only one thinking that looks pretty elegant? Is there any language that implements this way of checking the same variable for different boolean cases?
It looks to me like "Tiffany" is the real string to look for here, so I would convert to lowercase and check for "tiffany".. what if she wrotes "Tiffany Cupcake" ?
You'll miss that.
[quote name='bls61793' timestamp='1342363560' post='4959267']
if (username == "Tiffany" || "tiffany" || "Tiffany McClure" || "tiffany McClure" || "Tiffany Mcclure" || "tiffany mcclue")
Am I the only one thinking that looks pretty elegant? Is there any language that implements this way of checking the same variable for different boolean cases?
It looks to me like "Tiffany" is the real string to look for here, so I would convert to lowercase and check for "tiffany".. what if she wrotes "Tiffany Cupcake" ?
You'll miss that.[/quote]Some languages allow this:
switch(name){
case "Tiffany":
case "tiffany":
case "Tiffany McClure":
...
break;
default:
...
}Close enough?
Some languages allow this:
switch(name){Close enough?
case "Tiffany":
case "tiffany":
case "Tiffany McClure":
...
break;
default:
...
}
C++ switch statements only work with some data types (mostly ints) - not with std::strings. Even so, that's pretty ugly syntax.
Am I the only one who noticed the typo ([font=courier new,courier,monospace]... "tiffany McClure" || "Tiffany Mcclure" || "tiffany mcclue"[/font])? One big reason checking each permutation sucks is because it's too easy to introduce human error.
I'd say convert to lower (or upper) case and check the string. I love regular expressions, but I probably wouldn't use them here.
I'd say convert to lower (or upper) case and check the string. I love regular expressions, but I probably wouldn't use them here.
[quote name='King Mir' timestamp='1342470870' post='4959728']
Some languages allow this:
switch(name){Close enough?
case "Tiffany":
case "tiffany":
case "Tiffany McClure":
...
break;
default:
...
}
C++ switch statements only work with some data types (mostly ints) - not with std::strings. Even so, that's pretty ugly syntax.
[/quote]Which is why I said "some languages" and not "c++ and some languages". Why do you think switches are ugly?
Which is why I said "some languages" and not "c++ and some languages"[/quote]Ah, I thought your "some languages" was a not-so-subtle "hint hint", referring to C++ itself (What with the topic being about C++, and the "Close enough?" comment).
[quote name='Servant of the Lord' timestamp='1342471896' post='4959736']
C++ switch statements only work with some data types (mostly ints) - not with std::strings. Even so, that's pretty ugly syntax.
Why do you think switches are ugly?[/quote]
Not switches, per se, but using switches (which are typically meant to branch logic) to imitate the use of AND logic (which is what && is for).
In some situations it may be the best solution, but in general I prefer to use if() when I mean logical IF, and && when I mean logical AND.
This topic is closed to new replies.
Advertisement
Popular Topics
Advertisement
