• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
monkeyboi

Run-Time Check Failure #2

3 posts in this topic

All I want to do right now is measuring the time consumed by a certain call. Because the original program is not written by me, so I only modify very a few places. I will give you the structure first
[CODE]
int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE prevInstance,
PSTR cmdLine, int showCmd)
{
// Enable run-time memory check for debug builds.
#if defined(DEBUG) | defined(_DEBUG)
_CrtSetDbgFlag( _CRTDBG_ALLOC_MEM_DF | _CRTDBG_LEAK_CHECK_DF );
#endif
MeshDemo app(hInstance, "Mesh Demo", D3DDEVTYPE_HAL, D3DCREATE_HARDWARE_VERTEXPROCESSING);
gd3dApp = &app;
DirectInput di(DISCL_NONEXCLUSIVE|DISCL_FOREGROUND, DISCL_NONEXCLUSIVE|DISCL_FOREGROUND);
gDInput = &di;
if(!gd3dApp->checkDeviceCaps())
return 0;
else
return gd3dApp->run(); //corrupted here
}
[/CODE]
[CODE]

//global scope//
//double preTime;
//double curTime;
//float secsPerCnt;
//double timePass;
//global scope//

class MeshDemo : public D3DApp
{
public:
MeshDemo(HINSTANCE hInstance, std::string winCaption, D3DDEVTYPE devType, DWORD requestedVP);
~MeshDemo();
...
private:
...
//Time measurement
D3DXFONT_DESC d3dFont;
ID3DXFont* m_pFont;
double preTime;
double curTime;
float secsPerCnt;
double timePass;
};
[/CODE]
[CODE]
void MeshDemo::SetupFond(){
memset(&d3dFont,0,sizeof(d3dFont));
d3dFont.Height=15; // in logical units
d3dFont.Width=7; // in logical units
d3dFont.Weight=500;// boldness, range 0(light) - 1000(bold)
d3dFont.Italic=FALSE;
d3dFont.CharSet=DEFAULT_CHARSET;
memcpy(d3dFont.FaceName,"Times New Roman",64);
//d3dFont.FaceName = *L"Times New Roman";
D3DXCreateFontIndirect(gd3dDevice, &d3dFont, &m_pFont);
long long cntsPerSec = 0;
QueryPerformanceFrequency((LARGE_INTEGER*)&cntsPerSec);
secsPerCnt = 1.0f / (float)cntsPerSec;
long long CurTimeStamp = 0;
QueryPerformanceCounter((LARGE_INTEGER*)&CurTimeStamp);
preTime = secsPerCnt * CurTimeStamp;
curTime = preTime;
timePass = 0;
}
[/CODE]
[CODE]
void MeshDemo::drawScene()
{
long long CurTimeStamp = 0;
QueryPerformanceCounter((LARGE_INTEGER*)&CurTimeStamp);
curTime = secsPerCnt * CurTimeStamp;
timePass = curTime - preTime;
preTime = curTime;
// Clear the backbuffer and depth buffer.
HR(gd3dDevice->Clear(0, 0, D3DCLEAR_TARGET | D3DCLEAR_ZBUFFER, 0xffffffff, 1.0f, 0));
HR(gd3dDevice->BeginScene());
RECT Rect = { 0,0,600,600 };
char* temp = new char[100];
sprintf(temp,"Time Since Last Frame = %f\n",timePass);
m_pFont->DrawText(NULL,(LPCSTR)temp, -1, &Rect, DT_CENTER | DT_VCENTER, 0xFFFF0000);
delete[] temp;

HR(gd3dDevice->EndScene());
// Present the backbuffer.
HR(gd3dDevice->Present(0, 0, 0, 0));
}

[/CODE]

The above version works fine, but when i move the variables, including preTime, curTime, secsPerCnt and timePass, to globle scope, I will get Run-Time Check Failure #2 - Stack around the variable 'app' was corrupted assertion every time I shut the program. And the program will stop and point to return gd3dApp->run() where is in the main function.

Any idea about the reason or how to track it down?

Jerry Edited by monkeyboi
0

Share this post


Link to post
Share on other sites
This looks very dodgy:[code]memcpy(d3dFont.FaceName,"Times New Roman",64);[/code]
FaceName is LF_FACESIZE (IIRC, 32) char's long, but you're copying 64 bytes of data into it. That means, you're corrupting the 32 bytes of memory that are allocated immediately after that variable, which in your case is:[code]ID3DXFont* m_pFont;
double preTime;
double curTime;
float secsPerCnt;
double timePass;[/code]So when you remove those variables from your class, then instead of just corrupting your own memory with that faulty memcpy, you're trashing someone elses memory (which turns out to be stack guards).

Furthermore, with that memcpy, your source array is only 16-bytes long, so reading 64-bytes from could cause a fatal error at that point (if trying to read protected memory).
You should calculate how many bytes are in your source array ("Times New Roman"), and then assert that this size is less than or equal to LF_FACESIZE, and then perform the copy operation using this measured size.
2

Share this post


Link to post
Share on other sites
Thanks Hodgman

Yeah that is the place where goes wrong. I will be more careful next time.

Jerry
1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0