• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
iwoplaza

FStream Problem

5 posts in this topic

I have a problem with the library "fstream", because I'd like to read 100 characters by using the FOR loop. For example, a text file from I want to read the characters look like this:
A
B
C
D



And I want to read the characters one by one to four variables CHAR using a loop.
But I do not know how to do it [img]http://public.gamedev.net//public/style_emoticons/default/sad.png[/img]. Can you help?

Thanks in advance.
0

Share this post


Link to post
Share on other sites
Just checking: is this a homework assignment?
Also, am I right in thinking you want to read 25 groups of 4 characters for a total of 100? And each character is on its own line?

In any case, to get you started:

[code]
#include <fstream>
#include <iostream>

int main(int argc, char **argv)
{
if (argc != 2)
return 1;

std::ifstream file(argv[1]);
char ch = 0;

while (file >> ch)
{
std::cout << "read char: " << ch << '\n';
}

return 0;
}
[/code] Edited by e?dd
2

Share this post


Link to post
Share on other sites
edd's method is great, normally a while cycle is used.

I normally use

[source lang="cpp"]while (!file.eof())
{
//DO THE READING HERE
}[/source]
-2

Share this post


Link to post
Share on other sites
Thanks to all, but I solved it for myself [img]http://public.gamedev.net//public/style_emoticons/default/smile.png[/img].
I changed the contents of a text file from:
a
b
c
d
...
(one hundred characters)

to:

abcdefghijk ... (one hundred characters)


Instead of loading the characters one by one, I loaded a line of characters to an array of char.
.
Example:

[CODE]
char characters[100];
char loadline[100];
fstream input;
input.open("fontprops.txt");
input >> loadline;
for(int i = 0;i < 100;i++)
{
characters[i].number = i;
characters[i].character = loadtext[i];
}
[/CODE] Edited by iwoplaza
0

Share this post


Link to post
Share on other sites
[quote name='iwoplaza' timestamp='1342761118' post='4961184']
Instead of loading the characters one by one, I loaded a line of characters to an array of char.
.
Example:

[CODE]
char loadline[100];
fstream input;
input.open("fontprops.txt");
input >> loadline;
[...]
[/CODE]
[/quote]

Unfortunately, this code is very 'dangerous'. If the first string of your file has more than 99 characters (bytes), then your program will blindly read those. According to the C++ standard, once you do something like this, the behaviour of your program is undefined. In reality, what would likely happen is that that the "input >> loadline" line would start scribbling data from the file all over your program's stack, quite possibly corrupting the surrounding data, perhaps even the local variables of the calling function(s). Or it might overwrite the saved return address in the current frame. Or... Whatever happens, it won't be pretty.

Instead, it's best to read in to an std::string, which will ensure the required amount of storage is allocated correctly. Fortunately, the code doesn't require much surgery to do that:

[code]
#include <string>

// ...

std::string loadline;
std::ifstream input("fontprops.txt");
input >> loadline;

if (loadline.size() != 100)
{
std::cerr << "expected 100 characters, got " << loadline.size() << std::endl;
return false;
}

for (int i = 0; i < 100; ++i)
{
// use loadline[i] in the same way to get the char at index i
}
[/code]

Alternatively, if you want bytes rather than formatted chars, you can use std::istream::read(), which takes a numeric parameter specifying the amount of data wanted. Edited by e?dd
1

Share this post


Link to post
Share on other sites
[quote name='iwoplaza' timestamp='1342761118' post='4961184']
Thanks to all, but I solved it for myself [img]http://public.gamedev.net//public/style_emoticons/default/smile.png[/img].
I changed the contents of a text file from:
a
b
c
d
...
(one hundred characters)

to:

abcdefghijk ... (one hundred characters)


Instead of loading the characters one by one, I loaded a line of characters to an array of char.
.
Example:

[CODE]
char characters[100];
char loadline[100];
fstream input;
input.open("fontprops.txt");
input >> loadline;
for(int i = 0;i < 100;i++)
{
characters[i].number = i;
characters[i].character = loadtext[i];
}
[/CODE]
[/quote]

as edd said, that code is dangerous, (That type of code used to be(and might still be, allthough modern languages and some OS features (such as DEP) make it alot easier to avoid) one of the most common causes of security flaws in networked applications, at best it will crash the application, at worst it will allow a hacker to send his own code to your application and force it to execute (by for example overwriting the return address), In your case since the application only runs locally with data provided by you its not a big deal but for any application that deals with sockets or third party files it is essential to get things right and it is better to learn how to do things properly before you write code that will run on someone elses machine.
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0