• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Naked Shooter

Can't have function prototype with 4 __m128 parameters?

3 posts in this topic

Trying to copy code from Game Engine Architecture by Jason Gregory..

I have a .h file, SSEMatrixMultiplier, where I tried to put a function prototype:
[CODE]
__m128 mulVectorMatrixAttempt2(__m128 v, __m128 Mrow1, __m128 Mrow2, __m128 Mrow3, __m128 Mrow4);[/CODE]

and a .cpp file, where I try to implement the function:

[CODE]
__m128 mulVectorMatrixAttempt2(__m128 v, __m128 Mrow1, __m128 Mrow2, __m128 Mrow3, __m128 Mrow4)
{
__m128 xMrow1 = _mm_mul_ps(_mm_replicate_x_ps(v), Mrow1);
__m128 yMrow2 = _mm_mul_ps(_mm_replicate_y_ps(v), Mrow2);
__m128 zMrow3 = _mm_mul_ps(_mm_replicate_z_ps(v), Mrow3);
__m128 wMrow4 = _mm_mul_ps(_mm_replicate_w_ps(v), Mrow4);

__m128 result = _mm_add_ps(xMrow1, yMrow2);
result = _mm_add_ps(result, zMrow3);
result = _mm_add_ps(result, wMrow4);
return result;
}
[/CODE]

But the compiler gives me the following errors:

[quote]Error 1 error C2719: 'Mrow3': formal parameter with __declspec(align('16')) won't be aligned c:\...simd sse math test\simd sse math test\ssematrixmultiplier.h 20
Error 3 error C2719: 'Mrow3': formal parameter with __declspec(align('16')) won't be aligned c:\...simd sse math test\simd sse math test\ssematrixmultiplier.cpp 4
Error 2 error C2719: 'Mrow4': formal parameter with __declspec(align('16')) won't be aligned c:\...simd sse math test\simd sse math test\ssematrixmultiplier.h 20
Error 4 error C2719: 'Mrow4': formal parameter with __declspec(align('16')) won't be aligned c:\...simd sse math test\simd sse math test\ssematrixmultiplier.cpp 4[/quote]

Anyone know what's up? Edited by Naked Shooter
0

Share this post


Link to post
Share on other sites
I'm surprised you only get errors for those two parameters as the MSDN page for the error C2719 ([url="http://msdn.microsoft.com/en-us/library/373ak2y1(v=VS.71).aspx"]http://msdn.microsoft.com/en-us/library/373ak2y1(v=VS.71).aspx[/url]) states that __align is not allowed on function parameters so the first 3 should have also tripped the message.

An MSDN Social answer ([url="http://social.msdn.microsoft.com/Forums/en-US/vclanguage/thread/85e53fd8-9345-42d2-bfa1-1ce4ee4e4c68"]http://social.msdn.microsoft.com/Forums/en-US/vclanguage/thread/85e53fd8-9345-42d2-bfa1-1ce4ee4e4c68[/url]) recommends passing them as pointers instead; you might be able to get away with const ref as well.
1

Share this post


Link to post
Share on other sites
When compiling for 32 bits you need to pass SIMD data by reference or pointer. 64 bit ABI allows them to be passed by value at a language level, but if you compile on both targets you need to do it the 32 bit way.

The simple reason is 32 bit ABI does not correctly align the stack to 16 bytes. You may ask, what about local variables then?. Functions that have __m128 variables as local variables cause the compiler to generate additional code to align the stack so they can be stored there.

Note that even in x64, [b]__m128 variables are not passed via xmm registers[/b]. They will be written to the stack and passed by reference behind the scenes. However your code will compile when you write it to pass by value. scalar floats and doubles (i.e. stuff not using __m128 as their data type) DO get passed in xmm registers, but the ABI does not handle SIMD data types. Weird I know but thats the way it is speced at the moment. The way of dealing with this problem is to forceinline all the code passing by value, but that has some rather practical limits. Edited by Zoner
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0