for(it=VectorAsset.begin();it<VectorAsset.end();it++)
{
if(szNameOrType==it->szName||szNameOrType==it->szType)
{
//delete it; // <<< wont compile
VectorAsset.erase(it);
}
}
Asset *cAsset=new Asset(szName,szTexture);
VectorAsset.push_back(*cAsset);void SpriteUnload(string szNameOrType)
{
// Erase any valid items from vector array
std::vector<Asset>::iterator it;
for(it=VectorAsset.begin();it<VectorAsset.end();)
{
if(szNameOrType==it->szName||szNameOrType==it->szType||szNameOrType=="ALL")
{
delete *it;
//VectorAsset.erase(it);
VectorAsset.erase(it);
}
else
it++;
}
}
Asset *cAsset=new Asset(szName,szTexture);
VectorAsset.push_back(*cAsset);
[edit]
delete ⁢ worked, though.
no no no no! You're trying to [font=courier new,courier,monospace]delete[/font] memory that you didn't allocate with [font=courier new,courier,monospace]new[/font]! That memory belongs to the vector/iterator, not to you.
delete ⁢ worked, though.
Asset *cAsset=new Asset(szName,szTexture);[/quote]With a vector of values, this should just be:
VectorAsset.push_back(*cAsset);//makes a new Asset inside the vector, copies your new asset's value the vector's new asset's value
//your original new asset is leaked (cAsset is not put into the vector)Asset cAsset(szName,szTexture);//make a new temporary asset on the stack (new not required). This temporary one will be destructed when it goes out of scope.
VectorAsset.push_back(cAsset);//create a new asset in the vector, copy yours into that new one
//N.B. new/delete aren't required. Destructor will be called upon erasing items from the vector.
OR
you should use a vector of pointers, in which case new/delete would work as you expect them to:Asset *cAsset=new Asset(szName,szTexture);
VectorAsset.push_back(cAsset);//put the pointer into the vector
...
it=VectorAsset.begin()
...
delete *it;//retrieves your original pointer, deletes the allocation that it points to
Thanks for the advice guys!
I have change the code to the following
std::vector<class Asset>(VectorAsset);
So, when I call VectorAsset.erase(it); does the destructor get called still? As I have alot of DirectX code that needs to be cleaned up via the destructor (in each instance).
~Asset()
{
std::cout<<"Destructing: "<<szName<<"\r\n";
}
