• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Czar05

toupper() function?

5 posts in this topic

I am having difficulty with the toupper() function. I can't use the string class with this particular function.

[CODE]
#include <iostream>
#include <cctype>
#include <string>

using namespace std;


void inputnshow(string & a);

int main()
{
string sent;

cout << "The following program will convert a sentence and convert it to uppercase.\n";
cout << " " << endl;
inputnshow(sent);


return 0;
}

void inputnshow(string & a)
{
int n = 0;

while(n < 1)
{
cout << " " << endl;
cout << "Enter a string (q to quit).\n";
getline(cin, a);
toupper(a);
cout << a << endl;

cout << " " << endl;

cout << a << endl;
cout << "Next string (q to quit).\n";
getline(cin, a);
toupper(a);
cout << a << endl;

if(a == "q")
{
cout << "Bye" << endl;
system("Pause");
}

}

}

[/code]


I keep getting an error with the, string a, variable. I tried using a char array, but that requires an initialization and I am looking for user input. Edited by Czar05
0

Share this post


Link to post
Share on other sites
If you're going to make a copy you can just take the argument as a copy, looks cleaner IMO:

[source lang="cpp"]std::string uppercase(std::string s)
{
std::transform(s.begin(), s.end(), s.begin(), toupper);
return s;
}[/source]
0

Share this post


Link to post
Share on other sites
[quote name='Mussi' timestamp='1344189710' post='4966406']
If you're going to make a copy you can just take the argument as a copy, looks cleaner IMO:

[source lang="cpp"]std::string uppercase(std::string s)
{
std::transform(s.begin(), s.end(), s.begin(), toupper);
return s;
}[/source]
[/quote]

Yes, it looks cleaner, but you get to pass by value twice, which is worse that once. A reference is much less to pass than a whole string. Even better would be to use references or pointers to both source and destination strings, or to just modify the original string directly. Edited by SamiHuutoniemi
0

Share this post


Link to post
Share on other sites
[quote name='SamiHuutoniemi' timestamp='1344190246' post='4966409']
Yes, it looks cleaner, but you get to pass by value twice, which is worse that once. A reference is much less to pass than a whole string. Even better would be to use references or pointers to both source and destination strings, or to just modify the original string directly.
[/quote]

The move semantics in the current standard allows you to avoid unnecessary copies when working with temporary copies. That still doesn't make the code I posted as efficient as yours, since the contents of s are first copied and then overwritten(not sure if true, but I think so), but I personally prefer shorter/cleaner functions when performance doesn't matter much [img]http://public.gamedev.net//public/style_emoticons/default/smile.png[/img].

So with regards to your second statement, with the current standard you don't have to use a destination reference for maximum performance per se. Edited by Mussi
0

Share this post


Link to post
Share on other sites
it all depends actually on what you're trying to achieve with your function. in theory, you could have several different functions that do the same thing, with the only difference being how you get the source string, and how you get the destination string.

you could directly modify the source string passed as a reference.
you could pass the destionation string in as a reference.
you could create the destination string in the func and return it.
you could pass the source string as value, modify it then return it.
etc

it think it's mostly a choice of how you're gonna use the function that influences the semantics of it.
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0