• Advertisement
Sign in to follow this  

This topic is 1983 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Ok this is just a quick question, I've solved it before and I have no idea what I did last time.

I'm trying to read text from a txt file, but every time I run the code, the first time it works perfectly, and then the second time it gives me a null pointer error on the line with the arrows. It will work again on the same file if I open it, backspace a character and then retype it and save.

Heres the code:
[CODE]
public void readFile() throws IOException{
InputStream stream = this.getClass().getResourceAsStream(filePath+fileName);
BufferedReader reader = new BufferedReader(new InputStreamReader(stream));

String line;

do{
//Read each line of the file
//Each line will correspond to separate entities. End characters will denote the end of an entity's data
//Each line will be read, 'decrypted' and then set into the elements ArrayList
line = reader.readLine();
lines.add(line);
System.out.println(line);
}while(!line.equals("-END_OF_STREAM-")); //<<<<<<<<<<
reader.close();
stream.close();
}
[/CODE]

Any help is much appreciated,
Thanks,
Peter

Share this post


Link to post
Share on other sites
Advertisement
i guess the file is still openend when u call your program the second time

Share this post


Link to post
Share on other sites
Just study the documentation of BufferedReader#readLine.

Share this post


Link to post
Share on other sites
I'm not a pro, but I would suggest not throwing that exception. You can gain some good debugging info if you print out a stacktrace.
Also, by dealing with the exceptions at the lowest level you don't have to keep throwing them... they will trickle right to the top of your code if you're not careful


Hope that helps somewhat.

Share this post


Link to post
Share on other sites
readLIne will return null if the end of the file is reached. That probably explains the NPE (NullPointerException) on the line you mentioned. Your code implies that you are expecting to encounter some specific text prior to reading the entire file; without seeing the contents of the file in question it's hard to tell if that condition should be being met. It appears that you have enough logging going on to see whether your termination text is found before the end of the file is reached.

Share this post


Link to post
Share on other sites
[quote name='mrhodes' timestamp='1344974758' post='4969583']
I'm not a pro, but I would suggest not throwing that exception. You can gain some good debugging info if you print out a stacktrace.[/quote]

In Java, exceptions come with a complete stacktrace right out of the box.

Share this post


Link to post
Share on other sites
are you by anychance editing the file after the first read?, just a hunch but maybe you are accidently editing the file after the first read, and when you try to read again it doesn't exactly follow the format it was just in, which would explain why you can run the program once fine, but then running the same program again will give you a null error until you manually go change the file.

Again just a hunch :-/

Share this post


Link to post
Share on other sites
I would suggest not using a do while loop and doing the following:

Instead of a do while loop, just make it a while loop :)

Eg:

[source lang="java"] public void readFile() throws IOException{
InputStream stream = this.getClass().getResourceAsStream(filePath+fileName);
BufferedReader reader = new BufferedReader(new InputStreamReader(stream));

String line;

while(!line.equals("-END_OF_STREAM-")){
//Read each line of the file
//Each line will correspond to separate entities. End characters will denote the end of an entity's data
//Each line will be read, 'decrypted' and then set into the elements ArrayList
line = reader.readLine();
lines.add(line);
System.out.println(line);
} //<<<<<<<<<<
reader.close();
stream.close();
}[/source]

Hope this works :)

~Ben

Share this post


Link to post
Share on other sites
[quote name='Bench3' timestamp='1345062717' post='4969935']
Hope this works [img]http://public.gamedev.net//public/style_emoticons/default/smile.png[/img][/quote]
Almost, the line variable is null so you can't invoke .equals without causing an NPE. You could choose to initialise the string to something other than the termination condition. Another way to go is to reverse the equality operands since equals() can correctly cope with null as a parameter, e.g.

[CODE]while(!"-END_OF_STREAM-".equals(line))[/CODE] Edited by dmatter

Share this post


Link to post
Share on other sites
Thank you guys for the help!
I had a program that was meant to write to the file that was running at the end of the game, and was messing up the formatting which caused the game not to recognize the END_OF_STREAM tag.

Thanks again,
Peter

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement