• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
stitchs_login

What methods should my destructor contain?

6 posts in this topic

Hello,

This is just a quick question but it has been bugging me a while. I have a GameEngine class (probably should be renamed to something less Grande). I have it set so that, before it does all the standard stuff like deleting pointers, destroying bitmaps, it saves the current game. Snippet below:
[source lang="cpp"]GameEngine::~GameEngine(void)
{
_SaveData("GameData.txt", a_PlayerOne->f_GetScore(), a_PlayerTwo->f_GetScore());
// For every new/BITMAP*, there must be a matching delete/destroy.
delete a_Grid;
delete a_PlayerOne;
delete a_PlayerTwo;
destroy_bitmap(a_PlayerO);
destroy_bitmap(a_PlayerX);
// TODO: (Shape that appears underneath cursor
/*if(shapeCursor != NULL){
destroy_bitmap(shapeCursor);
}*/
destroy_bitmap(temp); // TODO:
destroy_bitmap(a_Buffer);
}[/source]
Is this the correct thing I should be doing, or should I make an explicit call to it in the code, before the destructor is run? Are there any dangers of leaving it until the class destructs?

Regards,

Stitchs.
0

Share this post


Link to post
Share on other sites
Thanks for the swift responses. I had a feeling that how I had done it was incorrect, I just wanted to double check and couldn't word my question correctly in a net search.

I'll move into implementing some sort of close-down function that is called independently of the destructor.

Regards,

Stitchs
0

Share this post


Link to post
Share on other sites
What you did wasn't incorrect, its just bad practice effectively. As its already been pointed out, if I was to use your class, I would not expect when it went out of scope/or I deleted it, that it would save a game file. My port of call is to create classes as if they are intended to be used by someone else, unless of course, those classes will never be used by someone else. If that makes any lick of sense .... hmm. Edited by theark
2

Share this post


Link to post
Share on other sites
[quote name='theark' timestamp='1346623333' post='4975846']
As its already been pointed out, if I was to use your class, I would [color=#ff0000][b]not[/b][/color] expect when it went out of scope/or I deleted it, that it would save a game file.
[/quote]
[size=2](Corrected, to avoid potential confusion from the missing word)[/size]
1

Share this post


Link to post
Share on other sites
[quote name='Servant of the Lord' timestamp='1346624496' post='4975856']
[quote name='theark' timestamp='1346623333' post='4975846']
As its already been pointed out, if I was to use your class, I would [color=#ff0000][b]not[/b][/color] expect when it went out of scope/or I deleted it, that it would save a game file.
[/quote]
[size=2](Corrected, to avoid potential confusion from the missing word)[/size]
[/quote]

Thanks, must have missed that when reading it back. :)
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0