• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
SeraphLance

Parallel-for woes

7 posts in this topic

So for quite some time I'd been writing a noise/fractal library, and today I decided to revisit it after a many-months break. The first thing I realized was that Perlin noise generation, being a pure function, ought to be embarrassingly parallel. Not having any experience whatsoever in parallelism, I get some weird results I'm having trouble fixing:

[img]http://img525.imageshack.us/img525/2057/parallelnoise.png[/img]

The artifacts in the left image are randomly placed each run, and with varying degrees of severity.

The code behind my for-loop is pretty straightforward:
[CODE]
Color[] noisegen(Racket.Module basis)
{
Color[] ret = new Color[col.Length];
int colx, coly;
//sequential
float d;
for (int i = 0; i < col.Length; i++)
{
colx = i % img.Width;
coly = i / img.Width;
d = (float)(basis.Get((colx + xtrans) / (double)img.Width, (coly + ytrans) / (double)img.Width));
ret[i] = new Color(d, d, d);
}
//end-sequential
//Parallel.For(0, col.Length, (i) =>
//{
// float d;
// colx = i % img.Width;
// coly = i / img.Width;
// d = (float)(basis.Get((colx + xtrans) / (double)img.Width, (coly + ytrans) / (double)img.Width));
// ret[i] = new Color(d, d, d);
//});
return ret;
}
[/CODE]

I'm not going to post the actual perlin noise function (noted here as basis.Get(...) ) for space economy reasons, but I'm pretty sure it's pure functional. It's pretty much a facelift of Perlin's "improved" 2002 implementation.

I really have no idea what's going on when I use my parallel implementation instead of my sequential one. Is it that the function is returning before some of the threads finish execution? Are parallel for loops not guaranteed to evaluate everything? I feel like I'm missing something very simple.
0

Share this post


Link to post
Share on other sites
It's hard to see the artifacts in the screenshot.

There doesn't [i]look[/i] to be any issues here. My first guess would be some issue due to interaction with GDI/forms.
0

Share this post


Link to post
Share on other sites
I'd say approx 1/8th of the way across the screen from the right edge half way from the top theres a little white dot.
0

Share this post


Link to post
Share on other sites
I scaled down the image to avoid covering up the entire forum post. There's like 50 white pixels, mostly located in the top right. There's no real bias for where they are, it only happens to be that way in that particular image. It seems visible to me, even on this crappy laptop, but I'm the one that uploaded it after all. If you want a larger side-by-side, I can upload it tonight.

EDIT: I should add it becomes a lot more noticeable if you click to enlarge it. Edited by SeraphLance
0

Share this post


Link to post
Share on other sites
I saw some of that, but regardless there's nothing really in the code you posted that would influence that.

[edit: dmatter is more observant than I] Edited by Telastyn
0

Share this post


Link to post
Share on other sites
[quote name='dmatter' timestamp='1346866038' post='4976901']
Looks like you're sharing colx and coly between all the threads, creating a race condition. Try making those variables local within the lambda.
[/quote]
That's exactly the kind of thing I figured it'd be. I already fixed that with the d float, but hadn't noticed colx and coly. I'll fix those tonight and see if that solves the problem. Thanks.

EDIT: That fixed the problem. I'd figured it was related to some shared data, but I was having trouble finding it. Thanks again for the help! Edited by SeraphLance
0

Share this post


Link to post
Share on other sites
[quote name='SeraphLance' timestamp='1346865007' post='4976894']
There's like 50 white pixels, mostly located in the top right.
[/quote]I see them now, seems to be a mix of my zoom level and screen res they almost blended in, zooming them to be completely fullscreened I see what you mean. Good that you've fixed it though
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0