• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Carradine

Copying partial data from/to a class, any problems?

2 posts in this topic

I have my game running as a client/server architecture and I am sending data from one to the other. I am now optimizing the data I send over the network and I am currently doing this:

I have a class set up like so:

[source lang="cpp"]class temp
{
int a;
BOOL b;
int c;

foo * d1;
foo2 * d2;

CString eStr;
CString fStr;
};[/source]
And the identical class on both the client and server.
I am sending variables a,b, and c as one struct, and I send the other CString data in their own packets for now.
Initially, I was sending each variable over as a packet, now I am sending data over in structs. I was sending these "base" data types (a,b,c) over as a struct by putting them in their own struct like so:

[source lang="cpp"]class temp
{
struct _baseValues
{
int a;
BOOL b;
int c;
}


foo * d1;
foo2 * d2;

Cstring eStr;
CString fStr;
};[/source]

And sending it over in a char array like so:

[source lang="cpp"]LPTSTR aStr = convStr.GetBufferSetLength(sizeof(temp::_baseValues));
memcpy( (void*)aStr, (char*)pStr, sizeof(temp::_baseValues) );[/source]
However my question is that is it simpler for me to ignore creating another struct for my base values, and just send the data over in the original class setup (the first class in this post ) and copying it over like so:

[source lang="cpp"]LPTSTR aStr = convStr.GetBufferSetLength(12);
memcpy( (void*)aStr, (char*)pStr, 12 );[/source]

and reading it in on the client like this:
[source lang="cpp"]memcpy( (void*)tempObj, (LPCTSTR)packetCharStr, 12 );[/source]
Everything works fine, but my question is, except for the fact I have to enter a manual size for the data sizes for the conversions, could this cause any problems? Aside I have to watch the order of which I place members in the class, and not worry about endian problems from different operating systems, is this acceptable? Or could I have some random memory problems doing this?

I can go back to putting the base values (a,b,c) back into a struct, but this does seem a bit simpler, and I won't have to do a large code overhaul.

Thanks
0

Share this post


Link to post
Share on other sites
So you have a version that automatically handles alignment, padding, changing the content of the structs, etc... and one version with tons of magic numbers that is most likely going to break with the slightest code change or even just compiling for 64bit and is a maintenance nightmare.

Don't confuse "it's less typing" with "it's easier".

Apart from that, all the cstring and memory fiddling would make me extremely nervous and look for a safer way to do it. Especially abusing "strings" as raw data buffers.

For situations where classes need to save/send themselves they usually know how to serialize themselves. At least it's a keyword that should provide plenty of common approaches.
0

Share this post


Link to post
Share on other sites
I knew that when I was doing this it was feeling a bit "dirty" but i couldn't quite put my finger on it. Thanks.
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0