• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
wqking

Messy unit tests, rewrite or keep them and add substitutes?

1 post in this topic

I have a C++ library, and I will develop and maintain it for quite long time (at least several years).
So robust unit tests are very important to back up the library quality.

Now there are more than 600 unit test cases, 21000 LOC. Note some test cases are really large, not small cases.
Currently the unit tests are a little messy, because I wrote most them when I didn't have much experience on unit testing (still not for now :( ).

Two biggest problems are,
1, The unit tests don't cover all or most code. That's not because of there are not enough unit test, but the unit test structure is a little wrong.
2, I'm a lazy developer and always want to find easy way to do my work. So a lot of unit tests are coupled together via common code, which is not fine for unit test, IMHO.

My question is, should I rewrite the whole unit tests, or keep current unit tests there and add a complete new unit test system?
I don't think current unit test code base can be reused in new unit tests because the current unit test structure/organization is not very good. I need to restructure them.
0

Share this post


Link to post
Share on other sites
[quote name='wqking' timestamp='1348383368' post='4982836']
My question is, should I rewrite the whole unit tests, or keep current unit tests there and add a complete new unit test system?[/quote]
Life is too short to spend time rewriting unit tests. Enjoy time writing new fun exciting bits of code instead.

[quote]
I don't think current unit test code base can be reused in new unit tests because the current unit test structure/organization is not very good. I need to restructure them.
[/quote]
Then keep the tests you have, and enhance them with new tests for the new aspects of the code you write. Unit tests can exist in more than one executable. The only real time it's worth doing any serious refactoring work on tests, is if you need to change the framework for better test reporting. So if you are convinced that rewriting your unit tests is a good idea, I'd recommend that you first set up a CI/build server (somethink like jenkins for example). AT least you'd know then, that the refactoring work you do, will probably be the last time you ever need to do that (well, probably not the last, but should be good for 5 years or more).

[quote]So a lot of unit tests are coupled together via common code, which is not fine for unit test, IMHO.[/quote]
If the common code is reliable (i.e. tests exist for it), then there is nothing wrong with that approach.

[quote]The unit tests don't cover all or most code. That's not because of there are not enough unit test, but the unit test structure is a little wrong.[/quote]
Code coverage tools will help you identify any untested code paths, although generally, the law of diminishing returns applies once you get past 80% coverage or so. Edited by RobTheBloke
1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0