• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Plaristote

A prepare that segfault

1 post in this topic

Yello !

I'm fixing some pretty serious bugs in my application, and there's only a single one left. I have literally not a single clue nor anything that remotely looks like a clue about what's happening. It's all very very weird to me.

I'm almost certain that no one can help me and that I'm doomed. I really don't see how this happened, given that valgrind certified that my application is clean. I have a single error, and that's the one that crashes the game:

[CODE]==16527== Invalid read of size 4
==16527== at 0x4FEED5D: asCContext::Prepare(asIScriptFunction*) (in /usr/lib/libangelscript-2.23.1.so)
==16527== by 0x81263EC: StatController::TraitToggled(std::string const&) (statsheet.cpp:270)
==16527== by 0x81327C3: Observatory::Signal<void (std::string const&)>::Observer<StatController>::operator()(std::string const&) (in /home/plaristote/Work/fallout-equestria/build/game)
==16527== by 0x811F0A2: Observatory::Signal<void (std::string const&)>::Emit(std::string const&) (observatory.hpp:196)
==16527== by 0x812B963: StatViewRocket::TraitClicked(Rocket::Core::Event&) (statsheet.cpp:891)
==16527== by 0x813276F: Observatory::Signal<void (Rocket::Core::Event&)>::Observer<StatViewRocket>::operator()(Rocket::Core::Event&) (in /home/plaristote/Work/fallout-equestria/build/game)
==16527== by 0x811DE0E: Observatory::Signal<void (Rocket::Core::Event&)>::Emit(Rocket::Core::Event&) (observatory.hpp:196)
==16527== by 0x811D2B4: RocketListener::ProcessEvent(Rocket::Core::Event&) (rocket_extension.hpp:10)
==16527== by 0x4E04059: Rocket::Core::EventDispatcher::TriggerEvents(Rocket::Core::Event*) (in /usr/lib/libRocketCore.so.1.2.1)
==16527== by 0x4E0428C: Rocket::Core::EventDispatcher::DispatchEvent(Rocket::Core::Element*, Rocket::Core::StringBase<char> const&, Rocket::Core::Dictionary const&, bool) (in /usr/lib/libRocketCore.so.1.2.1)
==16527== by 0x4E4355A: Rocket::Core::Element::DispatchEvent(Rocket::Core::StringBase<char> const&, Rocket::Core::Dictionary const&, bool) (in /usr/lib/libRocketCore.so.1.2.1)
==16527== by 0x4E35119: Rocket::Core::Context::ProcessMouseButtonUp(int, int) (in /usr/lib/libRocketCore.so.1.2.1)
==16527== Address 0xd3e7560 is 0 bytes inside a block of size 332 free'd
==16527== at 0x402A45C: free (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==16527== by 0x5020EB5: asCScriptFunction::Release() const (in /usr/lib/libangelscript-2.23.1.so)
==16527== by 0x501431F: asCScriptEngine::CallObjectMethod(void*, asSSystemFunctionInterface*, asCScriptFunction*) (in /usr/lib/libangelscript-2.23.1.so)
==16527== by 0x50143D9: asCScriptEngine::CallObjectMethod(void*, int) (in /usr/lib/libangelscript-2.23.1.so)
==16527== by 0x4FF2D47: asCGarbageCollector::DestroyOldGarbage() (in /usr/lib/libangelscript-2.23.1.so)
==16527== by 0x4FF387F: asCGarbageCollector::AddScriptObjectToGC(void*, asCObjectType*) (in /usr/lib/libangelscript-2.23.1.so)
==16527== by 0x5023291: asCScriptFunction::asCScriptFunction(asCScriptEngine*, asCModule*, asEFuncType) (in /usr/lib/libangelscript-2.23.1.so)
==16527== by 0x4FF7D30: asCModule::AddScriptFunction(int, int, char const*, asCDataType const&, asCDataType*, asETypeModifiers*, asCString**, int, bool, asCObjectType*, bool, bool, bool, bool, bool, bool, asCString const&) (in /usr/lib/libangelscript-2.23.1.so)
==16527== by 0x4FA5400: asCBuilder::RegisterScriptFunction(int, asCScriptNode*, asCScriptCode*, asCObjectType*, bool, bool, asCString const&, bool) (in /usr/lib/libangelscript-2.23.1.so)
==16527== by 0x4FAAC9A: asCBuilder::RegisterNonTypesFromScript(asCScriptNode*, asCScriptCode*, asCString const&) (in /usr/lib/libangelscript-2.23.1.so)
==16527== by 0x4FAB1DB: asCBuilder::ParseScripts() (in /usr/lib/libangelscript-2.23.1.so)
==16527== by 0x4FAB639: asCBuilder::Build() (in /usr/lib/libangelscript-2.23.1.so)[/CODE]

Followed by an output that isn't from valgrind:
[CODE]pure virtual method called
terminate called without an active exception[/CODE]

It could be that the context is incorrect. So in doubt I created the context just before calling.
It could be that the function pointer is incorrect. So in doubt I re-loaded the function just before the calling as well.
I don't understand... what else could it be ?

I don't think this is relevant (I would have to post 30 000 lines of code to make it relevant, since the bug doesn't make sense at all... i guess), but here's the code that crashes:
[CODE]
void StatModel::ToggleTrait(const string& trait)
{
Data dtrait = _statsheet["Traits"][trait];
bool is_active = (!dtrait.Nil()) && dtrait == 1;
if (_scriptActivateTraits)
{
string tmp = trait;
bool updated;
_scriptContext = Script::Engine::Get()->CreateContext();
_scriptActivateTraits = _scriptModule->GetFunctionByDecl("bool ActivateTraits(Data, string, bool)");
_scriptContext->Prepare(_scriptActivateTraits);
_scriptContext->SetArgObject(0, &_statsheet);
_scriptContext->SetArgObject(1, &tmp);
_scriptContext->SetArgByte(2, !is_active);
_scriptContext->Execute();
if (_scriptContext->GetReturnByte())
UpdateAllValues();
_scriptContext->Release();
}
}[/CODE]

I'll take any advice on how to debug this.
0

Share this post


Link to post
Share on other sites
It looks a bit odd that you first check if _scriptActivateTraits is true (or not null), then overwrite it with another function pointer. Is that logically correct?

The crash is happening because the asIScriptFunction pointer passed to Prepare() has already been released and destroyed. Is perhaps _scriptActivateTraits a smart pointer that releases the previous asIScriptFunction pointer when the new pointer is assigned? The asIScriptFunction pointer received from GetFunctionByDecl shouldn't be released, unless you manually call AddRef first.

Anyway, I suggest you set a memory breakpoint on the asIScriptFunction pointer that is freed and then accessed by Prepare. That ought to give you a clue where things is going wrong.

Regards,
Andreas
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0