• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
JohnnyCode

desperate on javascript issue

8 posts in this topic

Hi,

I have implemented a 'class' in javascript like this
[CODE]
function CMesh()
{
this.m_faVerticies=new Array();
this.m_fWorld=new Array();
this.m_fFile;
CMesh.prototype.FeedAFile = function(uri) {
// code

var xmlhttp=new XMLHttpRequest();

xmlhttp.onreadystatechange=function()
{
if (xmlhttp.readyState==4 && xmlhttp.status==200)
{
var bytes = xmlhttp.responseBody;

this.m_fFile= bytes.toArray();
this.m_faVerticies = new Array();
var n=0;
for (var i = 0; i < this.m_fFile.length; i=i+4)
{
var fl=decodeFloat(i,this.m_fFile, 1, 8, 23, -126, 127, true);
this.m_faVerticies[n]=fl;
n++;
}
alert( this.m_faVerticies.length+'A');// ALERTS CORRECT VALUE-9A
}
}
xmlhttp.open("GET",uri,false);

xmlhttp.send();

}
}
[/CODE]
If I call this function - FeedAFile, on an instance, I get from my debug alert "9A", which is correct.
but If I read the member m_faVerticies on a next alert(), all hapyness is gone
[CODE]
mesh=new CMesh();
mesh.FeedAFile('onefloat.bin');// THE FUNCTION ALERTS '9A'
alert(mesh.m_faVerticies.length); // THIS FOLLOWING ALERT OUTPUTS 0
[/CODE]
I have no idea as where the member .m_faVerticies changed. Have I implemented the class with a public variable incorrectly?

Thanks in advance
0

Share this post


Link to post
Share on other sites
I'm not a JS guru.
I can only guess that you assign m_faVerticies to a wrong object than mesh.
Can you alert value "this" inside of FeedAFile and value "mesh" outside of FeedAFile?
1

Share this post


Link to post
Share on other sites
[quote name='wqking' timestamp='1349057270' post='4985615']
Can you alert value "this" inside of FeedAFile and value "mesh" outside of FeedAFile?
[/quote]
Thanks , but this will alert only the object type, not something like poiner value or so
0

Share this post


Link to post
Share on other sites
I tested your code (cut down version) and seems m_faVerticies is assigned to correct object.
So there must be some other reasons.
1

Share this post


Link to post
Share on other sites
thanks very much. .... interesting
was it alerting 0 or more? Also I did'nt provide defintion for decodeFloat(i,this.m_fFile, 1, 8, 23, -126, 127, true); so then you perhaps defined it to return just constant float. (I am not on a PC with source right now, cannot post the definition, but I think I will work around and test the code by altering it, I will try add floats to array by hand and so on)
I was on Win 7 64bit, ie 9. What browser and OS have you got? Thank you for your effort, I hope you find this code usefull.
0

Share this post


Link to post
Share on other sites
I have to comment out some code to make it run.
The two alerts are "3A" and "3", so they are correct.
I tested on WinXP, in both IE 8 and FireFox 12.
[source lang="xml"]<html>
<head></head>
<body>
<script>
function CMesh()
{
this.m_faVerticies=new Array();
this.m_fWorld=new Array();
this.m_fFile;
CMesh.prototype.FeedAFile = function(uri) {
// code
// var xmlhttp=new XMLHttpRequest();

// xmlhttp.onreadystatechange=function()
{
if (1)
{
// var bytes = xmlhttp.responseBody;
// this.m_fFile= bytes.toArray();
this.m_faVerticies = new Array();
var n=0;
for (var i = 0; i < 9; i=i+4)
{
var fl=1;
this.m_faVerticies[n]=fl;
n++;
}
alert( this.m_faVerticies.length+'A');// ALERTS CORRECT VALUE-9A
}
}
// xmlhttp.open("GET",uri,false);
// xmlhttp.send();
}
}
mesh=new CMesh();
mesh.FeedAFile('onefloat.bin');
alert(mesh.m_faVerticies.length);
</script>
</body>
</html>
[/source] Edited by wqking
1

Share this post


Link to post
Share on other sites
Maybe try to place the public function FeedAFile() outside the class definition. Not sure if this will make any difference, I've always placed the public functions outside the class definition. Functions inside the class defintion(that are not prototype) are still public from what I remember but they can also access and change private variables.

[CODE]
function CMesh()
{
this.m_faVerticies=new Array();
this.m_fWorld=new Array();
this.m_fFile;

var privateVar = 1;
// This maybe incorrect but I think ONLY the following
// type of functions can be inside the class declaration
this.MyFunction = function(foo) {
// access and change private and public variables
}
}

CMesh.prototype.FeedAFile = function(uri) {
// code
var xmlhttp=new XMLHttpRequest();

xmlhttp.onreadystatechange=function()
{
if (xmlhttp.readyState==4 && xmlhttp.status==200)
{
var bytes = xmlhttp.responseBody;
this.m_fFile= bytes.toArray();
this.m_faVerticies = new Array();
var n=0;
for (var i = 0; i < this.m_fFile.length; i=i+4)
{
var fl=decodeFloat(i,this.m_fFile, 1, 8, 23, -126, 127, true);
this.m_faVerticies[n]=fl;
n++;
}
alert( this.m_faVerticies.length+'A');// ALERTS CORRECT VALUE-9A
}
}
xmlhttp.open("GET",uri,false);
xmlhttp.send();
}
[/CODE] Edited by gretty
0

Share this post


Link to post
Share on other sites
This code looks very fishy ...
[quote name='JohnnyCode' timestamp='1349053840' post='4985587']
[CODE]
function CMesh() {
this.m_faVerticies=new Array();
// etc

CMesh.prototype.FeedAFile = function(uri) {
var xmlhttp=new XMLHttpRequest();
xmlhttp.onreadystatechange=function() { // lambda function
// cut
this.m_fFile= bytes.toArray();
// cut
}
}
}
[/CODE]
[/quote]
1. take CMesh.prototype.FeedAFile out of the class "constructor". You are needlessly reassigning the prototype function with every new object - it is unnecessary. Every new object will inherit the same function from the prototype chain anyway - that is what prototype is for.
2. "this.m_fFile" in the lambda function will point to the lambda function itself - which does not have any of the CMesh properties (edit: ie, all of the data will be thrown away the moment "FeedAFile" function ends).

Something like:
[CODE]
function CMesh() {
this.m_faVerticies=new Array();
// etc
}
CMesh.prototype.FeedAFile = function(uri) {
var xmlhttp=new XMLHttpRequest();
var that = this; // because closure is fun - aka, we want to give the lambda function access to "this" of the CMesh object.
xmlhttp.onreadystatechange=function() { // lambda function
// cut
that.m_fFile= bytes.toArray(); // notice "that" instead of "this".
// cut
}
}
[/CODE] Edited by tanzanite7
1

Share this post


Link to post
Share on other sites
[quote name='tanzanite7' timestamp='1349293997' post='4986512']
2. "this.m_fFile" in the lambda function will point to the lambda function itself - which does not have any of the CMesh properties (edit: ie, all of the data will be thrown away the moment "FeedAFile" function ends).

Something like:
[CODE]
function CMesh() {
this.m_faVerticies=new Array();
// etc
}
CMesh.prototype.FeedAFile = function(uri) {
var xmlhttp=new XMLHttpRequest();
var that = this; // because closure is fun - aka, we want to give the lambda function access to "this" of the CMesh object.
xmlhttp.onreadystatechange=function() { // lambda function
// cut
that.m_fFile= bytes.toArray(); // notice "that" instead of "this".
// cut
}
}
[/CODE]
[/quote]
Very good spot.
Though I rarely used JS, I used Flash AS3 a lot which is quite JS like. In AS3 the "this" in a closure is also quite tricky.
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0