• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
simpler

If statement weird behavior

7 posts in this topic

In my HLSL shader code I'm checking if an bool effect parameter is true or not. I get really weird results and can't see any logic in it at all. Here's what happens,

With 100 skinned meshes that uses normal mapping my game runs at around 24fps, without normal mapping it's around 130fps. I want to make normal mapping optional so I therefor added an effect parameter (gUseNormalMap) that decides if it should be used or not.

I did this for testing:

[CODE]
cbuffer cbPerObject
{
bool gUseNormalMap;
}

...

if(gUseNormalMap)
{
float3 normalMapSample = gNormalMap.Sample(samLinear, pin.Tex).rgb;
pin.NormalW = NormalSampleToWorldSpace(normalMapSample, pin.NormalW, pin.TangentW);
}
else
return float4(0, 1, 0, 1);
[/CODE]

If I set gUseNormalMap to true the fps is ~24 like it should be, but when I set it to false the fps still is 24 which it shouldn't be without normal mapping. What's makes it more weird is that the color of the mesh is green and that's correct since the else statement returns float4(0, 1, 0, 1). [u]It's like both bodies of the if statement runs when gUseNormalMap is = false.[/u]

I also tested without using the effect parameter,

[CODE]// Use normal mapping?
bool normalMapping = false;
if(normalMapping)
{
float3 normalMapSample = gNormalMap.Sample(samLinear, pin.Tex).rgb;
pin.NormalW = NormalSampleToWorldSpace(normalMapSample, pin.NormalW, pin.TangentW);
}
else
return float4(0, 1, 0, 1);[/CODE]

but that gives the expected output. I hope I was clear enough and that someone knows what's going on!
0

Share this post


Link to post
Share on other sites
Hmm maybe an issue with the constant buffer in the c++ code? Also it might be better to have them as a separate effect? So that you don't have an if statement per pixel.
2

Share this post


Link to post
Share on other sites
Evaluating an if statement takes many cycles -- it may be that the math inside [font=courier new,courier,monospace]NormalSampleToWorldSpace[/font] is just as expensive as the branch itself.

You'll have to use a GPU profiler rather than just looking at your frame-rate to see what's going on in detail.
2

Share this post


Link to post
Share on other sites
i keep wanting to think interpolation, but i dont even know if you're passing it through the vertex shader or not lol
0

Share this post


Link to post
Share on other sites
Thanks for the replies! I haven't got it to work but I'm probably just going to add a separate technique that uses a pixel shader containing the normal mapping instead. But that means I will copy and paste a lot of code which feels stupid. I'm not that experienced with HLSL so I don't really know the workflow of it, maybe this is usual?

[quote name='Daniel_RT' timestamp='1350257838' post='4990189']
Hmm maybe an issue with the constant buffer in the c++ code? Also it might be better to have them as a separate effect? So that you don't have an if statement per pixel.
[/quote]

That means a lot of code duplicates, is it worth it just for one if-statement?

Also, where can I find out about exceptions in HLSL like the one MJP mentioned about that you cannot use Texture2D.Sample inside a branch? Edited by simpler
0

Share this post


Link to post
Share on other sites
[quote name='simpler' timestamp='1350516581' post='4991277']
But that means I will copy and paste a lot of code which feels stupid
[/quote]You can use #include and functions instead of copy&pasting.[quote]That means a lot of code duplicates, is it worth it just for one if-statement?[/quote]Most commercial game engines build tools that can compile a single source file into many different shaders (to remove branches, etc). A few years ago I wrote a terrain shader which the engine exploded into about 400 different pixel shaders, which it would select based on which features were required (e.g. material blending, normal mapping, etc). So, yeah, using many different variations of a similar shader is "normal".

On my last project we did something simpler, where I would write variations by hand like:
[code]//variation1.hlsl
#include "core.hlsl"

//variation2.hlsl
#define ENABLE_NORMAL_MAPPING
#include "core.hlsl"

//core.hlsl
...
#if defined(ENABLE_NORMAL_MAPPING)
return gNormalMap.Sample(samLinear, pin.Tex);
#else
return float4(0, 1, 0, 1);
#endif
...[/code] Edited by Hodgman
2

Share this post


Link to post
Share on other sites
My 2 cents

The following document, in one of its sections explains how to do conditional compilation.

[url="http://d3dcoder.net/Data/Resources/d3d11Metro.pdf"]http://d3dcoder.net/Data/Resources/d3d11Metro.pdf[/url]
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0