• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Enerjak

some help connecting different components in java's SWING framework.

5 posts in this topic

Ok, this is something that's been bothering me for awhile now. I'm trying to use swing to make a hardware store program. I'm using swing and i got a GUI all designed with multiple forms and everything but I can't seem to connect them together....Like I had a button that says "add item", clicking on it brings up the frame to add a new item but when it's filled it doesn't do crap......the code is too long to post in thread so i'm going to upload everything into a zip file and just tell you where to look. The problem seems to be in:

[CODE]
@Override
public void actionPerformed(ActionEvent arg0)
{
if(arg0.getSource() == this.OpenMI)
{
try
{
this.fileLoaded = this.LoadFile();
if(fileLoaded)
{
this.printData();
this.addDataToList();
}
}
catch(IOException e)
{

}
}

if(arg0.getSource() == this.newItemB)
{
AddItem newItem = new AddItem();
newItem.setVisible(true);
stock = new HardwareStock(40);
newItem.setStore(this);

this.HardwareDataTA.setText(stock.elementAt(1).toString());

}
}
}
[/CODE]

(the newM if statement works).

either the problem is in the AddItem's actionHandler or something on my part......I don't know.
0

Share this post


Link to post
Share on other sites
[url="http://mattgemmell.com/2008/12/08/what-have-you-tried/"]What have you tried[/url]?

I don't know what "newM if statement" you are referring to.

The first thing I notice is that you have a point in your code that silently swallows exceptions. Never, ever do this. At the very least, print something. In an interactive GUI application, you should inform the user there is a problem with the file.

Another thing I notice is that the logic for creating a new item doesn't [i]appear[/i] to save the idem anywhere - though possibly the call to setStore() is doing something funky. You seem to be creating a new stock object, and then setting the text to the second (first?) element, which may not be populated.

It is idiomatic in Swing to attach the event listeners directly to the component they are listening too. This is often done via an anonymous inner class. Doing it this way means that you don't have to determine the source of an event - it is implied.

For example:
[code]
// In the setup method:

this.OpenMI.addActionListener(new ActionListener() {
@Override
public void actionPerformed(ActionEvent arg0)
{
try
{
this.fileLoaded = this.LoadFile();
if(fileLoaded)
{
this.printData();
this.addDataToList();
}
}
catch(IOException e)
{
// TODO: improve me!
e.printStackTrace();
}
}
});

this.newItemB.addActionListener(new ActionListener() {
@Override
public void actionPerformed(ActionEvent arg0)
{
AddItem newItem = new AddItem();
newItem.setVisible(true);
stock = new HardwareStock(40);
newItem.setStore(this);
this.HardwareDataTA.setText(stock.elementAt(1).toString());
}
});
[/code]
Moving the logic performed into a separate method or class is common, otherwise the method creating these inner classes starts getting very long:
[code]
this.OpenMI.addActionListener(new ActionListener() {
@Override
public void actionPerformed(ActionEvent arg0)
{
handleOpenMI();
}
});

this.newItemB.addActionListener(new ActionListener() {
@Override
public void actionPerformed(ActionEvent arg0)
{
handleNewItemB();
}
});
[/code]
0

Share this post


Link to post
Share on other sites
I'm really sorry cos I'd like to say it in a different way but I can't: that code is a BIG pile of SHITE.

Try reading a book like "Clean Code" by Robert C. Martin or "The Art of Readable Code" by Boswell & Foucher.

Anyway, the new item is inserted. It can be checked with the code in HardwareStock class:
[source lang="java"]
public void insertEnd(HardwareItem item) {
if (numOfElements < m_items.length) {
m_items[numOfElements++] = item;
System.out.println("Item " + item.getItemName() + " added");
} else {
System.out.println("Cannot add to full list");
}
}
[/source]
that is called from HWStore class:
[source lang="java"]
public void addItem(HardwareItem i) {
stock.insertEnd(i);
}
[/source]
0

Share this post


Link to post
Share on other sites
the "newM" is a menu item to open the file dialog to get the file to load the data and print it. as you can see i create the stock after i load the file, but i suppose i could add a resize method for easy resizing.... like create a stock of 5 items but then resize it when necessary. Hmm,
0

Share this post


Link to post
Share on other sites
[quote name='ppgamedev' timestamp='1350773061' post='4992284']
I'm really sorry cos I'd like to say it in a different way but I can't: that code is a BIG pile of SHITE.

Try reading a book like "Clean Code" by Robert C. Martin or "The Art of Readable Code" by Boswell & Foucher.

Anyway, the new item is inserted. It can be checked with the code in HardwareStock class:
[source lang="java"]
public void insertEnd(HardwareItem item) {
if (numOfElements < m_items.length) {
m_items[numOfElements++] = item;
System.out.println("Item " + item.getItemName() + " added");
} else {
System.out.println("Cannot add to full list");
}
}
[/source]
that is called from HWStore class:
[source lang="java"]
public void addItem(HardwareItem i) {
stock.insertEnd(i);
}
[/source]
[/quote]

hey man, it's ok, i mostly write like that because MOST of the time i can understand it but yea i guess it's shit and not very professional.......I'm just used to doing this a certain way i guess. guess i need to change if i want to make it
0

Share this post


Link to post
Share on other sites
[quote name='rip-off' timestamp='1350772200' post='4992279']
[url="http://mattgemmell.com/2008/12/08/what-have-you-tried/"]What have you tried[/url]?

I don't know what "newM if statement" you are referring to.

The first thing I notice is that you have a point in your code that silently swallows exceptions. Never, ever do this. At the very least, print something. In an interactive GUI application, you should inform the user there is a problem with the file.

Another thing I notice is that the logic for creating a new item doesn't [i]appear[/i] to save the idem anywhere - though possibly the call to setStore() is doing something funky. You seem to be creating a new stock object, and then setting the text to the second (first?) element, which may not be populated.

It is idiomatic in Swing to attach the event listeners directly to the component they are listening too. This is often done via an anonymous inner class. Doing it this way means that you don't have to determine the source of an event - it is implied.

For example:
[code]
// In the setup method:

this.OpenMI.addActionListener(new ActionListener() {
@Override
public void actionPerformed(ActionEvent arg0)
{
try
{
this.fileLoaded = this.LoadFile();
if(fileLoaded)
{
this.printData();
this.addDataToList();
}
}
catch(IOException e)
{
// TODO: improve me!
e.printStackTrace();
}
}
});

this.newItemB.addActionListener(new ActionListener() {
@Override
public void actionPerformed(ActionEvent arg0)
{
AddItem newItem = new AddItem();
newItem.setVisible(true);
stock = new HardwareStock(40);
newItem.setStore(this);
this.HardwareDataTA.setText(stock.elementAt(1).toString());
}
});
[/code]
Moving the logic performed into a separate method or class is common, otherwise the method creating these inner classes starts getting very long:
[code]
this.OpenMI.addActionListener(new ActionListener() {
@Override
public void actionPerformed(ActionEvent arg0)
{
handleOpenMI();
}
});

this.newItemB.addActionListener(new ActionListener() {
@Override
public void actionPerformed(ActionEvent arg0)
{
handleNewItemB();
}
});
[/code]
[/quote]

good sir, best read i've had in awhile THANK YOU.
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0