• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
phil67rpg

storing random unique values in a vector

16 posts in this topic

I have done a lot of research on this problem. I am trying to store random values in a vector. I want to generate a random value from 1 to 9. Then I want to fill a vector with 5 unique random values. Then I want to output the values.
here is the code I am using.
[code]
#include <iostream>
#include <vector>
#include <algorithm>

using namespace std;

int main() {
vector<int> v;


for(int i=1;i<10;i++)
v.push_back(i);

random_shuffle(v.begin(), v.end());

for(vector<int>::iterator itr=v.begin(); itr != v.end(); ++itr)
cout << *itr << endl;


}
[/code]
basically this code takes the numbers from 1 to 9 and shuffles them and then outputs them.my question is how do I shuffle a sequence of random numbers that do not repeat. Let me know if you need more explanation.
0

Share this post


Link to post
Share on other sites
It looks like your code is doing what you expect; you feed in ten digits, shuffle them, and output the result.


Can you give some examples of input and output? What do you mean by "a sequence of random numbers that do not repeat" ? Individual digits frequently repeat themselves in random number sequences.
0

Share this post


Link to post
Share on other sites
[quote name='phil67rpg' timestamp='1353022588' post='5001385']How do I shuffle a sequence of random numbers that do not repeat[/quote]
Hi Phil,

By default, the seed used by the random number generator is set to a default value each time the program starts. This causes the same sequence of random numbers. You will need to reseed the random number generator before using it.

Use the [url=http://www.cplusplus.com/reference/clibrary/ctime/time/]time[/url] function under the [url=http://www.cplusplus.com/reference/clibrary/ctime/]ctime[/url] header to get the current time (number of seconds since the epoch), then use that to seed the random number generator using [url=http://www.cplusplus.com/reference/clibrary/cstdlib/srand/]srand[/url]:
[code]
srand( (unsigned)time(0) );
[/code] Edited by fastcall22
1

Share this post


Link to post
Share on other sites
What you have *shouldn't* repeat, except for one thing: You never seed the random number generator.

std::random_shuffle, if I recall correctly, uses rand() under the hood (unless you pass a different generator) - though I'm not sure if that changes for C++11, nor if it's standardized that rand() is default.

Since you never call srand(), rand() is seeded with 0 - thus the random shuffle repeats each time.
Instead, seed srand() with time(NULL) at the start of your program, and hopefully the result will be more suiting to your tastes.

[b][Edit:][/b] Three posts within 60 seconds of each other. =) Edited by Servant of the Lord
0

Share this post


Link to post
Share on other sites
[quote name='frob' timestamp='1353023115' post='5001387']
It looks like your code is doing what you expect; you feed in ten digits, shuffle them, and output the result.


Can you give some examples of input and output? What do you mean by "a sequence of random numbers that do not repeat" ? Individual digits frequently repeat themselves in random number sequences.
[/quote]
well I made some changes to my code.
input should be a random number from 1 to 9
output should be a list of random numbers that do not repeat.
such as: 3 7 8 9 1 2 5 4 6
[code]
#include <iostream>
#include <vector>
#include <algorithm>
#include <time.h>

using namespace std;

int main()
{
srand(time(NULL));

vector<int> v;

for(int i=1;i<10;i++)
{
int j=rand()%9+1;
v.push_back(j);
}

random_shuffle(v.begin(), v.end());

for(vector<int>::iterator itr=v.begin(); itr != v.end(); ++itr)
cout << *itr << endl;


}
[/code]


0

Share this post


Link to post
Share on other sites
[quote name='phil67rpg' timestamp='1353024355' post='5001393']
input should be a random number from 1 to 9
output should be a list of random numbers that do not repeat.
such as: 3 7 8 9 1 2 5 4 6
[/quote]
What's the connection between the input and the output? You want to only produce 9 different sequences?
0

Share this post


Link to post
Share on other sites
input should be a list of numbers from 1 to 9 generated randomly that can repeat
output should be a list of numbers from 1 to 9 that do not repeat
input: 1,3,4,2,1,5,5,9,8
output: 3,1,4,2,5,9,8
0

Share this post


Link to post
Share on other sites
[quote name='phil67rpg' timestamp='1353025941' post='5001405']
input should be a list of numbers from 1 to 9 generated randomly that can repeat
output should be a list of numbers from 1 to 9 that do not repeat
input: 1,3,4,2,1,5,5,9,8
output: 3,1,4,2,5,9,8
[/quote]
Your code should already do that. What is the current result that you are getting that you don't want?
Why does your input have non-unique variables? Where is this input coming from - the player or is it generated by your code?

Since we are all failing to understand, could you give a bigger-picture description of why you want this, and how you intend to use it?
0

Share this post


Link to post
Share on other sites
[quote name='phil67rpg' timestamp='1353025941' post='5001405']input should be a list of numbers from 1 to 9 generated randomly that can repeat
output should be a list of numbers from 1 to 9 that do not repeat
input: 1,3,4,2,1,5,5,9,8
output: 3,1,4,2,5,9,8[/quote]
If this is the case Phil, then you need to be generating a random set of integers from 1 to 9, not a sequence of integers from 1 to 9:
[code]
// v is always: 1 2 3 4 5 6 7 8 9 (no duplicates, ever)
for(int i=1;i<10;i++)
v.push_back(i);
random_shuffle(v.begin(),v.end()); // (elements might be in a random order, but there still aren't any duplicates)

// v could be: 9 1 8 6 7 4 6 3 2
for(int i=1;i<10;i++)
v.push_back( rand()%9 + 1 ); // (may have duplicates)
[/code]
(See the reference on [url=http://www.cplusplus.com/reference/clibrary/cstdlib/rand/]rand[/url]. [tt]rand()[/tt] returns an integer between 0 and [tt]RAND_MAX[/tt] -- usually 32767 -- and the modulus wraps that around the range between 0 and 8, and adding one brings it between 1 and 9.)

Then, you'll need to include [url=http://www.cplusplus.com/reference/algorithm/]algorithm[/url], such that you can use [url=http://www.cplusplus.com/reference/algorithm/sort/]sort[/url] to move duplicates together, then use [url=http://www.cplusplus.com/reference/algorithm/unique/]unique[/url] to move the duplicate values to the back. Once the unique values are in front, you can remove the duplicates from [tt]v[/tt] by using the iterator returned by [tt]unique[/tt]:
[code]
sort( v.begin(), v.end() );
v.erase( unique(v.begin(),v.end()), v.end() );
[/code]

Edit:
Hurr durr, I read can documentation good. Edited by fastcall22
1

Share this post


Link to post
Share on other sites
Unless I'm mistaken, std::unique only removes consecutive duplicates. That means a sequence like "1 2 1" is still completely possible. Or am I misunderstanding some constraint as well?
0

Share this post


Link to post
Share on other sites
[quote name='BitMaster' timestamp='1353066252' post='5001506']
Unless I'm mistaken, std::unique only removes consecutive duplicates. That means a sequence like "1 2 1" is still completely possible. Or am I misunderstanding some constraint as well?
[/quote]

I was thinking that too, but deferred since I'm too lazy to look it up.

...

Nope. Still too lazy. Sry
-1

Share this post


Link to post
Share on other sites
The easiest way to do it is to insert the numbers in a std::set (so there will be no duplicates), then copy to a std::vector and finally shuffle then.
0

Share this post


Link to post
Share on other sites
Yes, std::unique only handles consecutive duplicates. The input list could be sorted beforehand, or alternatively it could be changed to a std::set, preventing duplicates occurring in the first place.
1

Share this post


Link to post
Share on other sites
[quote name='BitMaster' timestamp='1353066252' post='5001506']
Unless I'm mistaken, std::unique only removes consecutive duplicates. That means a sequence like "1 2 1" is still completely possible.
[/quote]
Which is what I think the OP was wanting. His current method (generate array from 0 to 9, shuffle array) provides unique elements already.

If the OP *wants* repeats, but just not two in a row of the same number, std::unique would help with that.
Otherwise, I have no clue what the OP wants, since his original code already gives him only uniques.
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0