Sign in to follow this  
cozzie

unique texfile strings

Recommended Posts

cozzie    5029
Hi,

I'm strugging/ staring blind at a fairly simple 'issue'.

I have an array of strings and want to find out the number of unique strings, the strings are stored in tempTexFiles[]:

[source lang="cpp"] int pNrUniqueMaterials = 1;
bool NEW = false;
for(int texcount=1;texcount<pNrMaterials;++texcount)
{
for(int tlist=0;tlist<pNrMaterials;++tlist)
{
if(tempTexFiles[texcount] == tempTexFiles[tlist]) break;
else NEW = true;
}
if(NEW)
{
pNrUniqueMaterials++;
NEW = false;
}
}

mNrMaterials = pNrUniqueMaterials;
[/source]

Probably something to simple for words, been staring at it for an hour.

The results now is 5 and should be 3....

Any help is really appriciated.

greets,
Cris Edited by cozzie

Share this post


Link to post
Share on other sites
alvaro    21247
Can this be moved to General Programming or For Beginners? It has nothing to do with graphics...

Your algorithm is broken. As long as not all strings are identical, NEW will always be true and you will end up with pNrUniqueMaterials == pNrMaterials. A correct algorithm in the style of yours would go something like this:
[code] int pNrUniqueMaterials = 0;
for (int i = 0; i < pNrMaterials; ++i) {
if (std::find(tempTexFiles, tempTexFiles+i, tempTexFiles[i]) == tempTexFiles+i)
++pNrUniqueMaterials;
}
[/code]

If you have a large number of strings and this takes too long, you can do better, for instance by using an unordered_set. Edited by Álvaro

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this