Advertisement Jump to content
Sign in to follow this  
cozzie

unique texfile strings

This topic is 2259 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Hi,

I'm strugging/ staring blind at a fairly simple 'issue'.

I have an array of strings and want to find out the number of unique strings, the strings are stored in tempTexFiles[]:

[source lang="cpp"] int pNrUniqueMaterials = 1;
bool NEW = false;
for(int texcount=1;texcount<pNrMaterials;++texcount)
{
for(int tlist=0;tlist<pNrMaterials;++tlist)
{
if(tempTexFiles[texcount] == tempTexFiles[tlist]) break;
else NEW = true;
}
if(NEW)
{
pNrUniqueMaterials++;
NEW = false;
}
}

mNrMaterials = pNrUniqueMaterials;
[/source]

Probably something to simple for words, been staring at it for an hour.

The results now is 5 and should be 3....

Any help is really appriciated.

greets,
Cris Edited by cozzie

Share this post


Link to post
Share on other sites
Advertisement
Can this be moved to General Programming or For Beginners? It has nothing to do with graphics...

Your algorithm is broken. As long as not all strings are identical, NEW will always be true and you will end up with pNrUniqueMaterials == pNrMaterials. A correct algorithm in the style of yours would go something like this:
int pNrUniqueMaterials = 0;
for (int i = 0; i < pNrMaterials; ++i) {
if (std::find(tempTexFiles, tempTexFiles+i, tempTexFiles) == tempTexFiles+i)
++pNrUniqueMaterials;
}


If you have a large number of strings and this takes too long, you can do better, for instance by using an unordered_set. Edited by Álvaro

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
×

Important Information

By using GameDev.net, you agree to our community Guidelines, Terms of Use, and Privacy Policy.

GameDev.net is your game development community. Create an account for your GameDev Portfolio and participate in the largest developer community in the games industry.

Sign me up!