Sign in to follow this  
Followers 0
PAndersson

OpenGL
Cube map troubles

8 posts in this topic

Hey all, I'm having a bit of trouble trying to get a cubemap to work with OpenGL and GLSL. It seems to upload it just fine, at least GlIntercept outputs the cubemap texture in the way I would expect it too. However, when I try to sample the texture all I seem to get is just plain black no matter which coordinates I use to sample. The source texture has essentially no black at all.

I have been tearing my hair over this for the past few days and I'm wondering if any of you could spot the likely stupid mistake I've made?

Texture loading code:
[source lang="cpp"]namespace
{

SDL_Surface* createCubeMapFace(SDL_Surface* in, int faceStartX, int faceStartY, int width, int height)
{
#if SDL_BYTEORDER == SDL_LIL_ENDIAN
SDL_Surface* bufferSurface = SDL_CreateRGBSurface(0, width, height, 32, 0x000000FF, 0x0000FF00, 0x00FF0000, 0xFF000000);

#else
SDL_Surface* bufferSurface = SDL_CreateRGBSurface(0, width, height, 32, 0xFF000000, 0x00FF0000, 0x0000FF00, 0x000000FF);
#endif

SDL_Rect rect;

rect.w = width;
rect.h = height;
rect.x = faceStartX;
rect.y = faceStartY;

SDL_Rect dest;
dest.x = 0;
dest.y = 0;

SDL_FillRect(bufferSurface, &dest, SDL_MapRGBA(bufferSurface->format, 0, 0xFF, 0, 0xFF));
SDL_BlitSurface(in, &rect, bufferSurface, &dest);

return bufferSurface;

}

void uploadCubeMapFace(GLenum cubeMapFace, SDL_Surface* face, bool generateMipMaps)
{
glTexImage2D(cubeMapFace, 0, GL_RGBA, face->w, face->h, 0, GL_RGBA, GL_UNSIGNED_BYTE, face->pixels );
tryLogError();
if (generateMipMaps) gluBuild2DMipmaps(cubeMapFace, GL_RGBA, face->w , face->h, GL_RGBA,GL_UNSIGNED_BYTE, face->pixels);
tryLogError();
}

GLuint uploadFaceSet(SDL_Surface*left,
SDL_Surface* front,
SDL_Surface* right,
SDL_Surface* far,
SDL_Surface* top,
SDL_Surface* bottom,
bool mipmapped)
{

GLuint id;
glGenTextures(1, &id);

glEnable(GL_TEXTURE_CUBE_MAP);
glBindTexture(GL_TEXTURE_CUBE_MAP, id);
tryLogError();

// Upload texture
glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_WRAP_S, GL_MIRRORED_REPEAT);
glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_WRAP_T, GL_MIRRORED_REPEAT);
glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_WRAP_R, GL_MIRRORED_REPEAT);
glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_MAG_FILTER, GL_LINEAR);
glTexParameteri(GL_TEXTURE_CUBE_MAP, GL_TEXTURE_MIN_FILTER, GL_LINEAR_MIPMAP_LINEAR);

//Create cube map
uploadCubeMapFace(GL_TEXTURE_CUBE_MAP_NEGATIVE_X, left, mipmapped);
uploadCubeMapFace(GL_TEXTURE_CUBE_MAP_POSITIVE_Z, front, mipmapped);
uploadCubeMapFace(GL_TEXTURE_CUBE_MAP_POSITIVE_X, right, mipmapped);
uploadCubeMapFace(GL_TEXTURE_CUBE_MAP_NEGATIVE_Z, far, mipmapped);
uploadCubeMapFace(GL_TEXTURE_CUBE_MAP_POSITIVE_Y, top, mipmapped);
uploadCubeMapFace(GL_TEXTURE_CUBE_MAP_NEGATIVE_Y, bottom, mipmapped);

glBindTexture(GL_TEXTURE_CUBE_MAP, 0);
return id;
}
// Loads a Texture into VideoRAM and returns a texture id
GLuint loadCubeMapTextureIntoVRAM(Image* image, bool generateMipMaps)
{

assert(image->getWidth() % 4 == 0);
assert(image->getHeight() % 3 == 0);
assert(image->getWidth()/4 == image->getHeight()/3);

int sideWidth = image->getWidth()/4;
int sideHeight = image->getHeight()/3;

auto left = createCubeMapFace(image->getInternalSurface(), sideWidth*0, sideHeight*1, sideWidth, sideHeight);
auto front = createCubeMapFace(image->getInternalSurface(), sideWidth*1, sideHeight*1, sideWidth, sideHeight);
auto right = createCubeMapFace(image->getInternalSurface(), sideWidth*2, sideHeight*1, sideWidth, sideHeight);
auto far = createCubeMapFace(image->getInternalSurface(), sideWidth*3, sideHeight*1, sideWidth, sideHeight);
auto top = createCubeMapFace(image->getInternalSurface(), sideWidth*1, sideHeight*0, sideWidth, sideHeight);
auto bottom = createCubeMapFace(image->getInternalSurface(), sideWidth*1, sideHeight*2, sideWidth, sideHeight);

auto retVal = uploadFaceSet(left,
front,
right,
far,
top,
bottom,
generateMipMaps);
SDL_FreeSurface(left);
SDL_FreeSurface(front);
SDL_FreeSurface(right);
SDL_FreeSurface(far);
SDL_FreeSurface(top);
SDL_FreeSurface(bottom);

return retVal;

}
}[/source]

Code used to sent the cubemap id to the shader program, I have checked that the id is correct and that the part of the of the code is executed as it should as well as having a unique sampler number.

[source lang="cpp"]void ShaderProgram::setTexture(String variableName, int samplerNo, ICubeMap* texture)
{
assert(this->programId == activeProgram);
assert(samplerNo >= 0);


glEnable(GL_TEXTURE_CUBE_MAP);
glBindTexture(GL_TEXTURE_CUBE_MAP, texture->getOpenGLId());

glActiveTexture(GL_TEXTURE0 + samplerNo);

GLuint loc = glGetUniformLocation(this->programId, variableName.getStringUtf8());
glUniform1i(loc, samplerNo);
}[/source]

Finally, the minimimalistic test fragment shader:

[source lang="cpp"]#version 330

uniform samplerCube cubeMapTexture;

in vec4 rawNormal;

out vec4 fragmentColour;

void main(void)
{
fragmentColour = texture(cubeMapTexture, vec3(rawNormal.xyz));

}[/source]
The vertex shader works as it should, if I hard set the colour in the fragment shader the object appears as expected.

I would be thankful for any help.
0

Share this post


Link to post
Share on other sites
I am not sure about this, but I believe gluBuild2DMipmaps does not accept cube map faces as texture targets and thus cannot build cube map faces. If this is the case, then your call to gluBuild2DMipmaps will fail and thus leave the texture object in an incomplete, and therefore invalid, state since you have specified the minification filtering as a mipmap filter but only provided the base level texture. Either don't use mipmap filtering, or generate your mipmaps with the current glGenerateMipmap function instead.
1

Share this post


Link to post
Share on other sites
[quote name='Brother Bob' timestamp='1353707858' post='5003587']
I am not sure about this, but I believe gluBuild2DMipmaps does not accept cube map faces as texture targets and thus cannot build cube map faces. If this is the case, then your call to gluBuild2DMipmaps will fail and thus leave the texture object in an incomplete, and therefore invalid, state since you have specified the minification filtering as a mipmap filter but only provided the base level texture. Either don't use mipmap filtering, or generate your mipmaps with the current glGenerateMipmap function instead.
[/quote]

Looking at the documentation, you seem to be correct. Though removing any reference to mipmaps (the function and the filtering methods set to just GL_LINEAR instead) does not seem to correct the issue though. All samples are still pure black.
0

Share this post


Link to post
Share on other sites
I don't see anything obvious other than what I mentioned. Check for errors codes to see if anything is wrong. Keep in mind that some functions indicate errors by return value instead of an error state from glGetError, such as querying a uniform location, so make sure you check return values for functions as well.
1

Share this post


Link to post
Share on other sites
[quote name='Brother Bob' timestamp='1353709872' post='5003594']
I don't see anything obvious other than what I mentioned. Check for errors codes to see if anything is wrong. Keep in mind that some functions indicate errors by return value instead of an error state from glGetError, such as querying a uniform location, so make sure you check return values for functions as well.
[/quote]

I should have done it from the beginning, especially as I usually program fairly defensivly. But I went and added error checking to all OpenGL calls and it seems that the shader program is unable to find the cubemap sampler. Strange, it is used so it should not be optimized away and I double checked the name after discovering this. No trouble there, are there any known causes for this issue?

Edit: Nevermind, was reporting for a different shader program. It finds it just fine for this, but still black an no clear errors... Edited by PAndersson
0

Share this post


Link to post
Share on other sites
If I write this shader:

[source lang="cpp"]uniform samplerCube cubeTest;
uniform samplerCube terrainNoiseTexture;

void main(void)
{
fragmentColour.rbg = texture(terrainNoiseTexture, vec3(rawNormal.xyz)).rrr;
fragmentColour.rbg += texture(cubeTest, vec3(rawNormal.xyz)).rrr;
fragmentColour.a = 1;
}[/source]

I can suddenly read from the black cubemap as expected....

Maybe I just should update my drivers...
Still nothing. So what could cause a cubemap to be all blick until I sample another cubemap first? Edited by PAndersson
0

Share this post


Link to post
Share on other sites
So if you use that exact code and just comment out one of the two texture samplers, then it stops working? Reduce your application to an absolute minimum and show the complete code.
0

Share this post


Link to post
Share on other sites
[quote name='Brother Bob' timestamp='1353757833' post='5003718']
So if you use that exact code and just comment out one of the two texture samplers, then it stops working? Reduce your application to an absolute minimum and show the complete code.
[/quote]

All right, have not had any more success with this (to be fair, not a lot of time to work on it either) so I will see what I can do. The application currently uses A LOT of infrastructure and getting rid of that will be a major effort...
0

Share this post


Link to post
Share on other sites
Finally got some more time to look into the issue and managed to find and solve the problem.

The setTexture method should look like this:

[source lang="cpp"] void ShaderProgram::setTexture(String variableName, int samplerNo, ICubeMap* texture)
{
assert(this->programId == this->activeProgram);
assert(samplerNo >= 0);


//Prepere texture
glCheckedCall( glActiveTexture(GL_TEXTURE0 + samplerNo) );

glCheckedCall( glEnable(GL_TEXTURE_CUBE_MAP) );
glCheckedCall( glBindTexture(GL_TEXTURE_CUBE_MAP, texture->getOpenGLId()) );


GLint loc = glCheckedCall( glGetUniformLocation(this->programId, variableName.getStringUtf8()) );
if (loc < 0) syslog.Error(String("Failed to find uniform cubemap name \"") + variableName + "\" in program " + this->getProgramID());
glCheckedCall( glUniform1i(loc, samplerNo) );

}[/source]
As in my previous post, I bound the texture before activating it thus effectivly messing with other texture units. Simply swapping the order in which the function calls are made solved everything.

Thank you for your help, and this just cements my sentiment that state-based interfaces are evil :P Edited by PAndersson
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0

  • Similar Content

    • By Sagaceil
      It's always better to fight with a bro.
    • By recp
      Hi,
      I'm working on new asset importer (https://github.com/recp/assetkit) based on COLLADA specs, the question is not about COLLADA directly
      also I'm working on a new renderer to render (https://github.com/recp/libgk) imported document.
      In the future I'll spend more time on this renderer of course, currently rendering imported (implemented parts) is enough for me
      assetkit imports COLLADA document (it will support glTF too),
      importing scene, geometries, effects/materials, 2d textures and rendering them seems working
      My actual confusion is about shaders. COLLADA has COMMON profile and GLSL... profiles,
      GLSL profile provides shaders for effects so I don't need to wory about them just compile, link, group them before render

      The problem occours in COMMON profile because I need to write shaders,
      Actually I wrote them for basic matrials and another version for 2d texture
      I would like to create multiple program but I am not sure how to split this this shader into smaller ones,

      Basic material version (only colors):
      https://github.com/recp/libgk/blob/master/src/default/shader/gk_default.frag
      Texture version:
      https://gist.github.com/recp/b0368c74c35d9d6912f524624bfbf5a3
      I used subroutines to bind materials, actually I liked it,
      In scene graph every node can have different program, and it switches between them if parentNode->program != node->program
      (I'll do scene graph optimizations e.g.  view frustum culling, grouping shaders... later)

      I'm going to implement transparency but I'm considering to create separate shaders,
      because default shader is going to be branching hell
      I can't generate shader for every node because I don't know how many node can be exist, there is no limit.
      I don't know how to write a good uber-shader for different cases:

      Here material struct:
      struct Material { ColorOrTexture emission; ColorOrTexture ambient; ColorOrTexture specular; ColorOrTexture reflective; ColorOrTexture transparent; ColorOrTexture diffuse; float shininess; float reflectivEyety; float transparency; float indexOfRefraction; }; ColorOrTexture could be color or 2d texture, if there would be single colorOrTex then I could split into two programs,
      Also I'm going to implement transparency, I am not sure how many program that I needed

      I'm considering to maintain a few default shaders for COMMON profile,
      1-no-texture, 2-one of colorOrTexture contains texture, 3-........

      Any advices in general or about how to optimize/split (if I need) these shaders which I provied as link?
      What do you think the shaders I wrote, I would like to write them without branching if posible,
      I hope I don't need to write 50+ or 100+ shaders, and 100+ default programs

      PS: These default shaders should render any document, they are not specific, they are general purpose...
             I'm compiling and linking default shaders when app launched

      Thanks
    • By CircleOfLight97
      Hi guys,
      I would like to contribute to a game project as a developer (open source possibly). I have some experiences in C/C++ in game development (perso projects). I don't know either unreal or unity but I have some knowledges in opengl, glsl and shading theory as I had some courses at university regarding to that. I have some knowledges in maths and basic in physics. I know a little how to use blender to do modelling, texturing and simple game assets (no characters, no animation no skinning/rigging). I have no game preferences but I like aventure game, dungeon crawler, platformers, randomly generated things. I know these kind of projects involve a lot of time and I'd be really to work on it but if there are no cleary defined specific design goals/stories/gameplay mechanics I would like to not be part of it x) and I would rather prefer a smaller but well defined project to work on that a huge and not 'finishable' one.
      CircleOfLight97
    • By gamesthatcouldbeworse
      Hi, I finally released KILL COMMANDO on gamejolt for free. It is a retro-funsplatter-shooter with C64 style. Give it a try.
    • By phil67rpg

      void TimerFunction(int value) {  glutPostRedisplay();  glutTimerFunc(1000, TimerFunction, 1); } void drawScene() {  glClear(GL_COLOR_BUFFER_BIT);      drawScene_bug();  TimerFunction(1);  eraseScene_bug(); // drawScene_bug_two(); // eraseScene_bug_two(); drawScene_ship(); drawScene_bullet();  glutSwapBuffers(); }