• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
lride

vector subscript out of range

8 posts in this topic

I have a vector of pointer to entity. I also have a GameWorld class that contains this vector.
[source lang="cpp"]std::vector<Entity*> entities;

GameWorld::GameWorld()
{
entities.push_back(new Character("YOURS", CharacterType::BLACK));
}
GameWorld::~GameWorld()
{
for(auto e: entities)
delete e;
}[/source]

When I close the game I get assertion failure "vector subscript out of range". What did I do wrong?

Edit:
I still get the vector assertion failure even when I changed the std::vector to std::list
I also found out that I can use the std::vector even I don't #include <vector>

OK I solved my problem. The GameWorld object is inside Game class which is a singleton. So the GameWorld is statically allocated.
But when I allocated Game class on stack, it worked fine. I have no idea why.. Edited by lride
0

Share this post


Link to post
Share on other sites
Why not use "delete entities;"? The vector destructor takes care of calling the Entity destructor for each object in the list..
0

Share this post


Link to post
Share on other sites
I see. He is creating a vector of Entity pointers, not a pointer to a vector of Entity objects. Edited by MarkS
0

Share this post


Link to post
Share on other sites
[quote name='MarkS' timestamp='1354997809' post='5008591']
Still, doesn't the vector destructor call the object's destructor upon deletion?
[/quote]

A vector does call a destructor for an object it holds when that object is erased, but this vector is storing pointer objects, not Entity objects.
So basically the vector is calling a destructor for the pointer object (which is perfectly legal), but that doesn't mean the destructor for the object the pointer is pointing to gets called or that the memory consumed by the object the pointer is pointing to gets released. Edited by Radikalizm
2

Share this post


Link to post
Share on other sites
[quote name='Radikalizm' timestamp='1354998013' post='5008594']
[quote name='MarkS' timestamp='1354997809' post='5008591']
Still, doesn't the vector destructor call the object's destructor upon deletion?
[/quote]

A vector does call a destructor for an object it holds when that object is erased, but this vector is storing pointer objects, not Entity objects.
So basically the vector is calling a destructor for the pointer object (which is perfectly legal), but that doesn't mean the destructor for the object the pointer is pointing to gets called or that the memory consumed by the object the pointer is pointing to gets released.
[/quote]

That is very interesting! I don't create vectors of pointers, but I'll need to keep that in mind.

Since we are on the subject, why create a vector of pointers in the first place?
0

Share this post


Link to post
Share on other sites
[quote name='lride' timestamp='1354988921' post='5008542']
When I close the game I get assertion failure "vector subscript out of range". What did I do wrong?[/quote]You either corrupted your vector somewhere, or you tried to access outside of its bounds.

[quote]Edit:
I still get the vector assertion failure even when I changed the std::vector to std::list
I also found out that I can use the std::vector even I don't #include <vector>[/quote]Both of those statements are inaccurate.
If you change it to a list then you wont get assert about the vector because it isn't a vector any more. A std::list does not use code from within the std::vector. You're probably just getting the same error from a different piece of the std library. Getting the same behviour probably means that you are going past the end of the container rather than corrupting it.
If code with vector still compiles, then something else you are including is pulling in the vector header for you. You should probably not be relying on that.

If you need your vector to hold pointers for reasons of polymorphism, then you might be better off with a boost ptr_container rather than a vector. Otherwise you should problably just store instances directly rather than pointers. Edited by iMalc
0

Share this post


Link to post
Share on other sites
[quote name='MarkS' timestamp='1355005213' post='5008615']
Since we are on the subject, why create a vector of pointers in the first place?
[/quote]
Because I want to store different kinds of object in the same vector. This can only be done by storing the pointers or references to the object and using polymorphism.
Also, I store pointers to objects in a vector when the object is too expensive to copy. (When you use std::vector::push_back(), the copy of the object gets stored.)
However, this extra copy can be avoided by using c++11 'move', .


[quote name='iMalc' timestamp='1355006671' post='5008620']
Both of those statements are inaccurate.
If you change it to a list then you wont get assert about the vector because it isn't a vector any more. A std::list does not use code from within the std::vector. You're probably just getting the same error from a different piece of the std library. Getting the same behviour probably means that you are going past the end of the container rather than corrupting it.
If code with vector still compiles, then something else you are including is pulling in the vector header for you. You should probably not be relying on that.

If you need your vector to hold pointers for reasons of polymorphism, then you might be better off with a boost ptr_container rather than a vector. Otherwise you should problably just store instances directly rather than pointers.
[/quote]

This is the only place I'm using vector in my entire project. and I've searched #include <vector> in my entire solution and there was none.
But now that I already solved the problem, what is the advantage of using a boost ptr vector instead of using a normal vector Edited by lride
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0