• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
lride

Crash in std::set::insert()

10 posts in this topic

I made a bomberman-like program. I keep a 2d array of Tile object in a GameMap object.
Every time the player crosses to a different tile, the new tile's onEnter() gets called and the old tile's onExit() gets called
Each tile object has std::set that stores all the entities that are on the tile. onEnter() adds the pointer to the entity to its set and onExit() erases the pointer from its set.
But my game crashes there.

[source lang="cpp"]
//Check if the player moved to a different tile
if(previousLoc!=currentLoc)
{
gameWorld->getGameMap().onEnter(currentLoc.x, currentLoc.y, this);
gameWorld->getGameMap().onExit(previousLoc.x, previousLoc.y, this);
}
GameMap::onEnter(int x, int y, Entity * e)
{
tiles[y][x].onEnter(e);
}
GameMap::onExit(int x, int y, Entity *e)
{
tiles[y][x].onExit(e);
}
Tile::onEnter(Entity * e)
{
entities.insert(e); //entities is declared as std::set<Entity*> entities
}
Tile::onExit(Entity * e)
{
entities.erase(e);
}

[/source]


The stack trace shows up like this
> Game3.exe!std::_Tree<std::_Tset_traits<Entity *,std::less<Entity *>,std::allocator<Entity *>,0> >::_Root() Line 2139 C++
Game3.exe!std::_Tree<std::_Tset_traits<Entity *,std::less<Entity *>,std::allocator<Entity *>,0> >::_Insert_nohint<Entity * const &,std::_Nil>(bool _Leftish, Entity * const & _Val, std::_Nil _Newnode) Line 1784 C++
Game3.exe!std::_Tree<std::_Tset_traits<Entity *,std::less<Entity *>,std::allocator<Entity *>,0> >::insert(Entity * const & _Val) Line 1304 C++
Game3.exe!std::set<Entity *,std::less<Entity *>,std::allocator<Entity *> >::[u]insert[/u](Entity * const & _Val) Line 166 C++
Game3.exe![u]Tile::onEnter[/u](Entity * e) Line 17 C++
Game3.exe![u]GameMap::onEnter[/u](int x, int y, Entity * e) Line 118 C++

What can possibly cause my program to crash? Edited by lride
0

Share this post


Link to post
Share on other sites
Depending on exactly what type [tt]tiles[/tt] is, some potential causes can include calling onEnter() on an uninitialized pointer, a pointer to a deleted object, a pointer to an unconstructed object, non-kosher memory use like memest() on a non-POD type, buffer overruns, accessing past the end of allocated memory, and so on.
0

Share this post


Link to post
Share on other sites
onEnter() merely stores the pointer in the set. It doesn't try to dereference the pointer.
0

Share this post


Link to post
Share on other sites
[quote name='wqking' timestamp='1355111988' post='5008975']
Are you sure tiles[y][x] is valid and x, y are not out of bounds?
[/quote]

Yes, I'm using std::array in debug mode, which should result in assertion failure if x and y is out of bound
0

Share this post


Link to post
Share on other sites
[quote name='lride' timestamp='1355109315' post='5008962']
onEnter() merely stores the pointer in the set. It doesn't try to dereference the pointer.
[/quote]
I'm not talking about the pointer that you're trying to put in the set, I'm talking about the object that you're calling onEnter() on, either the GameMap or Tile objects.
0

Share this post


Link to post
Share on other sites
[quote name='SiCrane' timestamp='1355112936' post='5008980']
[quote name='lride' timestamp='1355109315' post='5008962']
onEnter() merely stores the pointer in the set. It doesn't try to dereference the pointer.
[/quote]
I'm not talking about the pointer that you're trying to put in the set, I'm talking about the object that you're calling onEnter() on, either the GameMap or Tile objects.
[/quote]
anyways uninitialized pointer or pointer to deleted object, or pointer to unconstructed object aren't possible.
I'm passing the pointer with "this" pointer as you can see
0

Share this post


Link to post
Share on other sites
1) Using [tt]this[/tt] is no guarantee that the pointer is initialized.
[code]
struct Object {
void func(void) {
some_other_function(this);
}
};

Object * obj; // not initialized
obj->func(); // some_other_function() will receive an uninitialized pointer.
[/code]
2) I'm still not talking about the pointer that you're storing in the set, I'm talking about the object that the member function is being called on, which looks to be whatever [tt]gameWorld->getGameMap()[/tt] returns.
0

Share this post


Link to post
Share on other sites
Ok I somewhat mitigated the crash.
Originally, all base entity had a protected pointer to the gameWorld object
But now I changed it so that I passed the gameWorld object each time in a loop.

Then I get list out of range assertion failure so at least I know what's wrong
0

Share this post


Link to post
Share on other sites
Now I completely solved the problem.
I have no idea why the crash occurred.
I will try to find the complete minimal example that reproduces the problem
0

Share this post


Link to post
Share on other sites
[quote name='lride' timestamp='1355116433' post='5008990']
Now I completely solved the problem.
I have no idea why the crash occurred.
[/quote]

Not to rain on your parade, but those two statements are usually mutually exclusive.
2

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0