• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Yoyoyoyo

Does my shader code look alright?

8 posts in this topic

[source lang="cpp"]cbuffer cbPerObject
{
float4x4 gWorldViewProj;
};


Texture2D CubesTexture;
SamplerState CubesTexSamplerState;


/////////////////////////////
struct VS_inputVPCT
{
float3 Pos : POSITION;
float4 Col : COLOUR;
float2 Tex : TEXTURE;
};

struct VS_outputVPCT
{
float4 Pos : SV_POSITION;
float4 Col : COLOUR;
float2 Tex : TEXTURE;
};

struct PS_outputVPCT
{
float4 Col : COLOUR;
float2 Tex : TEXTURE;
};

///////////////////////////////


////////////////////////////////////////////////////
VS_outputVPCT VSfuncVPCT(VS_inputVPCT input)
{
VS_outputVPCT output;

output.Pos = mul(float4(input.Pos, 1.0f), gWorldViewProj);
output.Col = input.Col;
output.Tex = input.Tex;




return output;

}


PS_outputVPCT PSfuncVPCT(VS_outputVPCT input) : SV_Target
{

PS_outputVPCT output;

output.Col = input.Col;
output.Tex = CubesTexture.Sample(CubesTexSamplerState, input.Tex);

return output;
}
///////////////////////////////////////////////////////////////[/source]




Thankyou for any assistance!
0

Share this post


Link to post
Share on other sites
[quote]
Does my shader code look alright?

[/quote]
Well, it looks like shader code, when it compiles, it is most likely ok.

But if you want to check, if the code is doing what you want it to do, then you should at least tell us, what your goal is.
0

Share this post


Link to post
Share on other sites
My vertices contain position, colour and tex information. I have 1 constant buffer keeping track of world/view/proj, and that's about it. I am drawing a grid of vertices and expecting to see them, which i don't. I didn't think the problem was with my structs and functions here, so i just wanted a second opinion.
From this code would you expect a minimal amount of vertices of type Pos/Col/Tex to be transformed correctly, and passed successfully through the vertex and pixel shader?
0

Share this post


Link to post
Share on other sites
Your semantics look weird to me. To be standard code COLOUR should be COLOR, and TEXTURE should be TEXCOORD. However, maybe it works like that as well if you have declared your input layouts accordingly. I would try changing them though.
0

Share this post


Link to post
Share on other sites
I've used those semantics before no prob, afaik as long as the input layout matches it's good to go.
0

Share this post


Link to post
Share on other sites
Why would you want to return both texture color and the "other" color from the pixel shader? Don't you want to either blend them in the shader, or somewhere before this point decide what color you want to output?
0

Share this post


Link to post
Share on other sites
Yeah it's redundant isn't it? I should remove the colour since it's not needed, but will it cause problems? It looks like the code is ok? Thank's for the feedback.
0

Share this post


Link to post
Share on other sites
Ahh, that might be the problem. SV_Target maps to a float4. You should generally return a float4 (or nothing at all) from the pixel shader. Try removing the texture and see if that helps.
0

Share this post


Link to post
Share on other sites
Hello,

output.Pos = mul(float4(input.Pos, 1.0f), gWorldViewProj);

Casting input.Pos to float4 with the 4th component as 1.0 is unnecessary if you define your input vertex structure as :

struct VS_inputVPCT
{
float4 Pos : POSITION;
...
}

Remember that the program side structure needs to be still 3 component vector and the vertex declaration needs to be DXGI_FORMAT_R32G32B32_FLOAT for the position.


Otherwise, you may use what ever name for your semantics as long as you use the same name in the vertex declaration.


Cheers!
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0