• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0

Shaders: Lighting has different brightness on different PCs

12 posts in this topic


I´m currently developing an online multiplayer game using OpenGL.
Until recently, I used the fixed OpenGL rendering pipeline, but I (nearly) successfully switched to shaders (it looks MUCH better [img]http://public.gamedev.net//public/style_emoticons/default/wink.png[/img] )

But there is an issue with the lighting:
On my computer everything is fine (I guess because I took suitable values for the lights) ;
but on two other computers, the lightning is pretty much brighter than on mine. Therefore we can not figure out some good looking values for the light...
Could it have something to do with me having ATI and my friend Geforce?
Anyway, I´ll attach two images of the situation to this post.

Now for the code:
As far as the shader goes, here is the code of the fragmentshader:
[source lang="java"]varying vec4 diffuse, ambient;
varying vec3 normal, lightDir, halfVector;
varying vec4 glColor;

uniform sampler2D tex0;
uniform sampler2D tex1;
uniform sampler2D tex2;

uniform int lighting;
uniform int texturing;
uniform int alphamap;

void main (void)
vec3 n,halfV;
float NdotL,NdotHV;
vec4 color = glColor;

if (lighting==1) {color*=2*ambient;color.a=1;
} else if (lighting==2) {
n = normal;

NdotL = dot(n,lightDir);
if (true) {
color += diffuse * NdotL;

switch (texturing) {
case 0: gl_FragColor=color;break;
case 1: gl_FragColor=color*texture2D(tex0,gl_TexCoord[0].st);break;
case 2:
vec4 texture0 = texture2D(tex0,gl_TexCoord[0].st);
vec4 texture1 = texture2D(tex1,gl_TexCoord[1].st);
vec4 texture2 = texture2D(tex2,gl_TexCoord[2].st);
if (alphamap==0) {gl_FragColor = color*mix(texture1,texture2,texture0.g);
} else if (alphamap==1) {gl_FragColor = color*mix(texture1,texture2,texture0.r);}
else {gl_FragColor= vec4(1,1,1,1);}break;
Usually lighting equals 2 and texturing equals 1.
There are some calculations in the vertexshader as well:

[source lang="java"] if (lighting>=1) {
ambient = gl_FrontMaterial.ambient * gl_LightSource[0].ambient;
ambient += gl_LightModel.ambient * gl_FrontMaterial.ambient;
if (lighting==2) {
normal = normalize(gl_NormalMatrix * gl_Normal);
lightDir = normalize(vec3(gl_LightSource[0].position));
halfVector = normalize(gl_LightSource[0].halfVector.xyz);
diffuse = gl_FrontMaterial.diffuse * gl_LightSource[0].diffuse;

Finally, I set up the lighting in the program itself:

[source lang="java"]//Lighting

FloatBuffer lightPosition = BufferUtils.createFloatBuffer(4);
FloatBuffer whiteLight = BufferUtils.createFloatBuffer(4);
GL11.glLight(GL11.GL_LIGHT0, GL11.GL_SPECULAR, whiteLight);
GL11.glLight(GL11.GL_LIGHT0, GL11.GL_DIFFUSE, whiteLight);

FloatBuffer lModelAmbient = BufferUtils.createFloatBuffer(4);

Basically, the scene consists of a simple ambient light and one directional light (representing the sun).
Now, I get that 1.4f may be a pretty high value for the ambient light, but when I turn it down, the scene gets very dark (at least on my computer).

Do you have a clue of where to look for the mistake?
Is there some kind of function or calculation that may be treated differently by different graphic cards or even by different versions of GLSL?
It´s like one computer adds a certain value to the light and the other doesn´t...

Thanks in advance for any clues

Share this post

Link to post
Share on other sites
Check the value of your lighting variable on the other computer. From the code you've posted, only ambient lighting is applied when 'lighting' is equal to 1 (both ambient, and directional are applied when lighting is equal to 2).

I don't see where lighting is actually set anywhere in the code you posted but that's a good starting point to take a look at for you.

To reiterate, the reason it looks brighter on the other machine is probably because you're only applying ambient lighting when it runs on that machine.

Share this post

Link to post
Share on other sites
Check the value of your lighting variable on the other computer.
ok, checked
Usually, the value of the lighting-variable should be 2 nearly all the time;
but to be certain, I changed the code of the shaders to make them do always the same, regardless of the value of this variable.
When we tested it on the problematic computers, no differences was to be found...

Also, I tested it the other way round, now on my computer:
I set the shaders to only act like lighting was 1 all the time. No great differences, just slightly darker and no directional light.

So the lighting variable should act like it is supposed to act, thanks for the suggestion anyway.
I think there may be some calculation of some vector or something that is done differently on both computers.

To eliminate as many sources for errors as possible, I checked the version of OpenGL on the computers.
We both use the same version, 4.2. Edited by m41q

Share this post

Link to post
Share on other sites

i still have not found the cause of the problem, but I think I at least was able to reduce the consequences of the bug:
Now the player can decide for himself, what brightness suits him best.


But still,

if anyone knows why there are different calculations on different pcs when using shader, an answer would be much appreciated.


Share this post

Link to post
Share on other sites

It has been a while since I worked on the graphics (have been busy with other functionalities), but this bug still affects the game.


Every one that works on a computer with this bug is able to set the brightness to 50% and the overall lightness is good. But it doesn´t create the effect I wanted:

Now everything looks the same, regarding brightness. There are no bright or dark parts like those on the computer where this bug doesnt occur...


What could  POSSIBLY  make the SAME shader work DIFFER ENT on different machines?

Are there ANY possible circumstances that influence the calculations?


Still thanks if anyone knows anything...


Share this post

Link to post
Share on other sites

Undefined behavior can. In fact, going by the first image, it looks like lighting isn't being applied at all, and considering the way lighting is set up, it looks like the only reason it works is because you're still using some leftover functionality from the fixed pipeline (instead of passing all lighting variables directly to the shader as uniforms).


By the way, shouldn't gl_FragColor = vec4(1,1,1,1); actually be gl_FragColor = vec4(1.0f,1.0f,1.0f,1.0f);? Silly catch, but I recall GLSL doesn't support implicit casting between integers and floats and this can mess up the shader compilation (dunno if newer versions rectify this, really didn't get any time to work on them).


Share this post

Link to post
Share on other sites

Just to shed some more light on the general problem, without (unfortunately) being able to help much:


When the shader is loaded, it is compiled by the driver before it's sent to the graphics card.

This compilation is the obvious place where things "go wrong" between hardware vendors.

Some compilers are less strict then others, so if you wrote some un-standard code (probably without realizing), it's highly likely that it will behave differently on different hardware.


One good practice is to always specify shader version in the shader program, this generally makes the compiler behave more predictable.


Also don't forget to read the output of the compiler with glGetShaderInfoLog during debug, to catch any warnings.

Edited by Olof Hedman

Share this post

Link to post
Share on other sites

1. If you develop on nvidia, get your hands on an AMD/ATI videocard. NVidia has a very lax handling of the GLSL specification resulting often in shaders not working on other video chips.

In the first post he said he's using AMD hardware that the computer where it has problems has Nvidia hardware. Yeah, that one makes this situation really odd since it's the Nvidia drivers that are lenient usually. It's probably always a good idea to test on both anyway.


Share this post

Link to post
Share on other sites

Thx @all for the answers!


Ok, I´ll just finish my current ToDo and then will test all the things you suggested.

It´s quite possible that I messed up something in the code and did not write it in the "standard-way" of doing it since this is my first time using GLSL.

It looks like this language is a bit nasty compared to Java and its convenient Exceptionswink.png.


Btw, what do you think of the overall graphics quality?

My friend always wants to know what others think of his workwink.png.


Share this post

Link to post
Share on other sites
Yeah its pretty annoying to have drivers that could probably handle shaders written in HTML, making you unable to fix them on your computer...

Share this post

Link to post
Share on other sites

Btw, what do you think of the overall graphics quality?
My friend always wants to know what others think of his work.

Eh, looks a bit too dark to me, although don't trust much this monitor (it shows some shades really dark). Source material is fine though if the first pic (the non-lit one) is anything to go by, it's the lighting that would need to be tweaked. Not much brighter, just a bit. Of course depends what you want to do, I just find it hard to look around there (trees appear practically black - I seriously need a new monitor...).


Share this post

Link to post
Share on other sites

Source material is fine


ok, good to hear

trees appear practically black

yeah... they don´t do that on my screen ^^.
Anyway, because of this bug I tried a workaround with a brightness option, so even your screen would probably be fine ;-)

Share this post

Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  
Followers 0

  • Similar Content

    • By Toastmastern
      So it's been a while since I took a break from my whole creating a planet in DX11. Last time around I got stuck on fixing a nice LOD.
      A week back or so I got help to find this:
      In general this is what I'm trying to recreate in DX11, he that made that planet LOD uses OpenGL but that is a minor issue and something I can solve. But I have a question regarding the code
      He gets the position using this row
      vec4d pos = b.var.vec4d["position"]; Which is then used further down when he sends the variable "center" into the drawing function:
      if (pos.len() < 1) pos.norm(); world::draw(vec3d(pos.x, pos.y, pos.z));  
      Inside the draw function this happens:
      draw_recursive(p3[0], p3[1], p3[2], center); Basically the 3 vertices of the triangle and the center of details that he sent as a parameter earlier: vec3d(pos.x, pos.y, pos.z)
      Now onto my real question, he does vec3d edge_center[3] = { (p1 + p2) / 2, (p2 + p3) / 2, (p3 + p1) / 2 }; to get the edge center of each edge, nothing weird there.
      But this is used later on with:
      vec3d d = center + edge_center[i]; edge_test[i] = d.len() > ratio_size; edge_test is then used to evaluate if there should be a triangle drawn or if it should be split up into 3 new triangles instead. Why is it working for him? shouldn't it be like center - edge_center or something like that? Why adding them togheter? I asume here that the center is the center of details for the LOD. the position of the camera if stood on the ground of the planet and not up int he air like it is now.

      Full code can be seen here:
      If anyone would like to take a look and try to help me understand this code I would love this person. I'm running out of ideas on how to solve this in my own head, most likely twisted it one time to many up in my head
      Thanks in advance
    • By fllwr0491
      I googled around but are unable to find source code or details of implementation.
      What keywords should I search for this topic?
      Things I would like to know:
      A. How to ensure that partially covered pixels are rasterized?
         Apparently by expanding each triangle by 1 pixel or so, rasterization problem is almost solved.
         But it will result in an unindexable triangle list without tons of overlaps. Will it incur a large performance penalty?
      B. A-buffer like bitmask needs a read-modiry-write operation.
         How to ensure proper synchronizations in GLSL?
         GLSL seems to only allow int32 atomics on image.
      C. Is there some simple ways to estimate coverage on-the-fly?
         In case I am to draw 2D shapes onto an exisitng target:
         1. A multi-pass whatever-buffer seems overkill.
         2. Multisampling could cost a lot memory though all I need is better coverage.
            Besides, I have to blit twice, if draw target is not multisampled.
    • By mapra99

      I am working on a recent project and I have been learning how to code in C# using OpenGL libraries for some graphics. I have achieved some quite interesting things using TAO Framework writing in Console Applications, creating a GLUT Window. But my problem now is that I need to incorporate the Graphics in a Windows Form so I can relate the objects that I render with some .NET Controls.

      To deal with this problem, I have seen in some forums that it's better to use OpenTK instead of TAO Framework, so I can use the glControl that OpenTK libraries offer. However, I haven't found complete articles, tutorials or source codes that help using the glControl or that may insert me into de OpenTK functions. Would somebody please share in this forum some links or files where I can find good documentation about this topic? Or may I use another library different of OpenTK?

    • By Solid_Spy
      Hello, I have been working on SH Irradiance map rendering, and I have been using a GLSL pixel shader to render SH irradiance to 2D irradiance maps for my static objects. I already have it working with 9 3D textures so far for the first 9 SH functions.
      In my GLSL shader, I have to send in 9 SH Coefficient 3D Texures that use RGBA8 as a pixel format. RGB being used for the coefficients for red, green, and blue, and the A for checking if the voxel is in use (for the 3D texture solidification shader to prevent bleeding).
      My problem is, I want to knock this number of textures down to something like 4 or 5. Getting even lower would be a godsend. This is because I eventually plan on adding more SH Coefficient 3D Textures for other parts of the game map (such as inside rooms, as opposed to the outside), to circumvent irradiance probe bleeding between rooms separated by walls. I don't want to reach the 32 texture limit too soon. Also, I figure that it would be a LOT faster.
      Is there a way I could, say, store 2 sets of SH Coefficients for 2 SH functions inside a texture with RGBA16 pixels? If so, how would I extract them from inside GLSL? Let me know if you have any suggestions ^^.
    • By KarimIO
      EDIT: I thought this was restricted to Attribute-Created GL contexts, but it isn't, so I rewrote the post.
      Hey guys, whenever I call SwapBuffers(hDC), I get a crash, and I get a "Too many posts were made to a semaphore." from Windows as I call SwapBuffers. What could be the cause of this?
      Update: No crash occurs if I don't draw, just clear and swap.
      static PIXELFORMATDESCRIPTOR pfd = // pfd Tells Windows How We Want Things To Be { sizeof(PIXELFORMATDESCRIPTOR), // Size Of This Pixel Format Descriptor 1, // Version Number PFD_DRAW_TO_WINDOW | // Format Must Support Window PFD_SUPPORT_OPENGL | // Format Must Support OpenGL PFD_DOUBLEBUFFER, // Must Support Double Buffering PFD_TYPE_RGBA, // Request An RGBA Format 32, // Select Our Color Depth 0, 0, 0, 0, 0, 0, // Color Bits Ignored 0, // No Alpha Buffer 0, // Shift Bit Ignored 0, // No Accumulation Buffer 0, 0, 0, 0, // Accumulation Bits Ignored 24, // 24Bit Z-Buffer (Depth Buffer) 0, // No Stencil Buffer 0, // No Auxiliary Buffer PFD_MAIN_PLANE, // Main Drawing Layer 0, // Reserved 0, 0, 0 // Layer Masks Ignored }; if (!(hDC = GetDC(windowHandle))) return false; unsigned int PixelFormat; if (!(PixelFormat = ChoosePixelFormat(hDC, &pfd))) return false; if (!SetPixelFormat(hDC, PixelFormat, &pfd)) return false; hRC = wglCreateContext(hDC); if (!hRC) { std::cout << "wglCreateContext Failed!\n"; return false; } if (wglMakeCurrent(hDC, hRC) == NULL) { std::cout << "Make Context Current Second Failed!\n"; return false; } ... // OGL Buffer Initialization glClear(GL_DEPTH_BUFFER_BIT | GL_COLOR_BUFFER_BIT); glBindVertexArray(vao); glUseProgram(myprogram); glDrawElements(GL_TRIANGLES, indexCount, GL_UNSIGNED_SHORT, (void *)indexStart); SwapBuffers(GetDC(window_handle));  
  • Popular Now