• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
superman3275

Vector Subscript Out Of Range

3 posts in this topic

Hello! I've recently been running into trouble where I'm loading a file. The error is telling me I have a vector subscript out of range, and after setting some breakpoints I know where the error is coming from, however I'm having trouble fixing it. I would be very happy if you could look at my code and see what you believe the problem is :)!

Map.h:
[CODE]
#pragma once
struct block;
namespace th
{
class Map
{
public:
Map(std::string mapLocation);
~Map(void);
void closeFile();
void loadFile(std::string fileLocation);
void newMap(std::string locationOfNewMap, std::vector<std::vector<block>> newValues);
std::vector<std::vector<block>> convertToBlocks();
std::vector<std::vector<block>> tiledMap();
private:
std::ifstream mapFile;
std::vector<std::vector<int>> mapInIntegers;
std::vector<std::vector<block>> mapInBlocks;
};
}
[/CODE]
Map.cpp:
[CODE]
#include "StdAfx.h"
#include "Map.h"

th::Map::Map(std::string mapLocation)
{
mapFile.open(mapLocation);
//Setting The Map's Size
int lIndexSize, rIndexSize;
mapFile >> lIndexSize;
mapFile >> rIndexSize;
mapInIntegers.resize(lIndexSize);
for (int index = 0; index < lIndexSize; ++index)
{

mapInIntegers[index].resize(rIndexSize);
}
//Loading The Map
int currentPosition = 2;
int currentValue = 0;

for(int lindex = 0; lindex < mapInIntegers.size(); ++lindex)
{
for(int rindex = 0; rindex < mapInIntegers[lindex].size(); ++rindex)
{
++currentPosition;
mapFile >> currentValue;
mapInIntegers[lindex][rindex] = currentValue;
}
}
convertToBlocks();
}

th::Map::~Map(void)
{
}

std::vector<std::vector<block>> th::Map::convertToBlocks()
{
mapInBlocks.resize(mapInIntegers.size());
for(unsigned int lindex = 0; lindex < mapInBlocks.size(); ++lindex)
{
mapInBlocks[lindex].resize(mapInIntegers[lindex].size());
}
for(unsigned int lindex = 0; lindex < mapInIntegers.size(); ++lindex)
{

for(unsigned int rindex = 0; rindex < mapInIntegers[rindex].size(); ++rindex)
{

switch (mapInIntegers[rindex][lindex])
{
case 0:
mapInBlocks[lindex][rindex].type = (blockType)0;
case 1:
mapInBlocks[lindex][rindex].type = (blockType)1;
}
}
}

return mapInBlocks;
}

void th::Map::closeFile()
{
mapFile.close();
}

void th::Map::loadFile(std::string locationOfNewMap)
{
mapFile.open(locationOfNewMap);
}

void th::Map::newMap(std::string locationOfNewMap, std::vector<std::vector<block>> newValues)
{
std::ofstream newFile;
newFile.open(locationOfNewMap);
if(newFile.good())
{
newFile << newValues.size();
newFile << " ";
newFile << newValues[0].size();
for(unsigned int lindex = 0; lindex < newValues.size(); ++lindex)
{
newFile << "/n";
for(unsigned int rindex = 0; rindex < newValues[lindex].size(); ++rindex)
{
newFile << newValues[lindex][rindex].type << " ";
}
}
}
}

std::vector<std::vector<block>> th::Map::tiledMap()
{
return mapInBlocks;
}
[/CODE]

The error comes up right here:
[CODE]
std::vector<std::vector<block>> th::Map::convertToBlocks()
{
mapInBlocks.resize(mapInIntegers.size());
for(unsigned int lindex = 0; lindex < mapInBlocks.size(); ++lindex)
{
mapInBlocks[lindex].resize(mapInIntegers[lindex].size());
}

/*After running through the first for loop below once, it returns:
Vector Subscript Out Of Range the second time :0!*/

for(unsigned int lindex = 0; lindex < mapInIntegers.size(); ++lindex)
{
for(unsigned int rindex = 0; rindex < mapInIntegers[rindex].size(); ++rindex)
{
switch (mapInIntegers[rindex][lindex])
{
case 0:
mapInBlocks[lindex][rindex].type = (blockType)0;
case 1:
mapInBlocks[lindex][rindex].type = (blockType)1;
}
}
}
return mapInBlocks;
}
[/CODE]

As I detail in the comment, in the latter code it loops through the for loop once before giving me the error. All help is appreciated. And if it's any consolation, here's what the file looks like:
File:
[CODE]
1 1
1
[/CODE]

All help is appreciated :)!
0

Share this post


Link to post
Share on other sites
[quote][code]for(unsigned int rindex = 0; rindex < mapInIntegers[rindex].size(); ++rindex)[/code][/quote]
That should be
[code]for(unsigned int rindex = 0; rindex < mapInIntegers[lindex].size(); ++rindex)[/code]

Also, there should be a `break; before `case 1:'.
[quote][code]switch (mapInIntegers[rindex][lindex])
{
case 0:
mapInBlocks[lindex][rindex].type = (blockType)0;
case 1:
mapInBlocks[lindex][rindex].type = (blockType)1;
}[/code][/quote]
1

Share this post


Link to post
Share on other sites
[quote][code] switch (mapInIntegers[rindex][lindex])[/code][/quote]
Shouldn't the indices be reversed, like everywhere else?

You should just go over your code and make sure you get all those details right.
1

Share this post


Link to post
Share on other sites
You solved it! My map is loading and displaying correctly now! I can't believe how trivial the problem was. Thank you so much! You're awesome, thank you so much for helping me :)! Cheers!
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0