Sign in to follow this  

Vector Subscript Out Of Range

This topic is 1854 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Hello! I've recently been running into trouble where I'm loading a file. The error is telling me I have a vector subscript out of range, and after setting some breakpoints I know where the error is coming from, however I'm having trouble fixing it. I would be very happy if you could look at my code and see what you believe the problem is :)!

Map.h:
[CODE]
#pragma once
struct block;
namespace th
{
class Map
{
public:
Map(std::string mapLocation);
~Map(void);
void closeFile();
void loadFile(std::string fileLocation);
void newMap(std::string locationOfNewMap, std::vector<std::vector<block>> newValues);
std::vector<std::vector<block>> convertToBlocks();
std::vector<std::vector<block>> tiledMap();
private:
std::ifstream mapFile;
std::vector<std::vector<int>> mapInIntegers;
std::vector<std::vector<block>> mapInBlocks;
};
}
[/CODE]
Map.cpp:
[CODE]
#include "StdAfx.h"
#include "Map.h"

th::Map::Map(std::string mapLocation)
{
mapFile.open(mapLocation);
//Setting The Map's Size
int lIndexSize, rIndexSize;
mapFile >> lIndexSize;
mapFile >> rIndexSize;
mapInIntegers.resize(lIndexSize);
for (int index = 0; index < lIndexSize; ++index)
{

mapInIntegers[index].resize(rIndexSize);
}
//Loading The Map
int currentPosition = 2;
int currentValue = 0;

for(int lindex = 0; lindex < mapInIntegers.size(); ++lindex)
{
for(int rindex = 0; rindex < mapInIntegers[lindex].size(); ++rindex)
{
++currentPosition;
mapFile >> currentValue;
mapInIntegers[lindex][rindex] = currentValue;
}
}
convertToBlocks();
}

th::Map::~Map(void)
{
}

std::vector<std::vector<block>> th::Map::convertToBlocks()
{
mapInBlocks.resize(mapInIntegers.size());
for(unsigned int lindex = 0; lindex < mapInBlocks.size(); ++lindex)
{
mapInBlocks[lindex].resize(mapInIntegers[lindex].size());
}
for(unsigned int lindex = 0; lindex < mapInIntegers.size(); ++lindex)
{

for(unsigned int rindex = 0; rindex < mapInIntegers[rindex].size(); ++rindex)
{

switch (mapInIntegers[rindex][lindex])
{
case 0:
mapInBlocks[lindex][rindex].type = (blockType)0;
case 1:
mapInBlocks[lindex][rindex].type = (blockType)1;
}
}
}

return mapInBlocks;
}

void th::Map::closeFile()
{
mapFile.close();
}

void th::Map::loadFile(std::string locationOfNewMap)
{
mapFile.open(locationOfNewMap);
}

void th::Map::newMap(std::string locationOfNewMap, std::vector<std::vector<block>> newValues)
{
std::ofstream newFile;
newFile.open(locationOfNewMap);
if(newFile.good())
{
newFile << newValues.size();
newFile << " ";
newFile << newValues[0].size();
for(unsigned int lindex = 0; lindex < newValues.size(); ++lindex)
{
newFile << "/n";
for(unsigned int rindex = 0; rindex < newValues[lindex].size(); ++rindex)
{
newFile << newValues[lindex][rindex].type << " ";
}
}
}
}

std::vector<std::vector<block>> th::Map::tiledMap()
{
return mapInBlocks;
}
[/CODE]

The error comes up right here:
[CODE]
std::vector<std::vector<block>> th::Map::convertToBlocks()
{
mapInBlocks.resize(mapInIntegers.size());
for(unsigned int lindex = 0; lindex < mapInBlocks.size(); ++lindex)
{
mapInBlocks[lindex].resize(mapInIntegers[lindex].size());
}

/*After running through the first for loop below once, it returns:
Vector Subscript Out Of Range the second time :0!*/

for(unsigned int lindex = 0; lindex < mapInIntegers.size(); ++lindex)
{
for(unsigned int rindex = 0; rindex < mapInIntegers[rindex].size(); ++rindex)
{
switch (mapInIntegers[rindex][lindex])
{
case 0:
mapInBlocks[lindex][rindex].type = (blockType)0;
case 1:
mapInBlocks[lindex][rindex].type = (blockType)1;
}
}
}
return mapInBlocks;
}
[/CODE]

As I detail in the comment, in the latter code it loops through the for loop once before giving me the error. All help is appreciated. And if it's any consolation, here's what the file looks like:
File:
[CODE]
1 1
1
[/CODE]

All help is appreciated :)!

Share this post


Link to post
Share on other sites
[quote][code]for(unsigned int rindex = 0; rindex < mapInIntegers[rindex].size(); ++rindex)[/code][/quote]
That should be
[code]for(unsigned int rindex = 0; rindex < mapInIntegers[lindex].size(); ++rindex)[/code]

Also, there should be a `break; before `case 1:'.
[quote][code]switch (mapInIntegers[rindex][lindex])
{
case 0:
mapInBlocks[lindex][rindex].type = (blockType)0;
case 1:
mapInBlocks[lindex][rindex].type = (blockType)1;
}[/code][/quote]

Share this post


Link to post
Share on other sites
[quote][code] switch (mapInIntegers[rindex][lindex])[/code][/quote]
Shouldn't the indices be reversed, like everywhere else?

You should just go over your code and make sure you get all those details right.

Share this post


Link to post
Share on other sites
You solved it! My map is loading and displaying correctly now! I can't believe how trivial the problem was. Thank you so much! You're awesome, thank you so much for helping me :)! Cheers!

Share this post


Link to post
Share on other sites

This topic is 1854 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this