• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
xinfinite33

static std::deque inside of template class

3 posts in this topic

im having a problem with a static deque inside of one of my classes. i know that you have to initialize static members of a class before you can use them but i cant figure out how to initialize a static deque inside of a template class. a little help please?

 

#include <iostream>
#include <deque>

using namespace std;



template <typename T>
class jar
{
    public:
    T * value;
    static int jars;
    static deque<jar*> jarlist;

    template<typename S>
    jar(S obj) //constructor
    {
        this->value= &obj;
        jars++;
        jarlist.push_back(this);
    }

    void destroy() //destroys a jar
    {
        {
            typename deque<jar*>::iterator iter;

            for (iter=jarlist.begin();iter!=jarlist.end();iter++)
            {
                if(*iter==this)
                {
                    delete (*iter);
                    jarlist.erase(iter);
                }
            }
            jars--;
        }
    }

};

template<typename T> int jar<T>::jars=0;
template<typename T> deque<jar*> jar<T>::jarlist; // <---------------------PROBLEM HERE---------------

int main()
{
    int integer=3;
    jar A(integer);

    cout<<*(jar::jarlist.front())->value);

    return 0;
}

 

any help would be greatly appreciated

Edited by xinfinite33
0

Share this post


Link to post
Share on other sites

Below the class you could add:

 

template<typename T>
std::deque<jar<T>*> jar<T>::jarlist;
Edited by Nyssa
1

Share this post


Link to post
Share on other sites
Your constructor contains a bug, it stores a pointer to a local variable as a member. Consider passing a (const) reference, or passing the pointer explicitly.

The destroy function appears to be dangerous, as it attempts to delete objects which are not guaranteed to be allocated with new. Your example program contains this bug.

Your class should probably obey the rule of three, or you should implement a destructor and mark the class as non-copyable.

The "jars" static counter is probably unnecessary, as the deque knowns how many objects it contains.

Finally, such a design is usually unnecessary and the static member can be factored elsewhere, removing or exposing the state dependency. Edited by rip-off
1

Share this post


Link to post
Share on other sites

Yeah I know its buggy, I was mostly experimenting with templates and pointers as a way to make my own memory management system. It failed, miserably. I guess i should research things a bit more before jumping in head first wacko.png . The "rule of three" and the "non-copyable" articles were helpful, as I had no knowledge about those either. But thanks for the comments and suggestions! smile.png

0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0