public void run() {
		
		long desiredFPS = 500;
                long desiredDeltaLoop = (1000*1000*1000)/desiredFPS;
		
		long beginLoopTime;
		long endLoopTime;
		long currentUpdateTime = System.nanoTime();
		long lastUpdateTime;
		long deltaLoop;
		int deltaMs = 0;
		
		while(isRunning){
			beginLoopTime = System.nanoTime();
			
			window.panel.repaint();
			
			lastUpdateTime = currentUpdateTime;
			currentUpdateTime = System.nanoTime();
			
			onUpdateGame(deltaMs);
			
			deltaMs = (int) ((currentUpdateTime - lastUpdateTime)/(1000*1000));
			
			endLoopTime = System.nanoTime();
			deltaLoop = endLoopTime - beginLoopTime;
	        
	                if(deltaLoop > desiredDeltaLoop){
				//Do nothing. We are already late
			} else {
				try{
				      Thread.sleep((desiredDeltaLoop - deltaLoop)/(1000*1000));
	                        } catch (InterruptedException e) {
					//Do nothing
	                        }
	                     
	                }
		}
}

Hi,

I'm trying to implement a 2D game using the Java2D API. I'm using the code posted below in my run() method of my main thread to limit the framerate to a specific maximum.

Objects are moved by a distance calculated from the elapsed time between frames. The movement of said objects, however is noticeably jerky.

Could the problem be to do with the method used below? I've seen this type of thing used in several introductory examples to games in Java.

Many thanks.

Thanks for your reply. I have changed the delta argument to a double but unfortunately the jerky movement persists.

When you suggested not mixing nanoseconds/milliseconds/seconds, how would I avoid this? Presumably I need to use some sort of milli/nanosecond timer at some point and convert the returned value to seconds?

As well as the new code I've also posted an example of how an object's position is updated and then drawn using the delta argument in case there is an error in the logic on that end too.

The object's position is stored and calculated using doubles, but when it comes to drawing it I am forced to give integer x and y arguments to specify the pixel position - could this rounding lead to jerky movement?

Many thanks for your help so far.

public void run() {
		long desiredFPS = 60;
		long desiredDeltaLoop = (1000*1000*1000)/desiredFPS;
		
		long beginLoopTime;
		long endLoopTime;
		long currentUpdateTime = System.nanoTime();
		long lastUpdateTime;
		long deltaLoop;
		double deltaSec = 0;
		
		while (isRunning) {
			beginLoopTime = System.nanoTime();

			window.panel.repaint();

			lastUpdateTime = currentUpdateTime;
			currentUpdateTime = System.nanoTime();
			
			onUpdateGame(deltaSec);

			deltaSec = ((currentUpdateTime - lastUpdateTime) / 1000000000.0);
			
			endLoopTime = System.nanoTime();
			deltaLoop = endLoopTime - beginLoopTime;

			if (deltaLoop > desiredDeltaLoop) {
				// Do nothing. We are already late
			} else {
				try {
					Thread.sleep((desiredDeltaLoop - deltaLoop) / 1000000);
				} catch (InterruptedException e) {
					// Do nothing
				}
			}
		}
}

// position.x and position.y are doubles and 100 is the desired pixels/s to move
position.x += (GameApp.deltaMs * 100.0);
position.y += (GameApp.deltaMs * 100.0);

g2d.translate(position.x, position.y);
g2d.setColor(Color.GREEN);

g2d.fillRect(0, 0, 100, 100);

Thanks for the replies, I think you're right in your thinking regarding the capped fps/sleeping thread theory. Everything runs much smoother with an unlimited frame rate.

Interestingly I've noticed a similar problem whilst using Slick2D as well. As a quick fix for know I've set the limit to 200 so at least the GPU isn't spinning up too much. The lag spikes are now much less frequent.

I'll try it on my work laptop after Christmas to see how a completely different graphics card behaves.

Edit: As another point of interest, watching a video (YouTube in chrome) whilst playing the game causes serious lag issues, whilst simply pausing the video seems to be enough to avoid this.