Sign in to follow this  
superman3275

Do you believe it's okay to use type-casting with enums?

Recommended Posts

Recently, I've been using an enumeration called "tileType" when I load my map from a file. The file contains an array of numbers, so when I load a number I have to explicit type-cast it to the type "tileType" before I can load it into the Tow-Dimensional vector I use to keep my map's values. Is this okay? There's no other way unless I make a very specific switch statement, which would completely break if I changed anything the slightest bit, which wouldn't work.

 

What do you think? Sorry for the little information, I had to finish up quickly. Cheers :)!

Share this post


Link to post
Share on other sites
So long as the number corresponds to an actual value in the enum, it's safe. If you want to be pedantic you could switch on the integer (not the casted enumerated type), and have cases for the enumeration values (and a default case to catch invalid values) (at least I think this would be a viable option in your case; it's hard to tell without more info).

Share this post


Link to post
Share on other sites
How good it is and what other options you might have depend on factors like what the enum is supposed to represent, whether or not non-enumerated enum values are valid (such as with a bit flag enum), whether or not the file being loaded is text or binary, what language you are using and so on.

Share this post


Link to post
Share on other sites

Should be ok as long as you explicitly give each enum value a number, and then dont reuse that value later if you remove an enum.  You want to make sure what you saved will always be loaded as what it is, or not at all if it's deprecated.

Share this post


Link to post
Share on other sites
If youre worried about the values for some reason not matching you could make ab array of lenght x that contains enum values. So you can use that to convert them back and forth, ans can decide what enum corresponds to what integer.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this