• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
stitchs_login

Unity
'Completed' Pong Project; looking for Critique.

2 posts in this topic

Hey guys,

I have been working on this for about a month and half now, with two weeks spent on the first iteration and the last 3-4 on changes suggested by this wonderful community.

 

I have worked my way through the the list and am now (in loose quotations) finished. I am pleased with what I have learned on the way, and how I will take some of it forward. I also realise that my code was nowhere near what it should have been and have revised much of it.

 

There are still some issues:

  • Hard-coded/cumbersome state machine in Game.h (to be revised in next project)
  • Ball sprite appearing white (this is one I could use some advice on)
  • Game over text being highlighted incorrectly
  • Lack of sound/save functionality.
  • Players should probably by local to Game.h and opposed to Arena.h

 

 

Could I get you guys to try it out, and have a gander at the code as some new feedback would be excellent to take into the next project. Please find this below.

 

I write this late and will probably think of extra things, and add them tomorrow.

 

Regards,

 

Stitchs.

0

Share this post


Link to post
Share on other sites
I tried it out.
Nice pong game you have here, but you should seriously consider capping FPS.
Also when paddle can overlap numbers (when up most in screen), could reduce the playable terrain size to make area just for tracking stats.
Difference paddle color from the text color. (Just recolor the image)

Also if it took you one and a half month for this, i would ask how many work hours did you do a day? or/and are you still learning?

EDIT:: That AI so strong, i almost lost was like 5-4. I love it, great for lol's. Edited by BaneTrapper
0

Share this post


Link to post
Share on other sites
This reply is on the same lines as my [url="http://www.gamedev.net/topic/635214-pong-project-near-completion-looking-for-critique/#entry5006455"]earlier analysis[/url]. Many of the suggestions are stylistic in nature, but I believe that there are certain styles that are bug prone, difficult to read or that cause confusion. What I mean is that most of them are somewhat subjective, the important thing is that you've completed your project and are happy with it.
 
Here are some notes from a short review of the code. Where possible, I highlight a specific piece of code, but sometimes the underlying issue is present in multiple locations.
 
[code]
// np prefix to represent stack objects.
Arena npPongArena;
GUIMenu npMainMenu, npGameOverMenu;
[/code]
 
Member variables that are not pointers are not necessarily "stack" objects. After all, they may be located on the heap if the enclosing object(s) are dynamically allocated. I would question the need for a special prefix to such objects, since you don't appear to use it with builtin types or enumeration values.
 
[code]
int Game::RunGame()
{
    sf::RenderWindow gameWindow_(/ * ... */);
}
[/code]
Code conventions that use trailing underscores usually reserve them for member variables, not automatically allocated objects like this. 
Such a pre/post fix should have a specific reason. The point is not to decorate every symbol. It should highlight exceptional cases, such as pointers, references, member variables, global or static data. Automatic variables and value parameters are "easy", their declarations are usually visible, and they are more likely to stay in one's mind than some of the more complex examples I listed above.
 
[code]
MyHelper::FloatToString(frameRate_, true)
[/code]
Quick test: what does FloatToString do when passed false? Avoid boolean parameters where possible, particularly where the input is a literal. Better would be to use a enumeration of the desired behaviour:
[code]
enum FloatFormatting {
    FloatFormattingNone,
    FloatFormattingTruncate
};
 
MyHelper::FloatToString(frameRate_, MyHelper::FloatFormattingTruncate);
[/code]
But even still I would advise against trying to overload these two distinct behaviours into the same function. Let the caller use IntToString if necessary:
[code]
int truncatedFrameRate = static_cast<int>(frameRate_);
std::string whatever = IntToString(truncatedFrameRate);
[/code]
In this specific case, you might avoid this by not storing the frame rate as a float. Calculating the frame rate every single frame can lead to the frame rate being difficult to read if your frame times fluctuate. What I tend to do in my games is to maintain a frame counter and a timer, and when the timer exceeds a second I update the FPS string value.
 
[code]
GUIMenu::GUIMenu(sf::Vector2i position, int numOptionsIn, int firstSelectable)
[/code]
Mixing the "options" container with non-selectable options is confusing. I'd probably design this class to contain an (optional) "description" - which is text that would be printed above the options but is not considered selectable.
 
Alternatively, you could have the concept of a "MenuEntry", which might be selectable by default, but the caller can create a non-selectable instance too. This would allow you to, for example, have a main menu with "disabled" entries, such as a "Load Game" entry which is not selectable (and probably visually de-emphasised) until the user has created a save game:
[code]
class MenuEntry {
public:
     enum EntryState {
         Disabled,
         Enabled,
     };
 
     MenuEntry(const std::string &name, EntryState state = Enabled);
 
     // ...
};
 
class Menu {
public:
    Menu(/* ... */);
 
    void addEntry(const MenuEntry &entry);
 
    // ...
};
[/code]
 
[code]
// Loop through keys, without the need to check the event queue because
// I am using the Windows' GetInput(). I am unable to check with the
// the queue as this method is not called in the event polling loop.
// Instead, I just input the counter into the Code structure and see if
// it matches, in order to update curButtonState_.
// TODO: need to include a boolean check to see if a key has been pressed, before looping on every go.
[/code]
Consider having another function, HandleInput() or HandleEvent(), which can be called as part of the event polling loop. Right now, your polling loop discards all the events, and you go to great pains elsewhere to reconstruct this information.
 
[code]
sf::Sprite& Paddle::GetSprite()
{
    if(spriteLoaded_)
    {
        return paddleSprite_;
    }
}
[/code]
This is a bug. All code paths should always return a value. You need to heed compiler warnings about this. If your compiler doesn't warn you about this, turn the warnings up as far as they will go. Ideally, use the compiler switch "treat warnings as errors". 
 
[code]
void Paddle::OnWallCollision(sf::Vector2f &colAreaPosition, sf::Vector2f &colAreaDimensions)
{
    // ...
    return;
}
[/code]
This is really minor, but it is not necessary to put an explicit return as the last line in a function. Leaving one in flags in my mind because it makes me think that this should be nested in a condition or loop that you have forgotten.
 
[code]
if(!paddleImage_.LoadFromFile(filename))
{
    // Handle error...
}
else
{
    // Handle success...
}
[/code]
When you're covering both cases, it is easier to read the code if you write the "positive case" first:
[code]
if(paddleImage_.LoadFromFile(filename))
{
    // Handle success ...
}
else
{
    // Handle error...
}
[/code]
 
[code]
static sf::Image paddleImage_;
static bool imageLoaded_;
[/code]
This is fine for a small game. For larger games, you'll probably want to avoid relying on global state. Due to this state, it is actually difficult to unit test the Paddle class.
 
Also, having a member function LoadSprite() which simultaneously interacts with both the static class state and the instance state is confusing and suprising. It might be better to consider a static member function to initialise the static data, and then a member function to "apply" this to the Paddle instances.
 
Your Paddle code has lots of branches for handling the presence/absence of a loaded image. One alternative to this is to use a polymorphic type. Consider:
[code]
class PaddleRenderer {
public:
    virtual ~PaddleRenderer() {}
 
    virtual void render(const Paddle &paddle) = 0;
};
 
class PrimitivePaddleRenderer : public PaddleRenderer {
public:
    // Fill a rectangle at the paddle's position with the necessary colour
    virtual void render(const Paddle &paddle);
};
 
class ImagePaddleRenderer : public PaddleRenderer {
public:
    ImagePaddleRenderer(const sf::Image &image);
 
    // Fill a rectangle at the paddle's position with the necessary colour
    virtual void render(const Paddle &paddle);
     
private:
    // Maybe you need a sf::Sprite and/or a sf::Image here, I'm not too familiar with SFML
};
 
// Factory function
std::unique_ptr<PaddleRenderer> createRenderer() {
    sf::Image image;
    if(image.LoadFromFile("images/paddle")) {
        return std::unique_ptr<PaddleRenderer>(new ImagePaddleRenderer(image));
    }
 
    // It would be nice to log the I/O error here...
    return std::unique_ptr<PaddleRenderer>(new PrimitivePaddleRenderer());
}
[/code]
 
[code]
void OnWallCollision(sf::Vector2f &colAreaPosition, sf::Vector2f &colAreaDimensions);
[/code]
A position and dimensions? Sounds like a rectangle... Actually you do have a comment to this effect in Ball.h
 
[code]
//Paddle reference?
Paddle pPaddle_;
[/code]
This is inconsistent with the remainder of your coding convention.
 
[code]
Player::Player(/* ... */, Paddle &paddleIn)
{
    // ...
    pPaddle_ = paddleIn;
}
[/code]
You are copying the paddle here. This isn't necessarily wrong, but it is surprising. I hope that Paddle, and all its (recursive) members correctly handle being copied.
 
[code]
enum Direction2D
{
    DirNone, // Default direction
    DirUp, // Up
    DirDown, // Down
    DirLeft, // Left
    DirRight, // Right
    DirAxisX, // Represents the horizontal axis
    DirAxisY // Represents the vertical axis
};
[/code]
This appears to be two distinct enumerations hiding inside the same one. I'd prefer separate Direction and Axis enumerations.
 
[code]
class Arena
{
    // ...
    sf::Rect<float> arenaArea_;
    Ball npBall;
    std::vector<Player> players;
};
[/code]
I can't see any consistency in the naming convention here. sf::Rect<float>, Ball and std::vector<Player> are all user defined value types. These are all member variables. Why don't they all have a trailing underscore? Why don't they all have the "np" prefix?
2

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0

  • Similar Content

    • By NA-45
      EDIT: We've found a designer/composer and an artist.  I'm looking for one more artist!
       
      I'm currently working on Metroidvania style game that I was inspired to start by Hollow Knight and Beksiński's art.

       It's built in Unity using C# and has quite a bit done already.  I'm handling the programming myself and have a working model (besides combat which is a WIP) that can be expanded greatly depending on where we decide to take the project.  You can see the current test area here: https://streamable.com/mp5o8  Since I'm not artistically gifted, its all rectangles but can easily be skinned once we've desired on designs.
      I have professional experience using Unity and C# working on both a released game and a prototype as well as having extensive Java knowledge.  I also dabble in Python with a little bit of C++.
      I have worked on and completed many projects before, the most recent being a 2D stick fighting game written ground up in Java Swing (don't ask why): https://www.youtube.com/watch?v=V4Bkoyp_f0o
      I'm looking for a 2D artist (potentially more than one) to create concept and game art and a designer/writer who can help flesh out the story as well as map out and create challenging and eye catching areas.  I can handle most if not all of the programming side of things though if there is anyone who is extremely passionate about this sort of thing, I'd consider splitting the load.
      The end goal is a completed game that can be sold however profit isn't really a concern to me as it's mostly a labor of love from my part.  Any profits would be split between team members however that's pretty far off so don't make that a reason to join.
      ______________________________
      The story I have in mind is something like this:
      A man wakes up in a chasm that stretches seemingly endlessly in both directions lined with enormous statues.

       He discovers a temple with text above a closed gate that tells of the failed kingdom that lies below.  After finding a way around this, he drops down into the subterranean kingdom.  Adventuring through the labrynth below, he comes across different cities in which the residents succumbed to different sins such as Greed, Wrath, etc.  Each city tells a story of how its fixation on something lead to their demise leading up to a fight with the personification of their mistake.
      ______________________________
      An very rough idea for Waterways, a potential area:
       - To enter you must be wearing a pair of glasses that you find somewhere earlier in the ruins.  There are similar glasses found in every home.  Everything appears incredibly beautiful however something seems wrong.  After triggering some event, the glasses break and it's revealed that the glasses are made of some sort of stone that makes everything appear differently.  The city is in ruins and absolutely disgusting as everything was neglected.  
       - The only thing that remains intact is in the center of the city, an incredible statue of a goddess holding up a large sphere of the same material that was used for the glass.  You slowly learn the story behind the statue: the goddess came from the sea that the city lies on and brought prosperity to them.  
       - After opening up the the temple of the goddess that lies right on the edge of the waters, a giant sheet of the glass covers an opening in the back of the temple that reveals the goddess behind it.  You shatter the glass and it becomes apparent that the goddess is actually a disgusting creature half beached and mostly immobile that appears to secrete the material that makes up the glass. Fight ensues.
      ______________________________
      The combat is pretty up in the air and part of the reason I need a designer to bounce ideas off of but I think it will be something like this:
       - 4 orbs equipped at a time
       - 2 orbs selected at a time
       - Pressing the cast button will cast a spell determined by the 2 orbs that are selected
       - Spells cost mana however you can use spells with 0 mana and it will cost health instead
       - These spells in addition to being useful for combat, are the Metroidvania "gating" metchanic.  For instance, one of the conceptualized spells is a water orb + water orb to create a ice pillar that can be either used to block projectiles/enemy paths or to jump on to reach high areas
      ______________________________
      If you're interested or have any questions, contact me through discord.  My id is NA-45#3692. 
    • By sZokka
      Radio Rabbit
      DOWNLOAD:
      https://gamejolt.com/games/RadioRabbit/269209

      About The game
      Radio Rabbit is a local coop shoot ‘em up where two players control one more or less combined character. The character exists out of a rabbit’s body and a floating, still to the body connected, giant eye.
      Each player controls one of them.

      The rabbit’s goal is to fly safely through the level and to avoid enemies to reach the goal.  The Eye on the other hand can shoot. He is the one who clears the way. One character can move the other can shoot. So both player need to work together to fight of evil creatures and to complete the level.

      •    explore the level to find the key which activates the portal gate
      •    escape through the portal before the timer runs out
      •    if you are to slow, the nuke will explode
      •    use your character abilities, the rabbit can boost while the eye got the vision
      •    you’ll get more powerful abilities from items such as a supershot
      •    shoot as many enemies as possible to gain score
      •    remaining time at the end of each level gets added to the score
       

      Features
      •    2 Player couch coop
      •    4 level + tutorial
      •    an epic boss fight
      •    fully gamepad supported (XBox or equivalent)
      •    local high score
       
      Grab a friend and check it out!
      Please feel free to leave comments and feedback!
      DOWNLOAD:
      https://gamejolt.com/games/RadioRabbit/269209
      and ENJOY!
    • By qvertyVR
      Hello everyone! We are a small VR studio and we want to get some opinions about our new game which name is Gravity Tunnel VR. If you are interested please please visit our webside 👉 https://qverty.com/gravity-tunnel and let us know: -What do you think about it ? What we should to change? and Do you want to play this game? All opinions well see. -Second question is where we can find some small influencers who can play our game and say something about it? Do you know some people or places where we can find them and how contact them ? Do you have any experience about it? Thanks for all reply!
      Screens from our game :
       


    • By HolyByteGames
      Hey guys! Let me introduce to you a new mobile game Lumber Well. We was starting open beta. We need your feedback that helps make game better than it is.
      Sincerely, HolyByteGames Team.

      Contacts:
      holybytegames@gmail.com
      https://twitter.com/holybytegames
      https://www.instagram.com/holybytegames
    • By ilovegames
      The boy and the Golem were friends for a long time, and have traveled together.
      In search of the boy's father, they go to where he grew up, places now devastated by war.

      The player can at any time switch the characters and manage to solve a specific task.
      The boy is small and weak but is clever and an archer.
      Golem is big and strong, but slow, and prefers melees.

      The game includes the boom (required for archery) and apples (to restore his health). Golem Health is restored automatically. On the way our characters will encounter enemies and locked doors, and to open the door you must activate rock platforms nearby (decorated with blue stones that are activated by Golem from on the ground, and green that are activated from an arrow launched by the boy). Some doors will open only with simultaneous activation of a few (two or three) different types of stone platforms.

      Controls:

      Movement - W, A, S, D
      Switch character - Tab
      Direction of impact \ shot - mouse (cursor position)
      Attack:
      Golem - LMB
      Boy - When sandwiched RMB (Aim), press the LMB, for a shot
      Jump - Space



      TheBoyAndTheGolemSetup.exe
  • Popular Now