• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
stitchs_login

Unity
'Completed' Pong Project; looking for Critique.

2 posts in this topic

Hey guys,

I have been working on this for about a month and half now, with two weeks spent on the first iteration and the last 3-4 on changes suggested by this wonderful community.

 

I have worked my way through the the list and am now (in loose quotations) finished. I am pleased with what I have learned on the way, and how I will take some of it forward. I also realise that my code was nowhere near what it should have been and have revised much of it.

 

There are still some issues:

  • Hard-coded/cumbersome state machine in Game.h (to be revised in next project)
  • Ball sprite appearing white (this is one I could use some advice on)
  • Game over text being highlighted incorrectly
  • Lack of sound/save functionality.
  • Players should probably by local to Game.h and opposed to Arena.h

 

 

Could I get you guys to try it out, and have a gander at the code as some new feedback would be excellent to take into the next project. Please find this below.

 

I write this late and will probably think of extra things, and add them tomorrow.

 

Regards,

 

Stitchs.

0

Share this post


Link to post
Share on other sites
I tried it out.
Nice pong game you have here, but you should seriously consider capping FPS.
Also when paddle can overlap numbers (when up most in screen), could reduce the playable terrain size to make area just for tracking stats.
Difference paddle color from the text color. (Just recolor the image)

Also if it took you one and a half month for this, i would ask how many work hours did you do a day? or/and are you still learning?

EDIT:: That AI so strong, i almost lost was like 5-4. I love it, great for lol's. Edited by BaneTrapper
0

Share this post


Link to post
Share on other sites
This reply is on the same lines as my [url="http://www.gamedev.net/topic/635214-pong-project-near-completion-looking-for-critique/#entry5006455"]earlier analysis[/url]. Many of the suggestions are stylistic in nature, but I believe that there are certain styles that are bug prone, difficult to read or that cause confusion. What I mean is that most of them are somewhat subjective, the important thing is that you've completed your project and are happy with it.
 
Here are some notes from a short review of the code. Where possible, I highlight a specific piece of code, but sometimes the underlying issue is present in multiple locations.
 
[code]
// np prefix to represent stack objects.
Arena npPongArena;
GUIMenu npMainMenu, npGameOverMenu;
[/code]
 
Member variables that are not pointers are not necessarily "stack" objects. After all, they may be located on the heap if the enclosing object(s) are dynamically allocated. I would question the need for a special prefix to such objects, since you don't appear to use it with builtin types or enumeration values.
 
[code]
int Game::RunGame()
{
    sf::RenderWindow gameWindow_(/ * ... */);
}
[/code]
Code conventions that use trailing underscores usually reserve them for member variables, not automatically allocated objects like this. 
Such a pre/post fix should have a specific reason. The point is not to decorate every symbol. It should highlight exceptional cases, such as pointers, references, member variables, global or static data. Automatic variables and value parameters are "easy", their declarations are usually visible, and they are more likely to stay in one's mind than some of the more complex examples I listed above.
 
[code]
MyHelper::FloatToString(frameRate_, true)
[/code]
Quick test: what does FloatToString do when passed false? Avoid boolean parameters where possible, particularly where the input is a literal. Better would be to use a enumeration of the desired behaviour:
[code]
enum FloatFormatting {
    FloatFormattingNone,
    FloatFormattingTruncate
};
 
MyHelper::FloatToString(frameRate_, MyHelper::FloatFormattingTruncate);
[/code]
But even still I would advise against trying to overload these two distinct behaviours into the same function. Let the caller use IntToString if necessary:
[code]
int truncatedFrameRate = static_cast<int>(frameRate_);
std::string whatever = IntToString(truncatedFrameRate);
[/code]
In this specific case, you might avoid this by not storing the frame rate as a float. Calculating the frame rate every single frame can lead to the frame rate being difficult to read if your frame times fluctuate. What I tend to do in my games is to maintain a frame counter and a timer, and when the timer exceeds a second I update the FPS string value.
 
[code]
GUIMenu::GUIMenu(sf::Vector2i position, int numOptionsIn, int firstSelectable)
[/code]
Mixing the "options" container with non-selectable options is confusing. I'd probably design this class to contain an (optional) "description" - which is text that would be printed above the options but is not considered selectable.
 
Alternatively, you could have the concept of a "MenuEntry", which might be selectable by default, but the caller can create a non-selectable instance too. This would allow you to, for example, have a main menu with "disabled" entries, such as a "Load Game" entry which is not selectable (and probably visually de-emphasised) until the user has created a save game:
[code]
class MenuEntry {
public:
     enum EntryState {
         Disabled,
         Enabled,
     };
 
     MenuEntry(const std::string &name, EntryState state = Enabled);
 
     // ...
};
 
class Menu {
public:
    Menu(/* ... */);
 
    void addEntry(const MenuEntry &entry);
 
    // ...
};
[/code]
 
[code]
// Loop through keys, without the need to check the event queue because
// I am using the Windows' GetInput(). I am unable to check with the
// the queue as this method is not called in the event polling loop.
// Instead, I just input the counter into the Code structure and see if
// it matches, in order to update curButtonState_.
// TODO: need to include a boolean check to see if a key has been pressed, before looping on every go.
[/code]
Consider having another function, HandleInput() or HandleEvent(), which can be called as part of the event polling loop. Right now, your polling loop discards all the events, and you go to great pains elsewhere to reconstruct this information.
 
[code]
sf::Sprite& Paddle::GetSprite()
{
    if(spriteLoaded_)
    {
        return paddleSprite_;
    }
}
[/code]
This is a bug. All code paths should always return a value. You need to heed compiler warnings about this. If your compiler doesn't warn you about this, turn the warnings up as far as they will go. Ideally, use the compiler switch "treat warnings as errors". 
 
[code]
void Paddle::OnWallCollision(sf::Vector2f &colAreaPosition, sf::Vector2f &colAreaDimensions)
{
    // ...
    return;
}
[/code]
This is really minor, but it is not necessary to put an explicit return as the last line in a function. Leaving one in flags in my mind because it makes me think that this should be nested in a condition or loop that you have forgotten.
 
[code]
if(!paddleImage_.LoadFromFile(filename))
{
    // Handle error...
}
else
{
    // Handle success...
}
[/code]
When you're covering both cases, it is easier to read the code if you write the "positive case" first:
[code]
if(paddleImage_.LoadFromFile(filename))
{
    // Handle success ...
}
else
{
    // Handle error...
}
[/code]
 
[code]
static sf::Image paddleImage_;
static bool imageLoaded_;
[/code]
This is fine for a small game. For larger games, you'll probably want to avoid relying on global state. Due to this state, it is actually difficult to unit test the Paddle class.
 
Also, having a member function LoadSprite() which simultaneously interacts with both the static class state and the instance state is confusing and suprising. It might be better to consider a static member function to initialise the static data, and then a member function to "apply" this to the Paddle instances.
 
Your Paddle code has lots of branches for handling the presence/absence of a loaded image. One alternative to this is to use a polymorphic type. Consider:
[code]
class PaddleRenderer {
public:
    virtual ~PaddleRenderer() {}
 
    virtual void render(const Paddle &paddle) = 0;
};
 
class PrimitivePaddleRenderer : public PaddleRenderer {
public:
    // Fill a rectangle at the paddle's position with the necessary colour
    virtual void render(const Paddle &paddle);
};
 
class ImagePaddleRenderer : public PaddleRenderer {
public:
    ImagePaddleRenderer(const sf::Image &image);
 
    // Fill a rectangle at the paddle's position with the necessary colour
    virtual void render(const Paddle &paddle);
     
private:
    // Maybe you need a sf::Sprite and/or a sf::Image here, I'm not too familiar with SFML
};
 
// Factory function
std::unique_ptr<PaddleRenderer> createRenderer() {
    sf::Image image;
    if(image.LoadFromFile("images/paddle")) {
        return std::unique_ptr<PaddleRenderer>(new ImagePaddleRenderer(image));
    }
 
    // It would be nice to log the I/O error here...
    return std::unique_ptr<PaddleRenderer>(new PrimitivePaddleRenderer());
}
[/code]
 
[code]
void OnWallCollision(sf::Vector2f &colAreaPosition, sf::Vector2f &colAreaDimensions);
[/code]
A position and dimensions? Sounds like a rectangle... Actually you do have a comment to this effect in Ball.h
 
[code]
//Paddle reference?
Paddle pPaddle_;
[/code]
This is inconsistent with the remainder of your coding convention.
 
[code]
Player::Player(/* ... */, Paddle &paddleIn)
{
    // ...
    pPaddle_ = paddleIn;
}
[/code]
You are copying the paddle here. This isn't necessarily wrong, but it is surprising. I hope that Paddle, and all its (recursive) members correctly handle being copied.
 
[code]
enum Direction2D
{
    DirNone, // Default direction
    DirUp, // Up
    DirDown, // Down
    DirLeft, // Left
    DirRight, // Right
    DirAxisX, // Represents the horizontal axis
    DirAxisY // Represents the vertical axis
};
[/code]
This appears to be two distinct enumerations hiding inside the same one. I'd prefer separate Direction and Axis enumerations.
 
[code]
class Arena
{
    // ...
    sf::Rect<float> arenaArea_;
    Ball npBall;
    std::vector<Player> players;
};
[/code]
I can't see any consistency in the naming convention here. sf::Rect<float>, Ball and std::vector<Player> are all user defined value types. These are all member variables. Why don't they all have a trailing underscore? Why don't they all have the "np" prefix?
2

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0

  • Similar Content

    • By NajeNDa
      Hi there,
      I am a game programmer (C#/C++) who is looking for a project to join. I am computer science engineer plus Master Degree in Game Development, currently working in one the most renown mobile games company (2 years academic experience, 1 year working experience).
      I have developed several prototypes or even games almost ready to release, but I always lack of artists, so I am looking for a project already set up or few artist to begin working in something.
      My preferences are:
      Unity or Unreal Engine 4 based project (UE4 prefered) PC/Console game prefered but mobile is acceptable Not interested in VR Serious team with almost all the roles filled or pretending to be filled 3D project prefered over Sprites Guaranteed 7 work hours per week, Crunch 20 work hours per week  European team (if timezone is not a problem for you, so it is not for me) I am not looking for any kind of money income from games neither the team, I want to do this as a hobby and a way to improve my skills.
      Cheers
    • By OPNeonGames
      SumiKen : Ink Blade Samurai is released! Download and leave a review to help support the game!
      Download here for free : https://play.google.com/store/apps/details?id=com.OPNeon.SumiKen&hl=en

      ★★★★★ - "Just get it it's the best runner!" - Icatsasha
      ★★★★★ - "Great game, wonderful art! Super addictive!" - EZk1ll 
      A casual samurai runner game with seven samurai and beautiful mountain paintings. Join Sumi and his samurai companions on this epic path to slash & dash through endless hordes of enemy lines. Beware of the enemy blades as a single blow from the sword blade will end it all. Will you be turned into faded ink? Or will you train and become a samurai legend?
       
    • By OPNeonGames
      Hey guys, posting my work in progress for Macho Cat here. 

      A very early prototype for Macho Cat. Everything is just placeholder for now
      What is Macho Cat?
      A silly little game where you scrub the macho cat with random objects found in trash and junkyard to please him
      Gameplay feature?
      -Cat scrubbin, lots of scrubbin
      -Unlock moar objects in junkyard 
      -Funny, silly and easy
      When will the game release?
      December 2017 (estimate)
      Interested to Beta test?
      opneongame@gmail.com
    • By MCKillerZ1
      UNITY ENGINE
      IN SEARCH FOR MEMBERS
       
      Hey there. I am currently looking for at least 4 members ( for now ) to join me in making games together.
      Sure, I'm still a student ( 17 years old ) but this is what I wish to achieve in the future.
       
      My goal is simple:
      :- Create my own game development team consisting of 5 members total.
      :- Work together as a team, and also learn game related things together.
      :- Successfully finish a simple game, and upload it to any source ( Google Play, Steam, Origin, etc... )
      :- Gain popularity as a team over the time.
       
      My role in the team is the producer or manager, or maybe the leader.
      I do have talent regarding to creating games. My main ability is creating 3D Models via SketchUp, and I've had experience doing it for about 2-3 years.
      I did learn a bit of programming, but I only understand the basics of it. I can't really make a functioning program.
      Currently, I'm learning the basics of making music using FL Studio 12, and I will learn basic animation, level design and character modelling in the future.
       
      Requirements To Join:
      1. Good English communicating skills.
      2. Always online whenever needed.
      3. Good internet connection/speed.
      4. Have a decent computer/laptop.
      5. At least knows the basics of game development related topics.
      6. Have a good camera and a set of headphones with mic, or just regular mic ( needed in the future ).
       
      Roles Available:
      1. Programmer - Main language is C#, but can also use Java ( I recommend C# ).
      2. Music Producer - Can create music according to the game's settings, and also create sounds.
      3. Animator - Can do decent animation of characters, vehicles and more.
      4. Graphics Designer - Able to do colour schemes, 2D sprites and more.
       
      Send me a message if interested.
       
       
    • By OPNeonGames
      Hey guys, posting my work in progress for Macho Cat here. 

      A very early prototype for Macho Cat. Everything is just placeholder for now
      What is Macho Cat?
      A silly little game where you scrub the macho cat with random objects found in trash and junkyard to please him
      Gameplay feature?
      -Cat scrubbin, lots of scrubbin
      -Unlock moar objects in junkyard 
      -Funny, silly and easy
      When will the game release?
      December 2017 (estimate)
      Interested to Beta test?
      opneongame@gmail.com
  • Popular Now