• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
lucky6969b

How to improve this dumb pixel shader?

1 post in this topic

//Pixel Shader
float4 ps_lighting(VS_OUTPUT IN) : COLOR0
{
	//float4 color = tex2D(DiffuseSampler, IN.tex0);
 
	//opacity
	float opacity = GlobalOpacity; //default is global opacity

	//diffuse
	float4 color = float4(diffuseColor); //default diffusecolor
 

	color = lerp(color, color*IN.color, VertexDiffuse);

	//Create Light Calculations
	CreateLights( IN.worldSpacePos ); // fill lightstruct array DOES NOT WORK IN VERTEX SHADER, MUST HAPPEN IN PIXEL SHADER! ~0_o>

	float3 normal = IN.worldNormal; //default worldspace vertex normal

	normal = normalize( normal );

 	//Diffuse Fresnel
	
	float diffusefresnel = saturate(diffuseFresnelMult*fresnel(normal, IN.eyeVec, diffuseFresnelPower, 0));
	color = lerp(color, diffusefresnelColor, diffusefresnel);
	 
	//Light Loop
	float4 ambient = { 1.0f, 1.0f, 1.0f, 1.0f };
 	ambient = float4(ambientcolor, 1.0f);
 	float4 totaldiffuse =  ambient; //start off with ambient color

	for(int i = 0; i < numberOfActiveLights; ++i) //for loop to iterate over our 3 lights
	{
		//	float4 emissive = lightsarray[i].ke;
		float diffuse;

	    //ambient = lightsarray[i].ka*ambientcolor;
		
		float3 L = normalize(-lightDirection);

		// Spot light
		diffuse = diffuselight(normal,lightsarray[i].LightVec);
		 
		// Directional light
		//diffuse = diffuselight(normal,L);

		totaldiffuse += (diffuse*lightsarray[i].LightColor);
 
	}
	 
	//Apply Lighting
	
	float4 ret = color; // our final returned color starts as unlit diffuse color
	 
	ret = float4(pow(ret.x,Gamma),pow(ret.y,Gamma),pow(ret.z,Gamma),ret.a);
 	ret.a = opacity; // finally set opacity
	ret.rgb*=(totaldiffuse); //multiply diffuse with color
	ret = pow(ret,1.0/Gamma);
	
	return ret; //all done, return result :)
	 
}

The logic is this.
1) Setting global opacity to 1.0
2) Interpolate the color from the vertex shader (IN.color) with the global material color(diffuseColor)
3) Create lights and normal for each vertex
4) Calculate total diffuse by multiplying the normal of the vertex with the light direction
5) Multiply the interpolated color with the total diffuse value(light)
6) Output the pixel

It looks real dumb like this, and the image is really jagged

How do I improve it? Any good ideas?
Thanks
Jack Edited by lucky6969b
0

Share this post


Link to post
Share on other sites
It is hard to give you precise advices since you don't show the code for few of your functions.

However, there is something funny going on with the gamma correction. As far as I know, if you do your calculations in linear space you can skip all the gamma correction in the shader, assuming that the texture read gives you a texture color in linear space and that the back buffer is in SRGB format.

[Edit]

It seems that you don't calculate the specular factor or that you calculate it incorrectly.

Cheers! Edited by kauna
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0