• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
gretty

Obtain Device Information Set for Monitors: Returned Handle is always INVALID_HANDLE_VALUE

2 posts in this topic

Hello

 

I am attempting to list the device information for all the monitors currently connected to the computer. I have a function that can do this and its 90% done except when I go to call the function SetupDiGetClassDevs() with the 2nd parameter set(not NULL) then the function always fails(returns INVALID_HANDLE_VALUE).

 

When I call GetLastError() I get the error 13(decimal), ie, "The data is invalid" which I am not sure what that means?

What is going wrong? Can you provide any advice on whats happening and how I can fix it?

Function Information:

HDEVINFO SetupDiGetClassDevs(
      _In_opt_  const GUID *ClassGuid,
      _In_opt_  PCTSTR Enumerator,     // According to MSDN this param MUST be set if I want Device Information for a specific class(Monitors)
      _In_opt_  HWND hwndParent,
      _In_      DWORD Flags
    );

 


My function that attempts to get a Device Information Set for Monitors only and output each monitors details(the error line is commented):

void printDeviceData(GUID guID)
    {
        // Device Classes:        http://msdn.microsoft.com/en-us/library/windows/hardware/ff553426
        // System Device Classes: http://msdn.microsoft.com/en-us/library/windows/hardware/ff553428
        // Monitor Class GUI:     {4d36e96e-e325-11ce-bfc1-08002be10318}
    
        DWORD dataT                    = 0;
        PCTSTR monitorGuID             = _T("");
        SP_DEVINFO_DATA deviceInfoData = {0};
        deviceInfoData.cbSize          = sizeof(SP_DEVINFO_DATA);
        deviceInfoData.ClassGuid       = guID;
    
        // Step 1: Get Device Information Set for Monitors only
        // ERROR OCCURS HERE: SetupDiGetClassDevs() always fails
        // Also tried these values for param 2: "Monitor" "PCI" but all cause the function to return INVALID_HANDLE_VALUE
        HDEVINFO hDevInfo = SetupDiGetClassDevs(&guID, _T("{4d36e96e-e325-11ce-bfc1-08002be10318}"), NULL, DIGCF_PRESENT | DIGCF_DEVICEINTERFACE);
        if (hDevInfo == INVALID_HANDLE_VALUE) {
            //outputLastError(_T("Fail 1"));
            printf("hDevInfo == INVALID_HANDLE_VALUE\n");
            return;
        }
        else printf("SUCCESS 1\n");
    
        if (SetupDiGetSelectedDevice(hDevInfo, &deviceInfoData) == FALSE) {
            //outputLastError(_T("SetupDiGetSelectedDevice(hDevInfo, &deviceInfoData) == FALSE"));
            printf("SetupDiGetSelectedDevice(hDevInfo, &deviceInfoData) == FALSE, %d, %x\n", GetLastError(), GetLastError());
            return;
        }
        else printf("SUCCESS 2\n");
    
        // Step 2: For each Monitor: Output Device information
        const unsigned int FLAG_NUM = 30;
        DWORD flags[] = {SPDRP_FRIENDLYNAME, SPDRP_ENUMERATOR_NAME, SPDRP_PHYSICAL_DEVICE_OBJECT_NAME, SPDRP_DEVICEDESC,
                            SPDRP_ADDRESS, SPDRP_BUSNUMBER, SPDRP_BUSTYPEGUID, SPDRP_CHARACTERISTICS, SPDRP_CLASS, SPDRP_CLASSGUID,
                            SPDRP_COMPATIBLEIDS, SPDRP_CONFIGFLAGS, SPDRP_DEVICE_POWER_DATA, SPDRP_DEVTYPE, SPDRP_DRIVER,
                            SPDRP_ENUMERATOR_NAME, SPDRP_EXCLUSIVE, SPDRP_HARDWAREID, SPDRP_INSTALL_STATE, SPDRP_LEGACYBUSTYPE,
                            SPDRP_LOCATION_INFORMATION, SPDRP_LOCATION_PATHS, SPDRP_LOWERFILTERS, SPDRP_MFG,
                            SPDRP_PHYSICAL_DEVICE_OBJECT_NAME, SPDRP_UI_NUMBER, SPDRP_UI_NUMBER_DESC_FORMAT, SPDRP_UPPERFILTERS,
                            SPDRP_SECURITY_SDS, SPDRP_SECURITY, SPDRP_SERVICE };
    
        for (int i=0; i<=FLAG_NUM; i++) {
            DWORD buffersize = 0;
            LPTSTR buffer    = NULL;
    
            while (!SetupDiGetDeviceRegistryProperty(hDevInfo,  &deviceInfoData, flags[i], &dataT,
                                                        (PBYTE)buffer, buffersize, &buffersize))
            {
                if (GetLastError() == ERROR_INSUFFICIENT_BUFFER) {
                    // Change the buffer size.
                    if (buffer)
                        LocalFree(buffer);
                    buffer = (LPTSTR)LocalAlloc(LPTR, buffersize);
                }
                else {
                    // Insert error handling here.
                    break;
                }
            }
    
            printf("Data: %d: %s\n", i, buffer);
            if (buffer)
                LocalFree(buffer);
        }
    
        SetupDiDestroyDeviceInfoList(hDevInfo);
    }
Edited by gretty
0

Share this post


Link to post
Share on other sites

Thanks, removing that flag and using "PCI" as the enumerator works now. But I am not sure PCI is the correct enumator value I should be using?

 

If I want to obtain Device Information for all Monitors, what enumerator should I use? MSDN doesn't list all possible enumerator values.

 

So far I have tried "Monitor" and "{4d36e96e-e325-11ce-bfc1-08002be10318}" but that causes the same error "data is invalid"

0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0