• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Neosettler

OpenGL
GLSL: Unique shader and Data Corruption!

12 posts in this topic

Greetings, OpenGL Masters,

 

I've been using a unique shader for several years without problem and suddenly, between minors renderer modification and NVidia drivers upgrades, something went terribly wrong.

 

My shader is fairly complex but it can render any geometry with any material properties and light count. (I’m aware that this is not optimal but it’s very easy to maintain).

 

For instance, I do skinning like so:

 

uniform int u_DeformerCount;

in vec4 a_Weights;

in ivec4 a_Deformers;

uniform mat4 u_XFormMatrix[40]; /// Deformation matrices.

 

                if (u_DeformerCount > 0) /// Matrix deformations.

                {

                                mat4 l_deformer;

                               

                                for (int i = 0; i < 4; ++i) /// Maximum of 4 influences per vertex.

                                {

                                                l_deformer += a_Weights[i] * u_XFormMatrix[a_Deformers[i]];

 

SNIP....

                }

 

The problem:
While everything works without a glitch when u_DeformerCount > 0, there seems to be data corruption with geometries that doesn’t have the skinning condition enabled. I’m basically getting black frames frequently, like a kid playing with the light interrupter.

 

Now, I can make the problem disappeared by using u_XFormMatrix[0] instead of u_XFormMatrix[a_Deformers[i]]... I tried everything I could think of so far to fix this and I’m at the point where I could use Jedi Master’s wisdom.

 

- How could a part of the shader that is not used explicitly affect its output?

- Any known pitfall using uniform arrays?

 

PS: The major downside of a unique shader is that every uniforms needs to be set/reset every draw and I’m guessing it could be the source of my problem.

0

Share this post


Link to post
Share on other sites

GPUs tend to compute both sides of an 'if' statement (true and false cases) then after it has done this it picks the side that matches the 'if' statement outcome. It does this because of how parallel processing is handled and doesn't really behave like 'if' statements on the CPU. So my guess would be your having errors because it's reading uninitialized data from "a_Deformers" then accessing data beyond the array bounds of "u_XFormMatrix". Try giving your data default values and see if your errors continue.

 

For example, when a mesh doesn't need skinning set all values of "a_Deformers" to zero, that way its elements are within your array bounds of "40". 

Edited by Nyssa
2

Share this post


Link to post
Share on other sites
Thx for your suggestion Nyssa,
For example, when a mesh doesn't need skinning set all values of "a_Deformers" to zero, that way its elements are within your array bounds of "40". 

Did you have in mind setting all values using glVertexAttribIPointer or in the shader some how?

EDIT: can't assign to varying in the shader. I'm guessing you meant glVertexAttribIPointer. PS: I do use glDisableVertexAttribArray a_Deformers when no skinning is needed. Still digging. Edited by Neosettler
0

Share this post


Link to post
Share on other sites

If you were to do it from the shader then it would have to be via the preprocessor. For example:

#ifdef USE_SKINNING
if (u_DeformerCount > 0) /// Matrix deformations.
{
      mat4 l_deformer;
                               
      for (int i = 0; i < 4; ++i) /// Maximum of 4 influences per vertex.
      {
           l_deformer += a_Weights[i] * u_XFormMatrix[a_Deformers[i]];
      }
}
#endif

 

This has the bonus of removing code that is not needed for non skinned objects and may speed up your application a little.

 

Otherwise you can do it on the CPU during your programs initialization. If you have access to the raw vertex array data before it enters OpenGL then I'd simply change the values there to zero (EDIT : or remove them entirely!). Otherwise you would need to access it from OpenGL using a function like "glMapBuffer" and changing the values from there.

Edited by Nyssa
2

Share this post


Link to post
Share on other sites

Using glVertexAttribIPointer or glDisableVertexAttribArray isn't going to help on its own cause "a_Deformers" will still be uninitialized if you don't update your shader code aswell to remove the skinning portion.

0

Share this post


Link to post
Share on other sites

Interesting, I was not aware we could do preprocessor #if. Is this a GLSL feature or you need to parse your shader and string edit it?

 

This has the bonus of removing code that is not needed for non skinned objects and may speed up your application a little.
Otherwise you can do it on the CPU during your programs initialization. If you have access to the raw vertex array data before it enters OpenGL then I'd simply change the values there to zero (EDIT : or remove them entirely!)


I agree but unless I’m missing something, while these seems to be valid solutions, it will make the unique shader concept collapse as we might alternate the skinning condition every draw.
 

Otherwise you would need to access it from OpenGL using a function like "glMapBuffer" and changing the values from there


This seems to be to most logical direction. The shader uses glBufferSubData for the vertex attributes, I’ll have to investigate glMapBuffer… this is puzzling. Thanks again for your inputs Nyssa.

 

0

Share this post


Link to post
Share on other sites

I believe preprocessing was available in glsl from version 1.10 (I think). EDIT : Check out the GLSL spec from page 9 here. And glBufferSubData is similar to glMapBuffer, you could use either one I guess.

 

 

I agree but unless I’m missing something, while these seems to be valid solutions, it will make the unique shader concept collapse as we might alternate the skinning condition every draw.

 

This is true. Is the idea of your unique shader to use the same shader for every object? While I understand the simplicity of that, it would result in alot of redundant calculations (such as skinning for non skinned objects). You could group skinned and non skinned objects together for rendering so there is no alternating?

 

A similar approach to what you're doing is called an Uber shader. Basically a shader with all possible combinations in it and uses alot of #defines to create the shader that's needed.

Edited by Nyssa
0

Share this post


Link to post
Share on other sites

If I'm going down that route I prefer a collection of "mini-uber" shaders.  Instead of one single great-big-whopping shader for everything, isolate out maybe 4 to 5 different types of object - something like unskinned mesh, skinned mesh, particles, 2D GUI, or whatever - then build an uber shader for each of those.  Using GLSL's compilation model you can quite easily insert snippets of common code too, so if your lighting model needs to be shared between more than one shader type, just split it off and add it to your array of GLchar * passed to glShaderSource.  That seems a bit more work on the C/C++ end of things, but you'll find it much more flexible than what you currently have.

0

Share this post


Link to post
Share on other sites
GPUs tend to compute both sides of an 'if' statement (true and false cases) then after it has done this it picks the side that matches the 'if' statement outcome.

 

This depends very much on the GPU in question; anything in the last few years will have true branching support and only execute the code required by the outcome of the conditional compare the executing work group.

 

That means that if all your threads in the work group evaluate to 'true' it will ONLY take the true path, if 'false' then only the false path.

Now, if some threads are true and some are false then it will execute both paths BUT the GPU will mask out threads which aren't required to execute as such they have no impact on the running of the other threads.

2

Share this post


Link to post
Share on other sites
This is true. Is the idea of your unique shader to use the same shader for every object?

Yes indeed,
While I understand the simplicity of that, it would result in alot of redundant calculations

Well, I was under the impression a if statement is a if statement... apparently, the portion inside a condition that is not being use has to be considered has if it was in order for the shader to render correctly. Strangely, the bug is not constant and very hard to track. I did noticed however that it rendered correctly when removing few objects from my scene which use no textures. I must be missing something.

...digging the uber shader.
0

Share this post


Link to post
Share on other sites

As Phantom mentioned on newer cards your if statements would perform more like CPU if statements. But from the sounds of it your card might be a few years old so Uber shaders might be your answer. Like most good things in life there is a down side to them, they can become a bit of a nightmare to manage the larger they get.

 

Try to run your program through an app like gDEbugger or GPU PerfStudio so you can see what data OpenGL is receiving. Makes debugging a bit easier. Some objects might be overwriting uniform buffer data or something.

0

Share this post


Link to post
Share on other sites
very good find Nyssa with the gDEBugger, Nice tool! It turns out that my glitch was caused by the lack of calling glFinish!

case closed. thank you all for your inputs.

Cheers!
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0

  • Similar Content

    • By Toastmastern
      So it's been a while since I took a break from my whole creating a planet in DX11. Last time around I got stuck on fixing a nice LOD.
      A week back or so I got help to find this:
      https://github.com/sp4cerat/Planet-LOD
      In general this is what I'm trying to recreate in DX11, he that made that planet LOD uses OpenGL but that is a minor issue and something I can solve. But I have a question regarding the code
      He gets the position using this row
      vec4d pos = b.var.vec4d["position"]; Which is then used further down when he sends the variable "center" into the drawing function:
      if (pos.len() < 1) pos.norm(); world::draw(vec3d(pos.x, pos.y, pos.z));  
      Inside the draw function this happens:
      draw_recursive(p3[0], p3[1], p3[2], center); Basically the 3 vertices of the triangle and the center of details that he sent as a parameter earlier: vec3d(pos.x, pos.y, pos.z)
      Now onto my real question, he does vec3d edge_center[3] = { (p1 + p2) / 2, (p2 + p3) / 2, (p3 + p1) / 2 }; to get the edge center of each edge, nothing weird there.
      But this is used later on with:
      vec3d d = center + edge_center[i]; edge_test[i] = d.len() > ratio_size; edge_test is then used to evaluate if there should be a triangle drawn or if it should be split up into 3 new triangles instead. Why is it working for him? shouldn't it be like center - edge_center or something like that? Why adding them togheter? I asume here that the center is the center of details for the LOD. the position of the camera if stood on the ground of the planet and not up int he air like it is now.

      Full code can be seen here:
      https://github.com/sp4cerat/Planet-LOD/blob/master/src.simple/Main.cpp
      If anyone would like to take a look and try to help me understand this code I would love this person. I'm running out of ideas on how to solve this in my own head, most likely twisted it one time to many up in my head
      Thanks in advance
      Toastmastern
       
       
    • By fllwr0491
      I googled around but are unable to find source code or details of implementation.
      What keywords should I search for this topic?
      Things I would like to know:
      A. How to ensure that partially covered pixels are rasterized?
         Apparently by expanding each triangle by 1 pixel or so, rasterization problem is almost solved.
         But it will result in an unindexable triangle list without tons of overlaps. Will it incur a large performance penalty?
      B. A-buffer like bitmask needs a read-modiry-write operation.
         How to ensure proper synchronizations in GLSL?
         GLSL seems to only allow int32 atomics on image.
      C. Is there some simple ways to estimate coverage on-the-fly?
         In case I am to draw 2D shapes onto an exisitng target:
         1. A multi-pass whatever-buffer seems overkill.
         2. Multisampling could cost a lot memory though all I need is better coverage.
            Besides, I have to blit twice, if draw target is not multisampled.
       
    • By mapra99
      Hello

      I am working on a recent project and I have been learning how to code in C# using OpenGL libraries for some graphics. I have achieved some quite interesting things using TAO Framework writing in Console Applications, creating a GLUT Window. But my problem now is that I need to incorporate the Graphics in a Windows Form so I can relate the objects that I render with some .NET Controls.

      To deal with this problem, I have seen in some forums that it's better to use OpenTK instead of TAO Framework, so I can use the glControl that OpenTK libraries offer. However, I haven't found complete articles, tutorials or source codes that help using the glControl or that may insert me into de OpenTK functions. Would somebody please share in this forum some links or files where I can find good documentation about this topic? Or may I use another library different of OpenTK?

      Thanks!
    • By Solid_Spy
      Hello, I have been working on SH Irradiance map rendering, and I have been using a GLSL pixel shader to render SH irradiance to 2D irradiance maps for my static objects. I already have it working with 9 3D textures so far for the first 9 SH functions.
      In my GLSL shader, I have to send in 9 SH Coefficient 3D Texures that use RGBA8 as a pixel format. RGB being used for the coefficients for red, green, and blue, and the A for checking if the voxel is in use (for the 3D texture solidification shader to prevent bleeding).
      My problem is, I want to knock this number of textures down to something like 4 or 5. Getting even lower would be a godsend. This is because I eventually plan on adding more SH Coefficient 3D Textures for other parts of the game map (such as inside rooms, as opposed to the outside), to circumvent irradiance probe bleeding between rooms separated by walls. I don't want to reach the 32 texture limit too soon. Also, I figure that it would be a LOT faster.
      Is there a way I could, say, store 2 sets of SH Coefficients for 2 SH functions inside a texture with RGBA16 pixels? If so, how would I extract them from inside GLSL? Let me know if you have any suggestions ^^.
    • By KarimIO
      EDIT: I thought this was restricted to Attribute-Created GL contexts, but it isn't, so I rewrote the post.
      Hey guys, whenever I call SwapBuffers(hDC), I get a crash, and I get a "Too many posts were made to a semaphore." from Windows as I call SwapBuffers. What could be the cause of this?
      Update: No crash occurs if I don't draw, just clear and swap.
      static PIXELFORMATDESCRIPTOR pfd = // pfd Tells Windows How We Want Things To Be { sizeof(PIXELFORMATDESCRIPTOR), // Size Of This Pixel Format Descriptor 1, // Version Number PFD_DRAW_TO_WINDOW | // Format Must Support Window PFD_SUPPORT_OPENGL | // Format Must Support OpenGL PFD_DOUBLEBUFFER, // Must Support Double Buffering PFD_TYPE_RGBA, // Request An RGBA Format 32, // Select Our Color Depth 0, 0, 0, 0, 0, 0, // Color Bits Ignored 0, // No Alpha Buffer 0, // Shift Bit Ignored 0, // No Accumulation Buffer 0, 0, 0, 0, // Accumulation Bits Ignored 24, // 24Bit Z-Buffer (Depth Buffer) 0, // No Stencil Buffer 0, // No Auxiliary Buffer PFD_MAIN_PLANE, // Main Drawing Layer 0, // Reserved 0, 0, 0 // Layer Masks Ignored }; if (!(hDC = GetDC(windowHandle))) return false; unsigned int PixelFormat; if (!(PixelFormat = ChoosePixelFormat(hDC, &pfd))) return false; if (!SetPixelFormat(hDC, PixelFormat, &pfd)) return false; hRC = wglCreateContext(hDC); if (!hRC) { std::cout << "wglCreateContext Failed!\n"; return false; } if (wglMakeCurrent(hDC, hRC) == NULL) { std::cout << "Make Context Current Second Failed!\n"; return false; } ... // OGL Buffer Initialization glClear(GL_DEPTH_BUFFER_BIT | GL_COLOR_BUFFER_BIT); glBindVertexArray(vao); glUseProgram(myprogram); glDrawElements(GL_TRIANGLES, indexCount, GL_UNSIGNED_SHORT, (void *)indexStart); SwapBuffers(GetDC(window_handle));  
  • Popular Now