Sign in to follow this  

OpenGL GLSL: Unique shader and Data Corruption!

This topic is 1818 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Greetings, OpenGL Masters,

 

I've been using a unique shader for several years without problem and suddenly, between minors renderer modification and NVidia drivers upgrades, something went terribly wrong.

 

My shader is fairly complex but it can render any geometry with any material properties and light count. (I’m aware that this is not optimal but it’s very easy to maintain).

 

For instance, I do skinning like so:

 

uniform int u_DeformerCount;

in vec4 a_Weights;

in ivec4 a_Deformers;

uniform mat4 u_XFormMatrix[40]; /// Deformation matrices.

 

                if (u_DeformerCount > 0) /// Matrix deformations.

                {

                                mat4 l_deformer;

                               

                                for (int i = 0; i < 4; ++i) /// Maximum of 4 influences per vertex.

                                {

                                                l_deformer += a_Weights[i] * u_XFormMatrix[a_Deformers[i]];

 

SNIP....

                }

 

The problem:
While everything works without a glitch when u_DeformerCount > 0, there seems to be data corruption with geometries that doesn’t have the skinning condition enabled. I’m basically getting black frames frequently, like a kid playing with the light interrupter.

 

Now, I can make the problem disappeared by using u_XFormMatrix[0] instead of u_XFormMatrix[a_Deformers[i]]... I tried everything I could think of so far to fix this and I’m at the point where I could use Jedi Master’s wisdom.

 

- How could a part of the shader that is not used explicitly affect its output?

- Any known pitfall using uniform arrays?

 

PS: The major downside of a unique shader is that every uniforms needs to be set/reset every draw and I’m guessing it could be the source of my problem.

Share this post


Link to post
Share on other sites

GPUs tend to compute both sides of an 'if' statement (true and false cases) then after it has done this it picks the side that matches the 'if' statement outcome. It does this because of how parallel processing is handled and doesn't really behave like 'if' statements on the CPU. So my guess would be your having errors because it's reading uninitialized data from "a_Deformers" then accessing data beyond the array bounds of "u_XFormMatrix". Try giving your data default values and see if your errors continue.

 

For example, when a mesh doesn't need skinning set all values of "a_Deformers" to zero, that way its elements are within your array bounds of "40". 

Edited by Nyssa

Share this post


Link to post
Share on other sites
Thx for your suggestion Nyssa,
For example, when a mesh doesn't need skinning set all values of "a_Deformers" to zero, that way its elements are within your array bounds of "40". 

Did you have in mind setting all values using glVertexAttribIPointer or in the shader some how?

EDIT: can't assign to varying in the shader. I'm guessing you meant glVertexAttribIPointer. PS: I do use glDisableVertexAttribArray a_Deformers when no skinning is needed. Still digging. Edited by Neosettler

Share this post


Link to post
Share on other sites

If you were to do it from the shader then it would have to be via the preprocessor. For example:

#ifdef USE_SKINNING
if (u_DeformerCount > 0) /// Matrix deformations.
{
      mat4 l_deformer;
                               
      for (int i = 0; i < 4; ++i) /// Maximum of 4 influences per vertex.
      {
           l_deformer += a_Weights[i] * u_XFormMatrix[a_Deformers[i]];
      }
}
#endif

 

This has the bonus of removing code that is not needed for non skinned objects and may speed up your application a little.

 

Otherwise you can do it on the CPU during your programs initialization. If you have access to the raw vertex array data before it enters OpenGL then I'd simply change the values there to zero (EDIT : or remove them entirely!). Otherwise you would need to access it from OpenGL using a function like "glMapBuffer" and changing the values from there.

Edited by Nyssa

Share this post


Link to post
Share on other sites

Using glVertexAttribIPointer or glDisableVertexAttribArray isn't going to help on its own cause "a_Deformers" will still be uninitialized if you don't update your shader code aswell to remove the skinning portion.

Share this post


Link to post
Share on other sites

Interesting, I was not aware we could do preprocessor #if. Is this a GLSL feature or you need to parse your shader and string edit it?

 

This has the bonus of removing code that is not needed for non skinned objects and may speed up your application a little.
Otherwise you can do it on the CPU during your programs initialization. If you have access to the raw vertex array data before it enters OpenGL then I'd simply change the values there to zero (EDIT : or remove them entirely!)


I agree but unless I’m missing something, while these seems to be valid solutions, it will make the unique shader concept collapse as we might alternate the skinning condition every draw.
 

Otherwise you would need to access it from OpenGL using a function like "glMapBuffer" and changing the values from there


This seems to be to most logical direction. The shader uses glBufferSubData for the vertex attributes, I’ll have to investigate glMapBuffer… this is puzzling. Thanks again for your inputs Nyssa.

 

Share this post


Link to post
Share on other sites

I believe preprocessing was available in glsl from version 1.10 (I think). EDIT : Check out the GLSL spec from page 9 here. And glBufferSubData is similar to glMapBuffer, you could use either one I guess.

 

 

I agree but unless I’m missing something, while these seems to be valid solutions, it will make the unique shader concept collapse as we might alternate the skinning condition every draw.

 

This is true. Is the idea of your unique shader to use the same shader for every object? While I understand the simplicity of that, it would result in alot of redundant calculations (such as skinning for non skinned objects). You could group skinned and non skinned objects together for rendering so there is no alternating?

 

A similar approach to what you're doing is called an Uber shader. Basically a shader with all possible combinations in it and uses alot of #defines to create the shader that's needed.

Edited by Nyssa

Share this post


Link to post
Share on other sites

If I'm going down that route I prefer a collection of "mini-uber" shaders.  Instead of one single great-big-whopping shader for everything, isolate out maybe 4 to 5 different types of object - something like unskinned mesh, skinned mesh, particles, 2D GUI, or whatever - then build an uber shader for each of those.  Using GLSL's compilation model you can quite easily insert snippets of common code too, so if your lighting model needs to be shared between more than one shader type, just split it off and add it to your array of GLchar * passed to glShaderSource.  That seems a bit more work on the C/C++ end of things, but you'll find it much more flexible than what you currently have.

Share this post


Link to post
Share on other sites
GPUs tend to compute both sides of an 'if' statement (true and false cases) then after it has done this it picks the side that matches the 'if' statement outcome.

 

This depends very much on the GPU in question; anything in the last few years will have true branching support and only execute the code required by the outcome of the conditional compare the executing work group.

 

That means that if all your threads in the work group evaluate to 'true' it will ONLY take the true path, if 'false' then only the false path.

Now, if some threads are true and some are false then it will execute both paths BUT the GPU will mask out threads which aren't required to execute as such they have no impact on the running of the other threads.

Share this post


Link to post
Share on other sites
This is true. Is the idea of your unique shader to use the same shader for every object?

Yes indeed,
While I understand the simplicity of that, it would result in alot of redundant calculations

Well, I was under the impression a if statement is a if statement... apparently, the portion inside a condition that is not being use has to be considered has if it was in order for the shader to render correctly. Strangely, the bug is not constant and very hard to track. I did noticed however that it rendered correctly when removing few objects from my scene which use no textures. I must be missing something.

...digging the uber shader.

Share this post


Link to post
Share on other sites

As Phantom mentioned on newer cards your if statements would perform more like CPU if statements. But from the sounds of it your card might be a few years old so Uber shaders might be your answer. Like most good things in life there is a down side to them, they can become a bit of a nightmare to manage the larger they get.

 

Try to run your program through an app like gDEbugger or GPU PerfStudio so you can see what data OpenGL is receiving. Makes debugging a bit easier. Some objects might be overwriting uniform buffer data or something.

Share this post


Link to post
Share on other sites
very good find Nyssa with the gDEBugger, Nice tool! It turns out that my glitch was caused by the lack of calling glFinish!

case closed. thank you all for your inputs.

Cheers!

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Similar Content

    • By khawk
      We've just released all of the source code for the NeHe OpenGL lessons on our Github page at https://github.com/gamedev-net/nehe-opengl. code - 43 total platforms, configurations, and languages are included.
      Now operated by GameDev.net, NeHe is located at http://nehe.gamedev.net where it has been a valuable resource for developers wanting to learn OpenGL and graphics programming.

      View full story
    • By TheChubu
      The Khronos™ Group, an open consortium of leading hardware and software companies, announces from the SIGGRAPH 2017 Conference the immediate public availability of the OpenGL® 4.6 specification. OpenGL 4.6 integrates the functionality of numerous ARB and EXT extensions created by Khronos members AMD, Intel, and NVIDIA into core, including the capability to ingest SPIR-V™ shaders.
      SPIR-V is a Khronos-defined standard intermediate language for parallel compute and graphics, which enables content creators to simplify their shader authoring and management pipelines while providing significant source shading language flexibility. OpenGL 4.6 adds support for ingesting SPIR-V shaders to the core specification, guaranteeing that SPIR-V shaders will be widely supported by OpenGL implementations.
      OpenGL 4.6 adds the functionality of these ARB extensions to OpenGL’s core specification:
      GL_ARB_gl_spirv and GL_ARB_spirv_extensions to standardize SPIR-V support for OpenGL GL_ARB_indirect_parameters and GL_ARB_shader_draw_parameters for reducing the CPU overhead associated with rendering batches of geometry GL_ARB_pipeline_statistics_query and GL_ARB_transform_feedback_overflow_querystandardize OpenGL support for features available in Direct3D GL_ARB_texture_filter_anisotropic (based on GL_EXT_texture_filter_anisotropic) brings previously IP encumbered functionality into OpenGL to improve the visual quality of textured scenes GL_ARB_polygon_offset_clamp (based on GL_EXT_polygon_offset_clamp) suppresses a common visual artifact known as a “light leak” associated with rendering shadows GL_ARB_shader_atomic_counter_ops and GL_ARB_shader_group_vote add shader intrinsics supported by all desktop vendors to improve functionality and performance GL_KHR_no_error reduces driver overhead by allowing the application to indicate that it expects error-free operation so errors need not be generated In addition to the above features being added to OpenGL 4.6, the following are being released as extensions:
      GL_KHR_parallel_shader_compile allows applications to launch multiple shader compile threads to improve shader compile throughput WGL_ARB_create_context_no_error and GXL_ARB_create_context_no_error allow no error contexts to be created with WGL or GLX that support the GL_KHR_no_error extension “I’m proud to announce OpenGL 4.6 as the most feature-rich version of OpenGL yet. We've brought together the most popular, widely-supported extensions into a new core specification to give OpenGL developers and end users an improved baseline feature set. This includes resolving previous intellectual property roadblocks to bringing anisotropic texture filtering and polygon offset clamping into the core specification to enable widespread implementation and usage,” said Piers Daniell, chair of the OpenGL Working Group at Khronos. “The OpenGL working group will continue to respond to market needs and work with GPU vendors to ensure OpenGL remains a viable and evolving graphics API for all its customers and users across many vital industries.“
      The OpenGL 4.6 specification can be found at https://khronos.org/registry/OpenGL/index_gl.php. The GLSL to SPIR-V compiler glslang has been updated with GLSL 4.60 support, and can be found at https://github.com/KhronosGroup/glslang.
      Sophisticated graphics applications will also benefit from a set of newly released extensions for both OpenGL and OpenGL ES to enable interoperability with Vulkan and Direct3D. These extensions are named:
      GL_EXT_memory_object GL_EXT_memory_object_fd GL_EXT_memory_object_win32 GL_EXT_semaphore GL_EXT_semaphore_fd GL_EXT_semaphore_win32 GL_EXT_win32_keyed_mutex They can be found at: https://khronos.org/registry/OpenGL/index_gl.php
      Industry Support for OpenGL 4.6
      “With OpenGL 4.6 our customers have an improved set of core features available on our full range of OpenGL 4.x capable GPUs. These features provide improved rendering quality, performance and functionality. As the graphics industry’s most popular API, we fully support OpenGL and will continue to work closely with the Khronos Group on the development of new OpenGL specifications and extensions for our customers. NVIDIA has released beta OpenGL 4.6 drivers today at https://developer.nvidia.com/opengl-driver so developers can use these new features right away,” said Bob Pette, vice president, Professional Graphics at NVIDIA.
      "OpenGL 4.6 will be the first OpenGL release where conformant open source implementations based on the Mesa project will be deliverable in a reasonable timeframe after release. The open sourcing of the OpenGL conformance test suite and ongoing work between Khronos and X.org will also allow for non-vendor led open source implementations to achieve conformance in the near future," said David Airlie, senior principal engineer at Red Hat, and developer on Mesa/X.org projects.

      View full story
    • By _OskaR
      Hi,
      I have an OpenGL application but without possibility to wite own shaders.
      I need to perform small VS modification - is possible to do it in an alternative way? Do we have apps or driver modifictions which will catch the shader sent to GPU and override it?
    • By xhcao
      Does sync be needed to read texture content after access texture image in compute shader?
      My simple code is as below,
      glUseProgram(program.get());
      glBindImageTexture(0, texture[0], 0, GL_FALSE, 3, GL_READ_ONLY, GL_R32UI);
      glBindImageTexture(1, texture[1], 0, GL_FALSE, 4, GL_WRITE_ONLY, GL_R32UI);
      glDispatchCompute(1, 1, 1);
      // Does sync be needed here?
      glUseProgram(0);
      glBindFramebuffer(GL_READ_FRAMEBUFFER, framebuffer);
      glFramebufferTexture2D(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
                                     GL_TEXTURE_CUBE_MAP_POSITIVE_X + face, texture[1], 0);
      glReadPixels(0, 0, kWidth, kHeight, GL_RED_INTEGER, GL_UNSIGNED_INT, outputValues);
       
      Compute shader is very simple, imageLoad content from texture[0], and imageStore content to texture[1]. Does need to sync after dispatchCompute?
    • By Jonathan2006
      My question: is it possible to transform multiple angular velocities so that they can be reinserted as one? My research is below:
      // This works quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); quat quaternion2 = GEMultiplyQuaternions(quaternion1, GEQuaternionFromAngleRadians(angleRadiansVector2)); quat quaternion3 = GEMultiplyQuaternions(quaternion2, GEQuaternionFromAngleRadians(angleRadiansVector3)); glMultMatrixf(GEMat4FromQuaternion(quaternion3).array); // The first two work fine but not the third. Why? quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); vec3 vector1 = GETransformQuaternionAndVector(quaternion1, angularVelocity1); quat quaternion2 = GEQuaternionFromAngleRadians(angleRadiansVector2); vec3 vector2 = GETransformQuaternionAndVector(quaternion2, angularVelocity2); // This doesn't work //quat quaternion3 = GEQuaternionFromAngleRadians(angleRadiansVector3); //vec3 vector3 = GETransformQuaternionAndVector(quaternion3, angularVelocity3); vec3 angleVelocity = GEAddVectors(vector1, vector2); // Does not work: vec3 angleVelocity = GEAddVectors(vector1, GEAddVectors(vector2, vector3)); static vec3 angleRadiansVector; vec3 angularAcceleration = GESetVector(0.0, 0.0, 0.0); // Sending it through one angular velocity later in my motion engine angleVelocity = GEAddVectors(angleVelocity, GEMultiplyVectorAndScalar(angularAcceleration, timeStep)); angleRadiansVector = GEAddVectors(angleRadiansVector, GEMultiplyVectorAndScalar(angleVelocity, timeStep)); glMultMatrixf(GEMat4FromEulerAngle(angleRadiansVector).array); Also how do I combine multiple angularAcceleration variables? Is there an easier way to transform the angular values?
  • Popular Now