• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Patriarch K

Removing two objects at once failure

4 posts in this topic

I'm making a java game at the moment and when I happen to kill two enemies at the exactly same time then the game crashes. I suppose it's something with threads and serializable or something. But I don't know. I use the following code when I'm removing objects from the arrayList. The problem appears when I kill two enemies at EXACTLY the same time. Then it freezes and say:

Exception in thread "Thread-3" java.lang.IllegalStateException
at java.util.ArrayList$Itr.remove(Unknown Source)
at Main.checkCollisions(Main.java:168)
at Main.run(Main.java:400)
at java.lang.Thread.run(Unknown Source)



// Skott med fiende
Iterator<Bullet> b = bubblor.iterator();
while(b.hasNext()){
Iterator<Enemy> e = enemies.iterator();
Bullet bob = b.next();
while(e.hasNext()){

Enemy fof = e.next();
Rectangle r1 = fof.getBounds();
Rectangle r2 = bob.getBounds();
if(r1.intersects(r2) ){
b.remove();
e.remove();
} } } Edited by Patriarch K
0

Share this post


Link to post
Share on other sites
From the documentation of the ArrayList:
Note that this implementation is not synchronized. If multiple threads access an ArrayList instance concurrently, and at least one of the threads modifies the list structurally, it must be synchronized externally. (A structural modification is any operation that adds or deletes one or more elements, or explicitly resizes the backing array; merely setting the value of an element is not a structural modification.)
This means that you'll have to prevent two threads from accessing the ArrayList at the same time; this could be accomplished by having a wrapper of the ArrayList that queues up addition and deletion operations, or by eschewing the use of multiple threads entirely (although you may have a good reason for going threaded)
1

Share this post


Link to post
Share on other sites
That must be the problem then. But I'm not very into that kind of stuff. Could you explain a little bit how to do what you mention and give some kind of code example?
Can I just do like this and NOTHING ELSE? This does not work because I get problems on the b.remove() every time when two bullets is shot at the same time and removed at the same time.

List list = Collections.synchronizedList(new ArrayList(...));

and:

synchronized(bubblor) {
Iterator<Test> b = bubblor.iterator();
while(b.hasNext()){
synchronized(enemies) {
Iterator<Enemy> e = enemies.iterator();
Test bob = b.next();
while(e.hasNext()){

Enemy fof = e.next();
Rectangle r1 = fof.getBounds();
Rectangle r2 = bob.getBounds();
if(r1.intersects(r2) ){
b.remove(); Edited by Patriarch K
0

Share this post


Link to post
Share on other sites

You have at least one bug that is not thread related. If you are using threads, you may have more bugs.

 

The problem is, imagine that a given bullet intersects two enemies in a single frame. What your code does is call remove() twice on the bullet iterator in this case.

 

The fix is to only remove the bullet iterator once, if any collisions have occurred:

[code] 

Iterator<Bullet> b = bullets.iterator();
while(b.hasNext()){
    Bullet bullet = b.next();
    Rectangle bulletBounds = bullet.getBounds();
    boolean collision = false;
    Iterator<Enemy> e = enemies.iterator();
    while(e.hasNext()){
        Enemy enemy = e.next();
        Rectangle enemyBounds = enemy.getBounds();
        if(enemyBounds.intersects(bulletBounds) ){
            collision = true;
            e.remove();
        } 
    } 
    
    if(collision) {
        b.remove();
    }
}
 [/code]

 

Perhaps better is to create a helper function to clarify the logic:

[code] 

private static int removeIntersectingEnemies(Rectangle bounds, List<Enemy> enemies) {
    int enemiesRemoved = 0;
    Iterator<Enemy> iterator = enemies.iterator();
    while(iterator.hasNext()){
        Enemy enemy = iterator.next();
        Rectangle enemyBounds = enemy.getBounds();
        if(enemyBounds.intersects(bounds) ){
            ++enemiesRemoved;
            iterator.remove();
        } 
    }
    return enemiesRemoved;
}
 
Iterator<Bullet> iterator = bullets.iterator();
while(iterator.hasNext()){
    Bullet bullet = iterator.next();
    int enemiesRemoved = removeIntersectingEnemies(bullet.getBounds(), enemies);
    if(enemiesRemoved > 0) {
        iterator.remove();
    }
}
[/code]
2

Share this post


Link to post
Share on other sites
Thanks a lot! That worked perfectly fine for me. Problem solved :) Edited by Patriarch K
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0