• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Khatharr

Unity
VS2010 problem with multiple declaration in for loop

9 posts in this topic

Ehh... I'm pretty sure I'm doing this right.
 
I just got a new hard drive so I took the opportunity to upgrade to Win7 and VS2010 (since I can get them free through my school).
 
I'm trying to update some code with the C++x00 stuff in VS2010 and I came across this for loop that uses an 'erase' on an iterator. That rules out using for-each, but I noticed that I have the variables declared outside the loop and I want to bring them in. (I had put them outside before because they made the line way too long, but with 'auto' and the zooming feature it's managable now.)
 
Anyway, I tried putting the declaration of both the start and end iterators in the for(), but I got a compile error.
 
Is this thing busted (again)? I've subbed in simple int's and I stil have the same problem:
void VirtualKey::unbind(const Binding& binding) {
  auto iter = m_bindings.begin();
  auto end = m_bindings.end();
  for(int i = 1, int j = 7; iter != end; ++iter) {
    if((iter->device == binding.device) && (iter->diKey == binding.diKey)) {
      iter = m_bindings.erase(iter);
      if(iter == end) {break;}
    }
  }
}
 
I'm getting:
1>ClCompile:
1>  cl_VirtualKey.cpp
1>c:\users\khatharr\desktop\khatengine\khatengine\cl_virtualkey.cpp(22): error C2062: type 'int' unexpected
1>c:\users\khatharr\desktop\khatengine\khatengine\cl_virtualkey.cpp(22): error C2143: syntax error : missing ';' before ')'
1>c:\users\khatharr\desktop\khatengine\khatengine\cl_virtualkey.cpp(22): error C2143: syntax error : missing ';' before ')'
1>c:\users\khatharr\desktop\khatengine\khatengine\cl_virtualkey.cpp(22): error C2143: syntax error : missing ';' before '{'
1>c:\users\khatharr\desktop\khatengine\khatengine\cl_virtualkey.cpp(25): error C2043: illegal break
1>
1>Build FAILED.

Edit - Nevermind, I'm an idiot. You have to chain multiple declarations off the same type statement, so it would have to be:
int i = 1, j = 7;

Which should work for the auto's as well in this case. Edited by Khatharr
0

Share this post


Link to post
Share on other sites

You still have the problem of increasing your iterator twice when you erase an object.

 

Common ways are either if/else (if -> erase, else -> increment) or erasing a tmp iterator (auto tmp = iter++).

1

Share this post


Link to post
Share on other sites
You still have the problem of increasing your iterator twice when you erase an object.
 
Common ways are either if/else (if -> erase, else -> increment) or erasing a tmp iterator (auto tmp = iter++).

 
Ah, derp. So it'd have to be:
 

void VirtualKey::unbind(const Binding& binding) {
  for(auto iter = m_bindings.begin(), end = m_bindings.end(); iter != end; ) {
    if((iter->device == binding.device) && (iter->diKey == binding.diKey)) {
      iter = m_bindings.erase(iter);
    }
    else {
      ++iter;
    }
  }
}

 

So I still can't nice-looking syntax with erase. -.-

 

 

 

 

 

You could always use the Std lib Algorithm's to side step the mistakes smile.png

m_bindings.erase(std::remove_if(std::begin(m_bindings), std::end(m_bindings), [&binding](Binding &b) { return (b.device == binding.device) && (b.diKey == binding.diKey); })
		, std::end(m_bindings));

 

Can't bring myself to do it.

0

Share this post


Link to post
Share on other sites

Nesting braces within parenthesis makes my eyes water. It's just one of those things I'm weird about.

 

I appreciate that algorithm syntax is better than it used to be, but I still just don't like it. (I'll eventually end up doing it, but I probably just need time to adapt. It took me quite a while with C++ before I started using STL.)

0

Share this post


Link to post
Share on other sites

Bear in mind that when you do erase it removes the element from the vector and then moves every element behind it up one place. If your vector is of any kind of size this rearranging of memory will be a lot slower then the STL way, which moves all the elements to be erased to the end of the vector and then erases everything at the end.

0

Share this post


Link to post
Share on other sites

When it is packed into one line it can get very dense. If you separate it out it becomes a bit more reasonable:

[code]template<typename Container, typename Predicate> void remove_and_erase_if(Container &continer, Predicate predicate) {     auto begin = std::begin(container);     auto end = std::end(container);     auto i = std::remove_if(begin, end, predicate);     container.erase(i, end); }   auto predicate = [&binding](Binding &b) {     return (b.device == binding.device) && (b.diKey == binding.diKey); } remove_and_erase_if(bindings, predicate);[/code]

In particular, that helper function can be reused wherever.

 

Consider "swap and pop", if the order is irrelevant and erasing from the middle of the container is expensive.

2

Share this post


Link to post
Share on other sites
If you swap and pop is an option, then you might also consider std::partition() with erase() as well.
1

Share this post


Link to post
Share on other sites

I'll look into it more. I never thought of partition() for this, but I guess it's similar to remove_if().

 

I'm sort of surprised that there's not already an STL algorithm for the remove_if+erase combo. Seems like something that would come up pretty often.

 

Unbinds aren't performance critical and a single VitualKey should (should, lol) only have a handful of bindings at most, but I ought to practice a better strategy for this.

 

Thanks, all.

Edited by Khatharr
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0

  • Similar Content

    • By NajeNDa
      Hi there,
      I am a game programmer (C#/C++) who is looking for a project to join. I am computer science engineer plus Master Degree in Game Development, currently working in one the most renown mobile games company (2 years academic experience, 1 year working experience).
      I have developed several prototypes or even games almost ready to release, but I always lack of artists, so I am looking for a project already set up or few artist to begin working in something.
      My preferences are:
      Unity or Unreal Engine 4 based project (UE4 prefered) PC/Console game prefered but mobile is acceptable Not interested in VR Serious team with almost all the roles filled or pretending to be filled 3D project prefered over Sprites Guaranteed 7 work hours per week, Crunch 20 work hours per week  European team (if timezone is not a problem for you, so it is not for me) I am not looking for any kind of money income from games neither the team, I want to do this as a hobby and a way to improve my skills.
      Cheers
    • By OPNeonGames
      SumiKen : Ink Blade Samurai is released! Download and leave a review to help support the game!
      Download here for free : https://play.google.com/store/apps/details?id=com.OPNeon.SumiKen&hl=en

      ★★★★★ - "Just get it it's the best runner!" - Icatsasha
      ★★★★★ - "Great game, wonderful art! Super addictive!" - EZk1ll 
      A casual samurai runner game with seven samurai and beautiful mountain paintings. Join Sumi and his samurai companions on this epic path to slash & dash through endless hordes of enemy lines. Beware of the enemy blades as a single blow from the sword blade will end it all. Will you be turned into faded ink? Or will you train and become a samurai legend?
       
    • By OPNeonGames
      Hey guys, posting my work in progress for Macho Cat here. 

      A very early prototype for Macho Cat. Everything is just placeholder for now
      What is Macho Cat?
      A silly little game where you scrub the macho cat with random objects found in trash and junkyard to please him
      Gameplay feature?
      -Cat scrubbin, lots of scrubbin
      -Unlock moar objects in junkyard 
      -Funny, silly and easy
      When will the game release?
      December 2017 (estimate)
      Interested to Beta test?
      opneongame@gmail.com
    • By MCKillerZ1
      UNITY ENGINE
      IN SEARCH FOR MEMBERS
       
      Hey there. I am currently looking for at least 4 members ( for now ) to join me in making games together.
      Sure, I'm still a student ( 17 years old ) but this is what I wish to achieve in the future.
       
      My goal is simple:
      :- Create my own game development team consisting of 5 members total.
      :- Work together as a team, and also learn game related things together.
      :- Successfully finish a simple game, and upload it to any source ( Google Play, Steam, Origin, etc... )
      :- Gain popularity as a team over the time.
       
      My role in the team is the producer or manager, or maybe the leader.
      I do have talent regarding to creating games. My main ability is creating 3D Models via SketchUp, and I've had experience doing it for about 2-3 years.
      I did learn a bit of programming, but I only understand the basics of it. I can't really make a functioning program.
      Currently, I'm learning the basics of making music using FL Studio 12, and I will learn basic animation, level design and character modelling in the future.
       
      Requirements To Join:
      1. Good English communicating skills.
      2. Always online whenever needed.
      3. Good internet connection/speed.
      4. Have a decent computer/laptop.
      5. At least knows the basics of game development related topics.
      6. Have a good camera and a set of headphones with mic, or just regular mic ( needed in the future ).
       
      Roles Available:
      1. Programmer - Main language is C#, but can also use Java ( I recommend C# ).
      2. Music Producer - Can create music according to the game's settings, and also create sounds.
      3. Animator - Can do decent animation of characters, vehicles and more.
      4. Graphics Designer - Able to do colour schemes, 2D sprites and more.
       
      Send me a message if interested.
       
       
    • By OPNeonGames
      Hey guys, posting my work in progress for Macho Cat here. 

      A very early prototype for Macho Cat. Everything is just placeholder for now
      What is Macho Cat?
      A silly little game where you scrub the macho cat with random objects found in trash and junkyard to please him
      Gameplay feature?
      -Cat scrubbin, lots of scrubbin
      -Unlock moar objects in junkyard 
      -Funny, silly and easy
      When will the game release?
      December 2017 (estimate)
      Interested to Beta test?
      opneongame@gmail.com
  • Popular Now