Followers 0

# Unity VS2010 problem with multiple declaration in for loop

## 9 posts in this topic

Ehh... I'm pretty sure I'm doing this right.

I just got a new hard drive so I took the opportunity to upgrade to Win7 and VS2010 (since I can get them free through my school).

I'm trying to update some code with the C++x00 stuff in VS2010 and I came across this for loop that uses an 'erase' on an iterator. That rules out using for-each, but I noticed that I have the variables declared outside the loop and I want to bring them in. (I had put them outside before because they made the line way too long, but with 'auto' and the zooming feature it's managable now.)

Anyway, I tried putting the declaration of both the start and end iterators in the for(), but I got a compile error.

Is this thing busted (again)? I've subbed in simple int's and I stil have the same problem:
void VirtualKey::unbind(const Binding& binding) {
auto iter = m_bindings.begin();
auto end = m_bindings.end();
for(int i = 1, int j = 7; iter != end; ++iter) {
if((iter->device == binding.device) && (iter->diKey == binding.diKey)) {
iter = m_bindings.erase(iter);
if(iter == end) {break;}
}
}
}

I'm getting:
1>ClCompile:
1>  cl_VirtualKey.cpp
1>c:\users\khatharr\desktop\khatengine\khatengine\cl_virtualkey.cpp(22): error C2062: type 'int' unexpected
1>c:\users\khatharr\desktop\khatengine\khatengine\cl_virtualkey.cpp(22): error C2143: syntax error : missing ';' before ')'
1>c:\users\khatharr\desktop\khatengine\khatengine\cl_virtualkey.cpp(22): error C2143: syntax error : missing ';' before ')'
1>c:\users\khatharr\desktop\khatengine\khatengine\cl_virtualkey.cpp(22): error C2143: syntax error : missing ';' before '{'
1>c:\users\khatharr\desktop\khatengine\khatengine\cl_virtualkey.cpp(25): error C2043: illegal break
1>
1>Build FAILED.

Edit - Nevermind, I'm an idiot. You have to chain multiple declarations off the same type statement, so it would have to be:
int i = 1, j = 7;

Which should work for the auto's as well in this case. Edited by Khatharr
0

##### Share on other sites

You still have the problem of increasing your iterator twice when you erase an object.

Common ways are either if/else (if -> erase, else -> increment) or erasing a tmp iterator (auto tmp = iter++).

1

##### Share on other sites
You still have the problem of increasing your iterator twice when you erase an object.

Common ways are either if/else (if -> erase, else -> increment) or erasing a tmp iterator (auto tmp = iter++).

Ah, derp. So it'd have to be:

void VirtualKey::unbind(const Binding& binding) {
for(auto iter = m_bindings.begin(), end = m_bindings.end(); iter != end; ) {
if((iter->device == binding.device) && (iter->diKey == binding.diKey)) {
iter = m_bindings.erase(iter);
}
else {
++iter;
}
}
}


So I still can't nice-looking syntax with erase. -.-

You could always use the Std lib Algorithm's to side step the mistakes

m_bindings.erase(std::remove_if(std::begin(m_bindings), std::end(m_bindings), [&binding](Binding &b) { return (b.device == binding.device) && (b.diKey == binding.diKey); })
, std::end(m_bindings));

Can't bring myself to do it.

0

##### Share on other sites
Can't bring myself to do it.

Why?

This code is basically self documenting and much easier to read.

2

##### Share on other sites

Nesting braces within parenthesis makes my eyes water. It's just one of those things I'm weird about.

I appreciate that algorithm syntax is better than it used to be, but I still just don't like it. (I'll eventually end up doing it, but I probably just need time to adapt. It took me quite a while with C++ before I started using STL.)

0

##### Share on other sites

Bear in mind that when you do erase it removes the element from the vector and then moves every element behind it up one place. If your vector is of any kind of size this rearranging of memory will be a lot slower then the STL way, which moves all the elements to be erased to the end of the vector and then erases everything at the end.

0

##### Share on other sites

When it is packed into one line it can get very dense. If you separate it out it becomes a bit more reasonable:

[code]template<typename Container, typename Predicate> void remove_and_erase_if(Container &continer, Predicate predicate) {     auto begin = std::begin(container);     auto end = std::end(container);     auto i = std::remove_if(begin, end, predicate);     container.erase(i, end); }   auto predicate = [&binding](Binding &b) {     return (b.device == binding.device) && (b.diKey == binding.diKey); } remove_and_erase_if(bindings, predicate);[/code]

In particular, that helper function can be reused wherever.

Consider "swap and pop", if the order is irrelevant and erasing from the middle of the container is expensive.

2

##### Share on other sites
If you swap and pop is an option, then you might also consider std::partition() with erase() as well.
1

##### Share on other sites

I'll look into it more. I never thought of partition() for this, but I guess it's similar to remove_if().

I'm sort of surprised that there's not already an STL algorithm for the remove_if+erase combo. Seems like something that would come up pretty often.

Unbinds aren't performance critical and a single VitualKey should (should, lol) only have a handful of bindings at most, but I ought to practice a better strategy for this.

Thanks, all.

Edited by Khatharr
0

## Create an account

Register a new account

Followers 0

• ### Similar Content

• By Ahrakeen
Hello our project is slowly going forward and we are now looking for an animator. to make our designs to move inside the game

it's a strategic roleplaying game.
like disgaea, children of zodiarcs , fire emblem and so on.

the maps and envirement is in 3d and we are using 2d models. but if you think you can make them 3d or have other ideas on how to solve our animation issues we are all for it

• Do you like numbers?
Actually I do.
When I was child, I enjoyed to make multiples of 10 using license plate.
It was not a big deal, but quite interesting to me.
Decades later I planned to make a game and remembered that time.
So I decided to develop game based on that memory.
At the first time , it was just game to make 10, but I started to put various game like elements:
items, obstacles, store, trophies, leader board, etc...
And finally it becomes a game.
Some people tells me it's too difficult, but some people tells me it's enjoyable.
How does it looks like to you?
"Puzzle Ten Final"
Android Exclusive.

• By Kajamaz

Summary: EverEmber Reborn is a multiplayer online hardcore open-world action RPG.

Description:
The game takes place in the world of EverEmber, a fantasy world where you have no direction, only your skill and other players to either aid or hinder you on your journey. The game is a first person open world pvp game, with progression aspects taken from agar and slither. The world is not too huge, and because of that players will constantly fight and die, dropping their obtained gear and forcing to restart. The combat is skill based, with many places to explore. The best aspects from Runescape, Ultima, Mortal online, and the Elder Scrolls games are taken and incorporated. Everyone has their own adventure, it’s your choice how it starts and ends.

EverEmber Reborn is a sequel to the game EverEmber Online (check it out at http://www.everember.com/). They are very different in their concept and execution, but the fantasy elements and ideas are brought over from its predecessor. We have been developing EverEmber online for over 4 years, but it’s time we move on. We have also worked on various private server projects, so the developmental process is nothing new for us.

Team:
We currently have a fairly large development team already, 10 main developers, myself, Ozfer (server host, developer, IT tech), Juicyz (Lead Programmer), EMPHyperdrive (Programmer) Amit (Game Developer and Modeler), HugeJackedman (Game Developer), Gw1p (Game developer), Naitsirik (Modeler), Symbolizemusic (Musician), Aytimothy (Programmer). We also have a musician assisting us (Davide Severi) with our soundtrack and a concept and concept artist (Akram). SeeEnvy is a writer for us.

What we're looking for:

What we need are programmers as of this moment. We need someone who is determined on helping us program the game itsself. We have much of the networking done and we are using Photon. The language we're using is C#, so knowledge of C# is a MUST HAVE!

Requirements:

-Experience with Unity and its technology

-Interest in the games concept

-Ability to do one of the things listed in our needs, either C# unity programming, or networking assistance.

-Time to dedicate to the game, we don’t have a constraint but a few hours every couple of days will suffice.

-Be able to communicate in English, as all of our team speaks English either fluently or well.

-Have a method through which we could pay you eventually.

Eye Candy (In-game screenshots):

More Eye Candy/Concept Art:

If you are interested, please do contact us via Everemberonline@gmail.com or message me here on unity forums with what you can do for us, why we interest you, and whatever questions or comments you have. Feel free to join our website if you cannot help us in development, but instead can assist us by playing the game upon release or testing it!

http://www.everember.com/

See you in the land of EverEmber.

• Hi, we are small game develop studio called Drunken Monday. We are only two people and during the last year we developed a cross-platform multiplayer game: Slash Arena. And we're almost done. We are glad to present you our game:

Massively multiplayer online battles with swords and axes.
Simple arcade action! Dodge the attack and choose a perfect time to strike.

Battle Modes:
★ Deathmatch — Player vs All mode for 30 players. Score the highest damage and survive to win.
★ Arena 1vs1 — ranking duel for hardcore players. Your skills mean more than your high-level weapon.
Features:
★ Rapid battles. Play 5 minutes or 5 hours. It’s all up to you!
★ Swing your hammer and make 'em fly! Damage is calculated according to physical laws. Timing and distance matter!
★ Two types of attack — enough to make your enemy suffer from a painful combo! Master your skills.
★ Separate ratings for each Battle Mode. Monitor your progress.
★ Monthly rewards for the best players. Earn a pile of resources and unique character portraits.
★ Daily tasks. See if you can cope with them! >:]
★ Three characters with unique weapons and fighting styles. More characters are coming soon!
★ More than 30 upgrade levels for each character’s weapon and armor. Start with a simple leather jacket and get to the legendary royal armor!
★ Character’s appearance changes each 3 levels. Everyone will see how cool you are!

Game available on: Facebook, it passed greenlight and coming on Steam, soft-launched on GooglePlay and AppStore in Russia ( If you contact us we will send you .apk or testflight invitation ). Also take a look at Slash Arena: Online and Drunken Monday web sites.
• By NA-45
EDIT: We've found a designer/composer and an artist.  I'm looking for one more artist!

I'm currently working on Metroidvania style game that I was inspired to start by Hollow Knight and Beksiński's art.

It's built in Unity using C# and has quite a bit done already.  I'm handling the programming myself and have a working model (besides combat which is a WIP) that can be expanded greatly depending on where we decide to take the project.  You can see the current test area here: https://streamable.com/mp5o8  Since I'm not artistically gifted, its all rectangles but can easily be skinned once we've desired on designs.
I have professional experience using Unity and C# working on both a released game and a prototype as well as having extensive Java knowledge.  I also dabble in Python with a little bit of C++.
I have worked on and completed many projects before, the most recent being a 2D stick fighting game written ground up in Java Swing (don't ask why): https://www.youtube.com/watch?v=V4Bkoyp_f0o
I'm looking for a 2D artist (potentially more than one) to create concept and game art and a designer/writer who can help flesh out the story as well as map out and create challenging and eye catching areas.  I can handle most if not all of the programming side of things though if there is anyone who is extremely passionate about this sort of thing, I'd consider splitting the load.
The end goal is a completed game that can be sold however profit isn't really a concern to me as it's mostly a labor of love from my part.  Any profits would be split between team members however that's pretty far off so don't make that a reason to join.
______________________________
The story I have in mind is something like this:
A man wakes up in a chasm that stretches seemingly endlessly in both directions lined with enormous statues.

He discovers a temple with text above a closed gate that tells of the failed kingdom that lies below.  After finding a way around this, he drops down into the subterranean kingdom.  Adventuring through the labrynth below, he comes across different cities in which the residents succumbed to different sins such as Greed, Wrath, etc.  Each city tells a story of how its fixation on something lead to their demise leading up to a fight with the personification of their mistake.
______________________________
An very rough idea for Waterways, a potential area:
- To enter you must be wearing a pair of glasses that you find somewhere earlier in the ruins.  There are similar glasses found in every home.  Everything appears incredibly beautiful however something seems wrong.  After triggering some event, the glasses break and it's revealed that the glasses are made of some sort of stone that makes everything appear differently.  The city is in ruins and absolutely disgusting as everything was neglected.
- The only thing that remains intact is in the center of the city, an incredible statue of a goddess holding up a large sphere of the same material that was used for the glass.  You slowly learn the story behind the statue: the goddess came from the sea that the city lies on and brought prosperity to them.
- After opening up the the temple of the goddess that lies right on the edge of the waters, a giant sheet of the glass covers an opening in the back of the temple that reveals the goddess behind it.  You shatter the glass and it becomes apparent that the goddess is actually a disgusting creature half beached and mostly immobile that appears to secrete the material that makes up the glass. Fight ensues.
______________________________
The combat is pretty up in the air and part of the reason I need a designer to bounce ideas off of but I think it will be something like this:
- 4 orbs equipped at a time
- 2 orbs selected at a time
- Pressing the cast button will cast a spell determined by the 2 orbs that are selected
- Spells cost mana however you can use spells with 0 mana and it will cost health instead
- These spells in addition to being useful for combat, are the Metroidvania "gating" metchanic.  For instance, one of the conceptualized spells is a water orb + water orb to create a ice pillar that can be either used to block projectiles/enemy paths or to jump on to reach high areas
______________________________
If you're interested or have any questions, contact me through discord.  My id is NA-45#3692.

• 27
• 22
• 11
• 15
• 17