• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
DavitosanX

Any suggestions for better code? Python "Guess the number"

4 posts in this topic

Hello everyone! I haven't been able to spend time programming for some months now, so I decided to brush up my very few skills by writing simple programs. I opted for "Guess the number" since it's pretty basic stuff (or so i thought). My main trouble was that I wanted to let the player quit by typing "quit", instead of asking for a number, for example "0". 

 

If any other newbie has tried out this program, the problem is when the user tries to input anything other than a number. Python (not without reason) doesn't type-cast it into anything with int(), so the program crashes. The following is my solution to this problem, but it doesn't look very elegant at all.

 

I would appreciate any suggestions on making the code better. Thanks!

 

 

 
 
from random import *
 
print("\n* * * Welcome! * * *\n\nGo ahead and try to guess a number from 1 to 10. If you feel like quitting, type QUIT\n")
 
seed()
playing = True
validating = True
number = randint(1,10)
 
while playing:
 
    while validating:
        guess = input("Your guess? ")
        try:
            int(guess)
            break
        except:
            if str.upper(guess) == "QUIT":
                print ("Goodbye!")
                validating = False
                playing = False
            else:
                print("\nI don't think that was a number\n")
 
    if playing == False:
        break
    
    if int(guess) == 0:
        print ("Goodbye!")
        playing = False
    elif int(guess) < number:
        print("\nA little higher...\n")
    elif int(guess) > number:
        print("\nA little lower...\n")
    else:
        print("\nYou got it!\n")
        playing = False
 
 

 

0

Share this post


Link to post
Share on other sites
My Python is rusty, but you should be able to do a string check to see if the input is "quit" first, and if not, do the int() cast and proceed as usual. That'll eliminate the exception handling piece.

Of course, the other side of that is that having a program that can robustly deal with unexpected inputs is a very Good Thing™, so it's really up to you if you value shorter code or more robust code at this point :-)
1

Share this post


Link to post
Share on other sites
As ApochPiQ said, you can use string check methods to check your inputs, but the pythonic way is to use try/except blocks as you did.

Here is how you could do with if/else statements.
validating = True
guess = input("Your guess? ")
while validating is True:
    # checks for quit
    if guess.isalpha() and guess.upper() == "QUIT":
        print ("Goodbye!")
        validating = False
        playing = False
    # checks for valid number
    elif guess.isdigit():
        validating = False
        guess = int(guess)
    # bad input, continue validating
    else:
        print("I don't think that was a number")
        guess = input("Your guess? ")
      
1

Share this post


Link to post
Share on other sites
One thing I would recommend avoiding is repeating the same computation over and over, which is what you are doing when you use [tt]int(guesss)[/tt] repeatedly. Calculate it once and store the result somewhere.
1

Share this post


Link to post
Share on other sites

Thanks a lot for your replies. I didn't know there were isalpha() and isdigit(). I tried looking up the subject searching "validate type in python", maybe it was a bad choice of words.

 

 

 

One thing I would recommend avoiding is repeating the same computation over and over, which is what you are doing when you use [tt]int(guesss)[/tt] repeatedly. Calculate it once and store the result somewhere.

 

 

I'll try to remember this. Good advice.

 

All in all, I guess I wasn't too far off anyway, which is good news. Thanks again!

0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0