• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
johnmarinelli

Simple question regarding deleting allocated memory

4 posts in this topic

Hi everyone,

 

So I have a class called c_Zombie.  I also have a class called c_AIstates, which is an FSM for the zombie's AI.

In my zombie class, I create a pointer of type c_AIstate:

(pseudocode)

class c_Zombie
{
private:
c_AIstate *currentAIstate;

public:
...
}

it also has a pointer to the animation class as well.  many of my entity classes contain pointers to their various "components". 

my question is: why do I get errors when I delete my pointers in the Zombie destructor? 

c_Zombie::~c_Zombie(void)
{
	delete currentAIstate;
	currentAIstate = NULL;

	delete onAnimate;
	onAnimate = NULL;
}

 

I'm sure that I should know the answer but I dont sad.png

also,

assuming that i actually SHOULDN'T be explicitly deleting the pointers in the Zombie's dctor, how does the memory get deleted?  or should it not be deleted at all?

 

EDIT: okay, the program is working now - however, I know with certainty that the same issue arises if I delete an SDL_Surface* in the dstructor, and/or an onAnimate* in some other classes.

 

 

Thanks for your time!

Edited by johnmarinelli
0

Share this post


Link to post
Share on other sites
The problem here appears to be that either currentAIstate was not constructed with new, or that you are sharing AI states between c_Zombie instances (so when you delete one c_Zombie's AI state, you are causing problems for other instances which were still using that AI state). Keep in mind that you should only use delete on objects constructed with new (so don't use delete on SDL_Surfaces) Edited by RulerOfNothing
0

Share this post


Link to post
Share on other sites
What you do with a pointer in a destructor depends entirely on how you got that pointer.

The problem with raw pointers is they have no concept of ownership semantics - i.e. who is responsible for cleaning up the object. Smart pointers are the solution to that problem; I'd suggest studying up on them.

In the interim, the easy solution is to make sure you know who owns the object you're trying to delete. Also, remember that you only delete what you new, and only delete[] what you new[]. So:
void Frobnicate(SomeObject* p)
{
    p->DoStuff();
    delete p;
}

int main()
{
    SomeObject foo;
    Frobnicate(&foo);   // BAD! I didn't new foo, so I shouldn't delete it

    SomeObject* bar = new SomeObject;
    Frobnicate(bar);    // OK
    bar->MoreStuff();   // BAD! I own bar, but Frobnicate() deleted it out from under me
}
0

Share this post


Link to post
Share on other sites

Thanks guys, your responses helped a lot.  I've heard of smart pointers, and plan to really look into them soon. 

 

One more question:

If I don't delete onAnimate in an objects destructor, and that object gets deleted (say the player enters a building and all the objects from the previous gamestate are deleted), will a "memory leak" result?  I understand the concept of a memory leak; however I can't say I know exactly how to tell when one has happened/is happening.

0

Share this post


Link to post
Share on other sites
That depends on what onAnimate actually points to. Is it a function pointer or does it point to some sort of wrapper class? In the first case, no memory was actually allocated (and since you should only delete what you new, you shouldn't delete function pointers). In the second case, it will leak memory if it was allocated on the heap.
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0