• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Randall Perkins

Compiler error on Counting how many lines there is?

11 posts in this topic

This is the function

int count_lines(char *text) {
    printf("Testing count lines :D \n");
    char *result;
    int return_lines = 0;
    result = strtok(text,"\n");
    while(result != NULL) {
        return_lines+= 1;
        result = strtok(NULL,"\n");
    }
    return return_lines;
}

 

 

Example how i use the function

 

int main(){
    int lines = count_lines("This is a simple game lets enjoy this\nIt breaks a new era in to games\nwhahahaha zoom in");
    printf("Line Count : %i \n", lines);
    return 0;
}

 

 

Compiler Errors

 

In function 'count_lines':
warning: implicit declaration of function 'strtok'
warning: assignment makes pointer from integer without a cast
warning: assignment makes pointer from integer without a cast

 

 

0

Share this post


Link to post
Share on other sites

Those are actually warnings, not errors. And it means the compiler doesn't know what 'strtok' is, and because this is C, all undeclared function prototypes implicitly default to a prototype which returns int (resulting in those incorrect assignments, since the actual function was meant to return a char*).

 

The solution is to find the correct header for strtok. A quick google search tells me it's "string.h", so make sure you have included this file in your project, with:

 

 

 

#include <string.h>

 

 

Also, what are your compiler settings? Some particular combinations may produce false positives, in particular if you request extensions from the compiler via command-line argument, but don't set the appropriate macro, and others will just plain not work until you tell the compiler you want such and such function (if it's non-standard).

Edited by Bacterius
2

Share this post


Link to post
Share on other sites

strtok modifies the string you pass, but you're passing a string literal which cannot be modified. You have to allocate memory for the string, either dynamically or statically.

[code]char string[] = "This is a simple game lets enjoy this\nIt breaks a new era in to games\nwhahahaha zoom in"; int lines = count_lines(string);[/code]

2

Share this post


Link to post
Share on other sites

[quote name='Brother Bob' timestamp='1358679138' post='5023455']
strtok modifies the string you pass[/quote]

Which fact should suggest that strtok() is not necessarily a good way to accomplish this task. I'd suggest that a naive loop over the original string, counting each '\n' as you encounter it, would be a better solution.

1

Share this post


Link to post
Share on other sites
strtok modifies the string you pass, but you're passing a string literal which cannot be modified.
String literals can be modified. There's a laundry list of reasons why it's not a good idea though.

Edit - Ah, I should qualify that. You'd have to have module page write permission to modify it. Forgot that part. Edited by Khatharr
0

Share this post


Link to post
Share on other sites

[quote name='Khatharr' timestamp='1358719824' post='5023646']
String literals can be modified. There's a laundry list of reasons why it's not a good idea though.[/quote]

String literals are specifically not writable.

 

It may depend on the particular implementation whether or not string literals are actually stored in read-only memory, however.

2

Share this post


Link to post
Share on other sites
All the versions of the C++ standard state that attempting to modify a string literal is undefined behavior.
2

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0