• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
mypel16000

Killing AI

34 posts in this topic

@bleferog: That's it! I no longer count with the problem of various zombies being deleted at the same time. But one last thing, the swap function is not working..... only the last one is getting deleted.

0

Share this post


Link to post
Share on other sites

[quote]

...But one last thing, the swap function is not working..... only the last one is getting deleted.

[/quote]

If your vector is not holding pointers as elements then you must implement "proper" copy constructor and assignment operator, as implicit one might not do the job well depending on the data your zombie class is holding.

 

What not use shared_ptr?

 

[code]class CZombie { private:     bool dead;     int health; public:     CZombie(int h) : dead(false), health(h) {}     ...     bool isDead() const { return dead; }     void takeDamage(int damage)     {         health -= damage;         if(health <= 0)             dead = true;     } };   typedef std::shared_ptr<CZombie> sp_Zombie; typedef std::vector<sp_Zombie> v_Zombie; ... v_Zombie zombies; ...
    zombies.push_back( std::make_shared<CZombie>(100) );
    zombies.push_back( std::make_shared<CZombie>(120) );
    zombies.push_back( std::make_shared<CZombie>(100) );
    zombies.push_back( std::make_shared<CZombie>(150) ); ...     for(std::size_t i = 0; i < zombies.size(); ++i)
    {
        if(zombies[i]->isDead())
        {
            std::swap(zombies[i--], zombies.back());
            zombies.pop_back();
        }
    }[/code]

Notice that i moved decrement up and make it post-decrement, witch does the same thing, but have one line of code less. laugh.png

2

Share this post


Link to post
Share on other sites

I appreciate you giving me a solution to the problem, but this doesn't work on my C++.... y get the error 

expected initializer before '<' token| for the line typedef std::shared_ptr<CZombie> sp_Zombie;

Isn't there a simpler way of initialising a vector of pointers like maybe creating an array of objects and then using them to create a vector.... Please, I have got really far and I am just stuck on this silly little thing that I just can't seem to fix

0

Share this post


Link to post
Share on other sites

actually your code doesn't work. It doesn't actually swap the objects, it just deletes the last one. I'm in need of a solution for your code

0

Share this post


Link to post
Share on other sites

Do you have included <memory> header? It is necessary for shared_ptr.

What compiler are you using?

 

If you want "pure" pointers then code is a bit different:

[code]class CZombie { ...
};   typedef std::vector<CZombie*> v_Zombies   class CZombieMgr {     v_Zombies zombies; public: ...   ~CZombieMgr() {     for(std::size_t i = 0; i < zombies.size(); ++i)     {         delete zombies[i];
    }
}   void addZombie(int h) {     zombies.push_back( new CZombie(h) );
}   void removeDeadZombies() {     for(std::size_t i = 0; i < zombies.size(); ++i)     {         if(zombies[i]->isDead())         {             std::swap( zombies[i--], zombies.back() );             delete zombies.back();             zombies.pop_back();         }
    }
}; ...[/code]

1

Share this post


Link to post
Share on other sites

@moderators

Sorry for double post, but if i go to EDIT then it somehow messes my code up.

 

@mypal1600000

Can you post relevant bits from your code? it will be easier to help you.

1

Share this post


Link to post
Share on other sites

No! It won't be needed as my code has been fixed. Thanks to all of you who, by discussing together, have found the solution to the problem.

0

Share this post


Link to post
Share on other sites

Without iterators:

for(std::size_t i = 0; i < v.size(); ++i)
	{
		if(v[i].dead)
		{
			
			std::swap(v[i], v.back());
			v.pop_back();
			--i;
		}
	}

Remember that modification of the for-loop index inside the loop is one bad programming practice. It usually leads to infinite loops and computer hang ups.

1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0