Sign in to follow this  
Pateman

OpenGL GLSL Skinning problem

Recommended Posts

Pateman    184

Hello community,

 
Ok, first of all, I'm using OpenGL 3, 3ds max, and Delphi to create a skeletal animation demo. I'm using the IGame interface to export meshes from 3ds max to XML - I use the sample included in the SDK.
 
Now, I'm going to describe as precisely as I can what I do.
 
Passing bone weights to the shader
I'll skip parsing geometry, because it works okay. Now, if a mesh is skinned (using the Physique modifier), the resulting XML contains information about bone influences for each vertex, like so:
    <Skin VertexID="2" Type="Rigid">
       <Bone BoneID="22" Weight="1,000000"></Bone>
    </Skin>
    ...
    <Skin VertexID="14" Type="Blended">
       <Bone BoneID="22" Weight="0,986472"></Bone>
       <Bone BoneID="14" Weight="0,013015"></Bone>
       <Bone BoneID="23" Weight="0,000513"></Bone>
    </Skin>
    ...
    <Skin VertexID="31" Type="Blended">
       <Bone BoneID="22" Weight="0,948354"></Bone>
       <Bone BoneID="23" Weight="0,030462"></Bone>
       <Bone BoneID="23" Weight="0,011265"></Bone>
       <Bone BoneID="14" Weight="0,009909"></Bone>
       <Bone BoneID="23" Weight="0,000011"></Bone>
    </Skin>

My shader assumes that there should be always 4 bones, which influence a single vertex, and as you can see, sometimes there is sulprus/insufficient number of them, so I decided to:

  1. Sum up weights of the same bone - take a look at vertex 31 - there are five entries, but after summing them up, we're left with three.
  2. Pad the remaining number of weights with zero.
Right now, I have a list of bone IDs/vertex weight pairs, which I pass to the shader like so:
    const
       MAX_BONES_PER_VERTEX = 4;
    
    type
       TVertexWeight = record
          BoneID: Integer;
          Weight: Single; // standard float
       end;
    ...
    var
      L: TList<TVertexWeight>;
    ...
    glGenBuffers(1, @FBonesVBO);
    glBindBuffer(GL_ARRAY_BUFFER, FBonesVBO);
    glBufferData(GL_ARRAY_BUFFER, L.ListSize, L.ListPointer, GL_STATIC_DRAW);
    
    glEnableVertexAttribArray(FBoneIDsAttr);
    glVertexAttribIPointer(FBoneIDsAttr, MAX_BONES_PER_VERTEX, GL_INT,
       SizeOf(TVertexWeight), PInteger(0));
    
    glEnableVertexAttribArray(FWeightsAttr);
    glVertexAttribPointer(FWeightsAttr, MAX_BONES_PER_VERTEX, GL_FLOAT,
       False, SizeOf(TVertexWeight), PInteger(4));

I think this part is working fine, because when I hardcode an identity matrix in the shader, the model is rendered in its bind pose.

 
Computing bone matrices
For now, I just want to display the model in a pose which it would be in, let's say, frame 49:
3oZhZ.png
 
Here's the code I use:
procedure CalculateBones(const SequenceName: String; const FrameID: Integer;
const ABone: TAnimatedMeshBone; const ParentTransform: TBrainMatrix);
var
   Samples: TBrainList<TAnimatedMeshAnimationSample>;
   BoneSample: TAnimatedMeshAnimationSample;
   I: Integer;
   BoneTransform, GlobalTransform: TBrainMatrix;
   Children: TBonesList;
begin
   Samples := TBrainList<TAnimatedMeshAnimationSample>.Create();
   Children := TBonesList.Create();
   try
      FAnims[SequenceName].SamplesByFrame(FrameID, Samples);
      BoneSample := nil;
      for I := 0 to Samples.Count -1 do
         if (Samples[I].Bone.ID = ABone.ID) then
         begin
            BoneSample := Samples[I];
            break;
         end;


      BoneTransform := ABone.OffsetMatrix;
      if (BoneSample <> nil) then
         BoneTransform := BoneSample.Matrix;
      
      GlobalTransform := Mat4Multiply(ParentTransform, BoneTransform);


      BoneMatrices.Add(GlobalTransform);


      FBones.BonesByParentID(ABone.ID, Children);
      for I := 0 to Children.Count -1 do
         CalculateBones(SequenceName, FrameID, Children[I], GlobalTransform);
   finally
      Samples.Free();
      Children.Free();
   end;
end;
...
BoneMatrices := TBrainList<TBrainMatrix>.Create();
try
   // A bone's offset matrix is the bind pose.
   CalculateBones('zhuxian2', 49, FBones.RootBone, FBones.RootBone.OffsetMatrix);
   glUniformMatrix4fv(FShader.GetUniformLocation('boneMatrices'),
      BoneMatrices.Count, False, BoneMatrices.ListPointer);
finally
   BoneMatrices.Free();
end;
A bone's OffsetMatrix is basically the bind pose (regarding to what the exporter says, it's in object space) of the bone. Now, a TAnimatedMeshAnimationSample contains position and rotation (in quaternion) of a bone in the given frame. The loop at the top of CalculateBones() basically checks if in the given frame (in this case, 49th) there's transformation data for the given bone.
 
After launching the code above, all I get is this: (please ignore the lack of textures for now)
HBJjC.png
 
But when I change the initial parent transform from FBones.RootBone.OffsetMatrix to Mat4Identity() (basically use an identity matrix), the model is displayed in its bind pose:
5hcab.png
 
Vertex shader code

 

#version 150


#define MAX_BONES_PER_VERTEX 4
#define MAX_BONES 32


uniform mat4 proj;
uniform mat4 modelview;
uniform mat4 boneMatrices[MAX_BONES];


in vec3 vertex;
in vec3 normal;
in vec2 texCoord;
in ivec4 boneIDs;
in vec4 boneWeights;


out vec4 fragmentColor;


float phong_weightCalc(in vec3 light_pos, in vec3 frag_normal) {
   return max(0.0, dot(frag_normal, light_pos));
}


mat4 getBoneMatrix(int boneIndex) {
   mat4 retMat = mat4(1.0);
   if (boneIDs[boneIndex] != 0) {
      retMat = boneMatrices[boneIDs[boneIndex]];
   }
   return retMat;   
}


float getWeight(int boneIndex) {
   float res = 1.0;
   if (boneIDs[boneIndex] != 0) {
      res = boneWeights[boneIndex];
   }
   return res;
}


void main() {
   vec3 EC_Light_location = vec3(0.0, 1.0, 1.0);
   
   float diffuse_weight = phong_weightCalc(
      normalize(EC_Light_location),
      normalize(normal)
   );
   
   fragmentColor = clamp(
      (
         (vec4(0.2, 0.2, 0.2, 1.0))
         + (vec4(0.8, 0.8, 0.8, 1.0) * diffuse_weight)
      ), 
      0.0, 1.0);
         
   float totalWeight = 0.0;
   vec4 PosL = vec4(0.0, 0.0, 0.0, 1.0);
   for (int i = 0; i < MAX_BONES_PER_VERTEX; i++) {
      float w = getWeight(i);
      PosL += w * (vec4(vertex, 1.0) * getBoneMatrix(i));
      totalWeight += w;
   }
   PosL /= totalWeight;
   PosL.w = 1.0;


   gl_Position = proj * modelview * PosL;
}

 

The question is, can someone point out what is wrong with the code?

 
Thank you very much.
 
PS. If you need any more information, please let me know.

 

Share this post


Link to post
Share on other sites
C0lumbo    4411

I'm afraid I haven't read through all the code, but one quick idea; when you create a 'Pad the remaining number of weights with zero' are you also setting the bone ID to something valid? I once had an issue on a console where a weight of zero combined with an invalid bone matrix to produce a non-zero garbage value on the GPU.

Share this post


Link to post
Share on other sites
Pateman    184

[quote name='C0lumbo' timestamp='1358784975' post='5023946']
when you create a 'Pad the remaining number of weights with zero' are you also setting the bone ID to something valid?
[/quote]

Yes, I set it to zero, then in the shader I verify whether the bone ID is set to 0, like so:

 

 

mat4 getBoneMatrix(int boneIndex) {
   mat4 retMat = mat4(1.0);
   if (boneIDs[boneIndex] != 0) {
      retMat = boneMatrices[boneIDs[boneIndex]];
   }
   return retMat;   
}

float getWeight(int boneIndex) {
   float res = 1.0;
   if (boneIDs[boneIndex] != 0) {
      res = boneWeights[boneIndex];
   }
   return res;
}

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Similar Content

    • By markshaw001
      Hi i am new to this forum  i wanted to ask for help from all of you i want to generate real time terrain using a 32 bit heightmap i am good at c++ and have started learning Opengl as i am very interested in making landscapes in opengl i have looked around the internet for help about this topic but i am not getting the hang of the concepts and what they are doing can some here suggests me some good resources for making terrain engine please for example like tutorials,books etc so that i can understand the whole concept of terrain generation.
       
    • By KarimIO
      Hey guys. I'm trying to get my application to work on my Nvidia GTX 970 desktop. It currently works on my Intel HD 3000 laptop, but on the desktop, every bind textures specifically from framebuffers, I get half a second of lag. This is done 4 times as I have three RGBA textures and one depth 32F buffer. I tried to use debugging software for the first time - RenderDoc only shows SwapBuffers() and no OGL calls, while Nvidia Nsight crashes upon execution, so neither are helpful. Without binding it runs regularly. This does not happen with non-framebuffer binds.
      GLFramebuffer::GLFramebuffer(FramebufferCreateInfo createInfo) { glGenFramebuffers(1, &fbo); glBindFramebuffer(GL_FRAMEBUFFER, fbo); textures = new GLuint[createInfo.numColorTargets]; glGenTextures(createInfo.numColorTargets, textures); GLenum *DrawBuffers = new GLenum[createInfo.numColorTargets]; for (uint32_t i = 0; i < createInfo.numColorTargets; i++) { glBindTexture(GL_TEXTURE_2D, textures[i]); GLint internalFormat; GLenum format; TranslateFormats(createInfo.colorFormats[i], format, internalFormat); // returns GL_RGBA and GL_RGBA glTexImage2D(GL_TEXTURE_2D, 0, internalFormat, createInfo.width, createInfo.height, 0, format, GL_FLOAT, 0); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); DrawBuffers[i] = GL_COLOR_ATTACHMENT0 + i; glBindTexture(GL_TEXTURE_2D, 0); glFramebufferTexture(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0 + i, textures[i], 0); } if (createInfo.depthFormat != FORMAT_DEPTH_NONE) { GLenum depthFormat; switch (createInfo.depthFormat) { case FORMAT_DEPTH_16: depthFormat = GL_DEPTH_COMPONENT16; break; case FORMAT_DEPTH_24: depthFormat = GL_DEPTH_COMPONENT24; break; case FORMAT_DEPTH_32: depthFormat = GL_DEPTH_COMPONENT32; break; case FORMAT_DEPTH_24_STENCIL_8: depthFormat = GL_DEPTH24_STENCIL8; break; case FORMAT_DEPTH_32_STENCIL_8: depthFormat = GL_DEPTH32F_STENCIL8; break; } glGenTextures(1, &depthrenderbuffer); glBindTexture(GL_TEXTURE_2D, depthrenderbuffer); glTexImage2D(GL_TEXTURE_2D, 0, depthFormat, createInfo.width, createInfo.height, 0, GL_DEPTH_COMPONENT, GL_FLOAT, 0); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); glBindTexture(GL_TEXTURE_2D, 0); glFramebufferTexture(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, depthrenderbuffer, 0); } if (createInfo.numColorTargets > 0) glDrawBuffers(createInfo.numColorTargets, DrawBuffers); else glDrawBuffer(GL_NONE); if (glCheckFramebufferStatus(GL_FRAMEBUFFER) != GL_FRAMEBUFFER_COMPLETE) std::cout << "Framebuffer Incomplete\n"; glBindFramebuffer(GL_FRAMEBUFFER, 0); width = createInfo.width; height = createInfo.height; } // ... // FBO Creation FramebufferCreateInfo gbufferCI; gbufferCI.colorFormats = gbufferCFs.data(); gbufferCI.depthFormat = FORMAT_DEPTH_32; gbufferCI.numColorTargets = gbufferCFs.size(); gbufferCI.width = engine.settings.resolutionX; gbufferCI.height = engine.settings.resolutionY; gbufferCI.renderPass = nullptr; gbuffer = graphicsWrapper->CreateFramebuffer(gbufferCI); // Bind glBindFramebuffer(GL_DRAW_FRAMEBUFFER, fbo); // Draw here... // Bind to textures glActiveTexture(GL_TEXTURE0); glBindTexture(GL_TEXTURE_2D, textures[0]); glActiveTexture(GL_TEXTURE1); glBindTexture(GL_TEXTURE_2D, textures[1]); glActiveTexture(GL_TEXTURE2); glBindTexture(GL_TEXTURE_2D, textures[2]); glActiveTexture(GL_TEXTURE3); glBindTexture(GL_TEXTURE_2D, depthrenderbuffer); Here is an extract of my code. I can't think of anything else to include. I've really been butting my head into a wall trying to think of a reason but I can think of none and all my research yields nothing. Thanks in advance!
    • By Adrianensis
      Hi everyone, I've shared my 2D Game Engine source code. It's the result of 4 years working on it (and I still continue improving features ) and I want to share with the community. You can see some videos on youtube and some demo gifs on my twitter account.
      This Engine has been developed as End-of-Degree Project and it is coded in Javascript, WebGL and GLSL. The engine is written from scratch.
      This is not a professional engine but it's for learning purposes, so anyone can review the code an learn basis about graphics, physics or game engine architecture. Source code on this GitHub repository.
      I'm available for a good conversation about Game Engine / Graphics Programming
    • By C0dR
      I would like to introduce the first version of my physically based camera rendering library, written in C++, called PhysiCam.
      Physicam is an open source OpenGL C++ library, which provides physically based camera rendering and parameters. It is based on OpenGL and designed to be used as either static library or dynamic library and can be integrated in existing applications.
       
      The following features are implemented:
      Physically based sensor and focal length calculation Autoexposure Manual exposure Lense distortion Bloom (influenced by ISO, Shutter Speed, Sensor type etc.) Bokeh (influenced by Aperture, Sensor type and focal length) Tonemapping  
      You can find the repository at https://github.com/0x2A/physicam
       
      I would be happy about feedback, suggestions or contributions.

    • By altay
      Hi folks,
      Imagine we have 8 different light sources in our scene and want dynamic shadow map for each of them. The question is how do we generate shadow maps? Do we render the scene for each to get the depth data? If so, how about performance? Do we deal with the performance issues just by applying general methods (e.g. frustum culling)?
      Thanks,
       
  • Popular Now